View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0012674 | Scribus | Shape Drawing | public | 2014-09-07 23:55 | 2015-02-23 19:04 |
Reporter | FirasH | Assigned To | cbradney | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Platform | x86_64 | OS | FreeBSD | OS Version | 10.0 |
Product Version | 1.5.0svn | ||||
Target Version | 1.5.0 | Fixed in Version | 1.5.0svn | ||
Summary | 0012674: [TESTED-PATCH] Nodes tool might lead to strange results if Locking is applied | ||||
Description | Nodes tool might lead to strange results if Locking is applied. | ||||
Steps To Reproduce | 0) Create a new document 1) Insert an item with nodes (example: Shape) 2) Double-click on the item so that "Nodes" window appears 3) Go to: Item > Locking > Is Locked 4) Move the nodes of the item You can notice that "Is Locked" is affecting the behaviour of the nodes. 5) Close "Nodes" window The bounding box does not correspond to the item if nodes are moved outside of the "original size". | ||||
Additional Information | 1.4.5.svn (19561) 1.5.0.svn (19487) | ||||
Tags | No tags attached. | ||||
Patch | No | ||||
|
|
|
confirmed on r19492 |
|
12674-FinalPatch.diff (1,067 bytes)
Index: scribus/appmodehelper.cpp =================================================================== --- scribus/appmodehelper.cpp (revisione 19562) +++ scribus/appmodehelper.cpp (copia locale) @@ -538,6 +538,7 @@ (*a_scrActions)["toolsPDFAnnot3D"]->setEnabled(b2); #endif (*a_scrActions)["itemDelete"]->setEnabled(b2); + (*a_scrActions)["itemLock"]->setEnabled(b2); (*a_scrActions)["itemConvertToTextFrame"]->setEnabled(b2); (*a_scrActions)["itemConvertToImageFrame"]->setEnabled(b2); (*a_scrActions)["itemConvertToPolygon"]->setEnabled(b2); Index: scribus/ui/propertiespalette_xyz.cpp =================================================================== --- scribus/ui/propertiespalette_xyz.cpp (revisione 19562) +++ scribus/ui/propertiespalette_xyz.cpp (copia locale) @@ -417,6 +417,7 @@ if (!m_haveDoc || !m_haveItem || !m_ScMW || m_ScMW->scriptIsRunning()) return; doUnGroup->setEnabled(mode != modeEdit && mode != modeEditClip && m_item->isGroup()); + doLock->setEnabled(mode != modeEditClip); } void PropertiesPalette_XYZ::handleSelectionChanged() |
|
Ok, the previous versions were not correct... Reviewed everything and the result is in FinalPatch. When an object Is Locked it is not possible to enable node editing mode, but the opposite is possible, that is why the issue is present. The uploaded patch fixes this behaviour. |
|
Thanks cbradney! Fixed in 1.5.0.svn (19570). |
Date Modified | Username | Field | Change |
---|---|---|---|
2014-09-07 23:55 | FirasH | New Issue | |
2014-09-07 23:58 | FirasH | File Added: 12674.png | |
2014-09-08 00:14 | Kunda | Note Added: 0033568 | |
2014-09-08 00:14 | Kunda | Status | new => confirmed |
2014-09-08 00:14 | Kunda | Target Version | => 1.6 milestone |
2014-10-08 18:15 | FirasH | Additional Information Updated | |
2014-10-08 18:52 | FirasH | File Added: 12674-Patch1.diff | |
2014-10-08 18:52 | FirasH | File Added: 12674-Patch2.diff | |
2014-10-08 18:56 | FirasH | Summary | Nodes tool might lead to strange results if Locking is applied => [PATCH] Nodes tool might lead to strange results if Locking is applied |
2014-10-08 19:32 | FirasH | File Deleted: 12674-Patch2.diff | |
2014-10-08 19:32 | FirasH | File Added: 12674-Patch2.diff | |
2014-10-08 19:40 | FirasH | File Deleted: 12674-Patch1.diff | |
2014-10-08 19:40 | FirasH | File Deleted: 12674-Patch2.diff | |
2014-10-08 19:43 | FirasH | File Added: 12674-FinalPatch.diff | |
2014-10-08 19:45 | FirasH | Note Added: 0033941 | |
2014-10-08 19:45 | FirasH | Note Edited: 0033941 | |
2014-10-08 20:06 | FirasH | Summary | [PATCH] Nodes tool might lead to strange results if Locking is applied => [TESTED-PATCH] Nodes tool might lead to strange results if Locking is applied |
2014-10-08 21:59 | cbradney | Status | confirmed => resolved |
2014-10-08 21:59 | cbradney | Fixed in Version | => 1.5.0svn |
2014-10-08 21:59 | cbradney | Resolution | open => fixed |
2014-10-08 21:59 | cbradney | Assigned To | => cbradney |
2014-10-09 12:38 | FirasH | Note Added: 0033962 | |
2014-10-09 12:38 | FirasH | Status | resolved => closed |
2015-02-23 19:04 | Kunda | Patch | => No |
2015-02-23 19:04 | Kunda | Target Version | 1.6 milestone => 1.5.0 |