View Issue Details

IDProjectCategoryView StatusLast Update
0012740ScribusGeneralpublic2014-11-19 21:50
ReporterFirasH Assigned ToFirasH  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Platformx86_64OSopenSUSEOS Version13.1
Product Version1.4.5.svn 
Fixed in Version1.4.5.svn 
Summary0012740: [TESTED-PATCH] Mouse pointer keeps the wrong "L" symbol (set tab spaces) in determined condition
DescriptionMouse pointer keeps the wrong "L" symbol (set tab spaces) in determined condition.
Steps To Reproduce0) Create a new document
1) Insert a Text Frame
2) Open the Story Editor
3) Go to: Insert > Insert Glyph... > open "Unicode Search"
4) Close the Character Palette and the Story Editor
5) Double-click on the Text Frame to enable text editing
6) Hover the pointer on the upper ruler

The pointer will use "L" symbol.

7) Exit text editing

"L" is now the used as the default mouse pointer symbol.
Additional Information1.4.5.svn (19540)
1.5.0.svn (19543)
TagsNo tags attached.
PatchYes

Relationships

related to 0012798 closedKunda Mouse pointer keeps the wrong symbol (arrow pointer). Similar to 0012740
child of 0002407 acknowledged Metabug: Misleading and wrong cursors 

Activities

jghali

2014-10-01 20:35

administrator   ~0033865

I don't manage to reproduce that one.

FirasH

2014-10-01 20:46

developer   ~0033867

Might be something Linux specific or a Qt issue as happens with 1.4.5.svn and 1.5.0.svn... I've always had this issue here on openSUSE but only now I found always reproducible steps. We need to wait for some other users to test and confirm.
Anyway jghali thanks for all the work you're doing.

JLuc

2014-10-01 20:53

developer   ~0033868

I reproduce here on Ubuntu 14.04

cbradney

2014-10-01 21:03

administrator   ~0033870

Those steps don't work on OSX either

FirasH

2014-10-29 17:52

developer   ~0034169

The issue is in "hruler.cpp", specifically:

void Hruler::enterEvent(QEvent *e)
{
    if (textEditMode)
        qApp->changeOverrideCursor(QCursor(loadIcon("tab.png"), 3));
}

FirasH

2014-11-01 18:08

developer   ~0034184

I noticed that randomly the mouse pointer is not able to change pointer icon (for example when hovering over handles or editing text)... This can be "restarted" enabling tab icon "L".

FirasH

2014-11-12 14:39

developer   ~0034195

Found what was causing the issue.
Uploaded the patch (+ some fixes to wrong spacing).

FirasH

2014-11-12 14:40

developer  

12740-Patch.diff (1,570 bytes)   
Index: scribus/canvasmode_edit.cpp
===================================================================
--- scribus/canvasmode_edit.cpp	(revisione 19623)
+++ scribus/canvasmode_edit.cpp	(copia locale)
@@ -66,11 +66,11 @@
	Dxp = Dyp = -1;
	oldCp = Cp = -1;
	frameResizeHandle = -1;
-	m_blinker = new QTimer(view);
+	m_blinker = new QTimer(view);
	connect(m_blinker, SIGNAL(timeout()), this, SLOT(blinkTextCursor()));
	connect(view->horizRuler, SIGNAL(MarkerMoved(double, double)), this, SLOT(rulerPreview(double, double)));
	mRulerGuide = -1;
-	m_longCursorTime=false;
+	m_longCursorTime = false;
	m_keyRepeat = false;
 }

Index: scribus/ui/hruler.cpp
===================================================================
--- scribus/ui/hruler.cpp	(revisione 19623)
+++ scribus/ui/hruler.cpp	(copia locale)
@@ -338,6 +338,7 @@
 void Hruler::leaveEvent(QEvent *m)
 {
	emit MarkerMoved(0, -1);
+	qApp->restoreOverrideCursor();
	m_view->m_canvasMode->setModeCursor();
 }

Index: scribus/ui/unicodesearch.cpp
===================================================================
--- scribus/ui/unicodesearch.cpp	(revisione 19623)
+++ scribus/ui/unicodesearch.cpp	(copia locale)
@@ -181,7 +181,7 @@
	tableView->setColumnWidth(0, tableView->fontMetrics().maxWidth()*4);

	connect(searchEdit, SIGNAL(returnPressed()),
-			this, SLOT(searchEdit_returnPressed()));
+			 this, SLOT(searchEdit_returnPressed()));
	connect(tableView, SIGNAL(doubleClicked(const QModelIndex &)),
			 this, SLOT(itemChosen(const QModelIndex &)));
	connect(tableView, SIGNAL(activated(const QModelIndex &)),
12740-Patch.diff (1,570 bytes)   

JLuc

2014-11-12 15:17

developer   ~0034196

I confirm that the uploaded patch fixes the issue.

FirasH

2014-11-12 15:53

developer  

Typo.diff (709 bytes)   
Index: scribus/ui/storyeditor.cpp
===================================================================
--- scribus/ui/storyeditor.cpp	(revisione 19623)
+++ scribus/ui/storyeditor.cpp	(copia locale)
@@ -3300,7 +3300,7 @@
	QString fileName = "";
	PrefsContext* dirs = prefsManager->prefsFile->getContext("dirs");
	QString wdir = dirs->get("story_save", prefsManager->appPrefs.pathPrefs.documents);
-	CustomFDialog dia(this, wdir, tr("Save as"), tr("Text Files (*.txt);;All Files(*)"), fdShowCodecs|fdHidePreviewCheckBox);
+	CustomFDialog dia(this, wdir, tr("Save as"), tr("Text Files (*.txt);;All Files (*)"), fdShowCodecs|fdHidePreviewCheckBox);
	qApp->processEvents();
	if (dia.exec() != QDialog::Accepted)
	{
Typo.diff (709 bytes)   

FirasH

2014-11-12 21:54

developer  

12740-Backport.diff (316 bytes)   
Index: hruler.cpp
===================================================================
--- hruler.cpp	(revisione 19625)
+++ hruler.cpp	(copia locale)
@@ -332,6 +332,7 @@
 void Hruler::leaveEvent(QEvent *e)
 {
 	emit MarkerMoved(0, -1);
+	qApp->restoreOverrideCursor();
 	currView->m_canvasMode->setModeCursor();
 }
 
12740-Backport.diff (316 bytes)   

FirasH

2014-11-12 21:55

developer   ~0034199

Uploaded and tested "12740-Backport.diff" for 1.4.5.svn (19625).

Issue History

Date Modified Username Field Change
2014-10-01 17:58 FirasH New Issue
2014-10-01 17:59 FirasH Steps to Reproduce Updated
2014-10-01 18:01 FirasH Steps to Reproduce Updated
2014-10-01 20:35 jghali Note Added: 0033865
2014-10-01 20:46 FirasH Note Added: 0033867
2014-10-01 20:53 JLuc Note Added: 0033868
2014-10-01 21:03 cbradney Note Added: 0033870
2014-10-04 19:12 JLuc Status new => confirmed
2014-10-29 17:52 FirasH Note Added: 0034169
2014-10-29 18:53 Kunda Relationship added child of 0002407
2014-10-30 13:22 Kunda Relationship added related to 0012798
2014-11-01 18:08 FirasH Note Added: 0034184
2014-11-12 14:39 FirasH Patch => Yes
2014-11-12 14:39 FirasH Note Added: 0034195
2014-11-12 14:39 FirasH Summary Mouse pointer keeps the wrong "L" symbol (set tab spaces) in determined condition => [TESTED-PATCH] Mouse pointer keeps the wrong "L" symbol (set tab spaces) in determined condition
2014-11-12 14:40 FirasH File Added: 12740-Patch.diff
2014-11-12 14:42 FirasH Assigned To => FirasH
2014-11-12 14:42 FirasH Status confirmed => assigned
2014-11-12 15:17 JLuc Note Added: 0034196
2014-11-12 15:53 FirasH File Added: Typo.diff
2014-11-12 20:03 cbradney Status assigned => resolved
2014-11-12 20:03 cbradney Fixed in Version => 1.5.0svn
2014-11-12 20:03 cbradney Resolution open => fixed
2014-11-12 21:54 FirasH File Added: 12740-Backport.diff
2014-11-12 21:55 FirasH Note Added: 0034199
2014-11-19 21:01 cbradney Product Version 1.5.0svn => 1.4.5.svn
2014-11-19 21:50 FirasH Status resolved => closed
2014-11-19 21:50 FirasH Fixed in Version 1.5.0svn => 1.4.5.svn