View Issue Details

IDProjectCategoryView StatusLast Update
0012817ScribusInternalpublic2014-12-06 22:33
ReporterStephen Leibowitz Assigned Tojghali  
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Version1.5.0svn 
Fixed in Version1.5.0svn 
Summary0012817: missing breaks and copy/paste issues in pageitem.cpp and pageitem_table.cpp
DescriptionSCRIBUS\PAGEITEM.CPP

The test on line 649 is the same as on line 667:
if (m_Doc->itemToolPrefs().shapeLineColor != CommonStrings::None)

I suggest changing line 667 to:
if (m_Doc->itemToolPrefs().shapeFillColor != CommonStrings::None)

***
The following code segment starts on line 3208:
case OSGFrame:
        MColor = m_Doc->itemToolPrefs().imageFillColor;
case TextFrame:
case PathText:
        MColor = m_Doc->itemToolPrefs().textFillColor;
        break;

I suggest adding a break; after the first MColor assignment:
case OSGFrame:
        MColor = m_Doc->itemToolPrefs().imageFillColor;
        break;
case TextFrame:
case PathText:
        MColor = m_Doc->itemToolPrefs().textFillColor;
        break;

***
Similarly, for the code segment starting on line 3426:
case OSGFrame:
        MColor = m_Doc->itemToolPrefs().imageFillColor;
case TextFrame:
case PathText:
        MColor = m_Doc->itemToolPrefs().textFillColor;
        break;

I suggest adding a break; after the first MColor assignment:
case OSGFrame:
        MColor = m_Doc->itemToolPrefs().imageFillColor;
        break;
case TextFrame:
case PathText:
        MColor = m_Doc->itemToolPrefs().textFillColor;
        break;

***
Also, for the code segment starting on line 3953:
case OSGFrame:
        tmp = m_Doc->itemToolPrefs().imageFillColor;
case TextFrame:
case PathText:
        tmp = m_Doc->itemToolPrefs().textFillColor;
        break;

I suggest adding a break; after the first tmp assignment:
case OSGFrame:
        tmp = m_Doc->itemToolPrefs().imageFillColor;
        break;
case TextFrame:
case PathText:
        tmp = m_Doc->itemToolPrefs().textFillColor;
        break;

**************************************************

SCRIBUS\PAGEITEM_TABLE.CPP

This is line 1165:
if (newArea.height() < 1 || newArea.height() < 1)

I suggest changing it to:
if (newArea.height() < 1 || newArea.width() < 1)
TagsNo tags attached.
PatchNo

Activities

jghali

2014-11-17 23:27

administrator   ~0034212

Nice catches, thanks for reporting!

FirasH

2014-12-06 22:33

developer   ~0034280

Fixed in Revision 19630.

Issue History

Date Modified Username Field Change
2014-11-17 19:28 Stephen Leibowitz New Issue
2014-11-17 23:26 jghali Summary pageitem.cpp and pageitem_table.cpp => missing breaks and copy/paste issues in pageitem.cpp and pageitem_table.cpp
2014-11-17 23:27 jghali Note Added: 0034212
2014-11-17 23:27 jghali Status new => resolved
2014-11-17 23:27 jghali Fixed in Version => 1.5.0svn
2014-11-17 23:27 jghali Resolution open => fixed
2014-11-17 23:27 jghali Assigned To => jghali
2014-12-06 22:33 FirasH Note Added: 0034280
2014-12-06 22:33 FirasH Status resolved => closed