View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update | 
|---|---|---|---|---|---|
| 0013549 | Scribus | User Interface | public | 2015-11-21 20:33 | 2017-04-13 16:25 | 
| Reporter | FirasH | Assigned To | FirasH | ||
| Priority | normal | Severity | minor | Reproducibility | always | 
| Status | closed | Resolution | fixed | ||
| Product Version | 1.5.1svn | ||||
| Fixed in Version | 1.5.3.svn | ||||
| Summary | 0013549: Show correct icon for Spiral/Arc items in Outline Palette | ||||
| Description | Show correct icon for Spiral/Arc items in Outline Palette. | ||||
| Additional Information | 1.5.1.svn (20564) | ||||
| Tags | dezso | ||||
| Attached Files |  13549-Patch.diff (1,756 bytes)   
 
diff --git a/scribus/ui/outlinepalette.cpp b/scribus/ui/outlinepalette.cpp
--- a/scribus/ui/outlinepalette.cpp
+++ b/scribus/ui/outlinepalette.cpp
@@ -457,6 +457,8 @@
 	textIcon = im->loadPixmap("22/insert-text-frame.png");
 	polylineIcon = im->loadPixmap("22/draw-path.png");
 	polygonIcon = im->loadPixmap("22/draw-polygon.png");
+	arcIcon = im->loadPixmap("22/draw-arc.png");
+	spiralIcon = im->loadPixmap("22/draw-spiral.png");
 	tableIcon = im->loadPixmap("22/insert-table.png");
 	groupIcon = im->loadPixmap("u_group.png");
 	buttonIcon = im->loadPixmap("22/insert-button.png");
@@ -834,12 +836,16 @@
 		item->setIcon( 0, lineIcon );
 		break;
 	case PageItem::Arc:
+		item->setIcon( 0, arcIcon );
+		break;
+	case PageItem::Spiral:
+		item->setIcon( 0, spiralIcon );
+		break;
 	case PageItem::Polygon:
 	case PageItem::RegularPolygon:
 		item->setIcon( 0, polygonIcon );
 		break;
 	case PageItem::PolyLine:
-	case PageItem::Spiral:
 		item->setIcon( 0, polylineIcon );
 		break;
 	case PageItem::PathText:
diff --git a/scribus/ui/outlinepalette.h b/scribus/ui/outlinepalette.h
--- a/scribus/ui/outlinepalette.h
+++ b/scribus/ui/outlinepalette.h
@@ -109,14 +109,15 @@
 	QLabel* filterLabel;
 	QLineEdit* filterEdit;
 	ScribusMainWindow* m_MainWindow;
+	QPixmap textIcon;
 	QPixmap imageIcon;
 	QPixmap latexIcon;
-	QPixmap textIcon;
+	QPixmap tableIcon;
 	QPixmap lineIcon;
 	QPixmap polygonIcon;
+	QPixmap arcIcon;
+	QPixmap spiralIcon;
 	QPixmap polylineIcon;
-	QPixmap groupIcon;
-	QPixmap tableIcon;
 	QPixmap buttonIcon;
 	QPixmap radiobuttonIcon;
 	QPixmap textFieldIcon;
@@ -126,6 +127,7 @@
 	QPixmap annotTextIcon;
 	QPixmap annotLinkIcon;
 	QPixmap annot3DIcon;
+	QPixmap groupIcon;
 	bool selectionTriggered;
 	ScribusDoc *currDoc;
 };
 | ||||
| Patch | Yes | ||||
| related to | 0013700 | closed | PeterBenedek | New icon set doesn't have some icons for the Character Palette dialog | 
| child of | 0013906 | acknowledged | Metabug: UI enhancement proposals (1.5.x.svn) | 
| 
		 | 
	At that point, the patch does not work so well, not because it is faulty, but because the 1.5.1 icon theme is incomplete : the 22/draw-arc.png and 22/draw-spiral.png files are available, but the images they contain are fully transparent. | 
| 
		 | 
	Ok, we will wait till 1.5.1 theme is mostly completed. | 
| 
		 | 
	we need to ping dezso | 
| 
		 | 
	The adequate icons being now available in 1.5.1 icon set, I committed the patch. Thanks! | 
| 
		 | 
	
	Thanks jghali! Committed in 1.5.3.svn (21889).  | 
| Date Modified | Username | Field | Change | 
|---|---|---|---|
| 2015-11-21 20:33 | FirasH | New Issue | |
| 2015-11-21 20:33 | FirasH | File Added: 13549-Screen.png | |
| 2015-11-21 20:34 | FirasH | File Added: 13549-Patch.diff | |
| 2015-11-22 00:05 | jghali | Note Added: 0037581 | |
| 2015-11-25 12:16 | FirasH | Note Added: 0037672 | |
| 2016-01-31 22:41 | FirasH | Relationship added | related to 0013700 | 
| 2016-02-23 14:06 | Kunda | Tag Attached: dezso | |
| 2016-04-03 10:45 | FirasH | Relationship added | child of 0013906 | 
| 2016-04-03 21:27 | Kunda | Note Added: 0039733 | |
| 2017-04-13 11:53 | jghali | Assigned To | => FirasH | 
| 2017-04-13 11:53 | jghali | Status | new => resolved | 
| 2017-04-13 11:53 | jghali | Resolution | open => fixed | 
| 2017-04-13 11:53 | jghali | Fixed in Version | => 1.5.3.svn | 
| 2017-04-13 11:53 | jghali | Note Added: 0043753 | |
| 2017-04-13 16:25 | FirasH | Status | resolved => closed | 
| 2017-04-13 16:25 | FirasH | Note Added: 0043761 |