View Issue Details

IDProjectCategoryView StatusLast Update
0017123ScribusUser Interfacepublic2024-01-13 16:37
Reporterpmjdebruijn Assigned To 
PrioritynormalSeverityminorReproducibilityalways
Status newResolutionopen 
Product Version1.6.2.svn 
Summary0017123: CommonStrings in PDFVersionModel
DescriptionThis presents a solution that is probably preferrable to 0017105

It means the PreflightVerifier configuration page gets proper "full" PDF version strings, however it does mean, that for pre-existing setups, the user will essentially get duplicated profiles.
TagsNo tags attached.
PatchYes

Activities

pmjdebruijn

2024-01-13 16:37

reporter  

pdfversionmodel-commonstrings.patch (2,343 bytes)   
diff -Nurpd a/scribus/commonstrings.cpp b/scribus/commonstrings.cpp
--- a/scribus/commonstrings.cpp	2024-01-07 18:07:07.000000000 +0100
+++ b/scribus/commonstrings.cpp	2024-01-13 17:26:48.474528336 +0100
@@ -454,12 +454,12 @@ void CommonStrings::languageChange()
 	CommonStrings::trPostScript = tr("PostScript");
 	CommonStrings::PDF          = "PDF";
 	CommonStrings::trPDF        = tr("PDF");
-	CommonStrings::PDF_1_3      = "PDF 1.3";
-	CommonStrings::PDF_1_4      = "PDF 1.4";
-	CommonStrings::PDF_1_5      = "PDF 1.5";
-	CommonStrings::PDF_1_6      = "PDF 1.6";
-	CommonStrings::PDF_X1a      = "PDF/X-1a";
-	CommonStrings::PDF_X3       = "PDF/X-3";
+	CommonStrings::PDF_1_3      = "PDF 1.3 (Acrobat 4)";
+	CommonStrings::PDF_1_4      = "PDF 1.4 (Acrobat 5)";
+	CommonStrings::PDF_1_5      = "PDF 1.5 (Acrobat 6)";
+	CommonStrings::PDF_1_6      = "PDF 1.6 (Acrobat 7)";
+	CommonStrings::PDF_X1a      = "PDF/X-1a:2001";
+	CommonStrings::PDF_X3       = "PDF/X-3:2002";
 	CommonStrings::PDF_X4       = "PDF/X-4";
 
 	CommonStrings::PostScript1   = "PostScript Level 1";
diff -Nurpd a/scribus/ui/pdfversionmodel.cpp b/scribus/ui/pdfversionmodel.cpp
--- a/scribus/ui/pdfversionmodel.cpp	2024-01-07 18:06:55.000000000 +0100
+++ b/scribus/ui/pdfversionmodel.cpp	2024-01-13 17:27:26.258721186 +0100
@@ -7,6 +7,7 @@ for which a new license (GPL+exception)
 
 #include <QDebug>
 #include "pdfversionmodel.h"
+#include "commonstrings.h"
 
 PdfVersionModel::PdfVersionModel(QObject *parent)
 	          : QAbstractItemModel(parent)
@@ -32,19 +33,19 @@ QVariant PdfVersionModel::data(const QMo
 	{
 		int row = index.row();
 		if (row == ItemPDF_13)
-			return tr("PDF 1.3 (Acrobat 4)");
+			return CommonStrings::PDF_1_3;
 		if (row == ItemPDF_14)
-			return tr("PDF 1.4 (Acrobat 5)");
+			return CommonStrings::PDF_1_4;
 		if (row == ItemPDF_15)
-			return tr("PDF 1.5 (Acrobat 6)");
+			return CommonStrings::PDF_1_5;
 		if (row == ItemPDF_16)
-			return tr("PDF 1.6 (Acrobat 7)");
+			return CommonStrings::PDF_1_6;
 		if (row == ItemPDFX_1a)
-			return tr("PDF/X-1a:2001");
+			return CommonStrings::PDF_X1a;
 		if (row == ItemPDFX_3)
-			return tr("PDF/X-3:2002");
+			return CommonStrings::PDF_X3;
 		if (row == ItemPDFX_4)
-			return tr("PDF/X-4");
+			return CommonStrings::PDF_X4;
 		return QVariant();
 	}
 

Issue History

Date Modified Username Field Change
2024-01-13 16:37 pmjdebruijn New Issue
2024-01-13 16:37 pmjdebruijn File Added: scribus_preflight_pdfversionmodel_commonstrings_dups.png
2024-01-13 16:37 pmjdebruijn File Added: pdfversionmodel-commonstrings.patch