View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0016302 | Scribus | User Interface | public | 2020-11-02 09:37 | 2020-11-07 14:52 |
Reporter | ale | Assigned To | ale | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Product Version | 1.5.6.svn | ||||
Fixed in Version | 1.5.6.svn | ||||
Summary | 0016302: addMenuStringToMenuBar() does not use the menu label in the menu | ||||
Description | currently addMenuStringToMenuBar() is using the key instead of the value... you notice it, because the scripter menu does not have the accelerator on the s | ||||
Tags | No tags attached. | ||||
Patch | Yes | ||||
|
menu-plugin-accelerator.diff (462 bytes)
diff --git a/scribus/menumanager.cpp b/scribus/menumanager.cpp index 9aba0a47c..f2f831007 100644 --- a/scribus/menumanager.cpp +++ b/scribus/menumanager.cpp @@ -119,7 +119,7 @@ bool MenuManager::addMenuStringToMenuBarBefore(const QString &menuName, const QS } if (beforeAct) { - auto *m=new QMenu(menuName); + auto *m=new QMenu(menuStringTexts[menuName]); scribusMenuBar->insertMenu(beforeAct, m); menuBarMenus.insert(menuName, m); retVal=true; |
|
btw, there is not really a need to check if menuName is in menuStringTexts. each time a menu is created both menuName and menuString is inserted, a menuStringTexts is also inserted. and we are checking for menuString if there is a risk of having them out of sync, i guess that the solution would be to have one single map with both the list of strings and the stringText in there. since they never should be out of sync! |
|
Patch applied! |
Date Modified | Username | Field | Change |
---|---|---|---|
2020-11-02 09:37 | ale | New Issue | |
2020-11-02 09:37 | ale | File Added: menu-plugin-accelerator.diff | |
2020-11-02 09:43 | ale | Note Added: 0048287 | |
2020-11-03 10:10 | jghali | Summary | [PATCH] addMenuStringToMenuBar() does not use the menu label in the menu => addMenuStringToMenuBar() does not use the menu label in the menu |
2020-11-03 10:10 | jghali | Assigned To | => ale |
2020-11-03 10:10 | jghali | Status | new => resolved |
2020-11-03 10:10 | jghali | Resolution | open => fixed |
2020-11-03 10:10 | jghali | Fixed in Version | => 1.5.6.svn |
2020-11-03 10:10 | jghali | Note Added: 0048307 | |
2020-11-07 14:52 | cbradney | Status | resolved => closed |