View Issue Details

IDProjectCategoryView StatusLast Update
0016333ScribusScripterpublic2023-12-24 10:00
Reporterale Assigned Tocbradney  
PrioritynormalSeverityfeatureReproducibilityN/A
Status closedResolutionfixed 
Product Version1.5.7.svn 
Fixed in Version1.6.0.svn 
Summary0016333: scribus_version and scribus_version_info should be uppercase
Descriptionthey are constants, they should be uppercase.

for some time, we can keep both the lower and upper case versions and remove the lowercase one from the documentation.

this matters for my script that detects the function and constants defined in the API.
TagsNo tags attached.
PatchNo

Activities

cbradney

2023-12-20 21:37

administrator   ~0050659

Fixed in 1.7.0
I am considering having both lower and upper case for 1.6.0. Thoughts, Ale?

ale

2023-12-21 06:53

manager   ~0050670

seems ok to me:

- we should find a way to add to the scripter docstrings the version when the command appeared (and probably remove it again when it's not relevant any more)
- it's probably a bad habit to check for the version to see if the script can run: one should check if the feature exists, instead... so these constants should probably never be used anyway.
- i plan to create the doc with 1.7, so the lowercase version will not be documented anymore (which is fine!)

cbradney

2023-12-21 10:18

administrator   ~0050672

Committed the upper case version as well to 1.5.9, please test to check there's no conflicts.

ale

2023-12-21 16:38

manager   ~0050679

yes, in the 1.5.9 "nightly" appimage, all four seem to be working.

perfect.

Issue History

Date Modified Username Field Change
2020-11-12 20:50 ale New Issue
2023-12-20 21:37 cbradney Note Added: 0050659
2023-12-21 06:53 ale Note Added: 0050670
2023-12-21 10:18 cbradney Assigned To => cbradney
2023-12-21 10:18 cbradney Status new => resolved
2023-12-21 10:18 cbradney Resolution open => fixed
2023-12-21 10:18 cbradney Fixed in Version => 1.6.0.svn
2023-12-21 10:18 cbradney Note Added: 0050672
2023-12-21 16:38 ale Note Added: 0050679
2023-12-24 10:00 cbradney Status resolved => closed