View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0013281 | Scribus | Undo/Redo | public | 2015-08-08 23:42 | 2016-12-08 21:30 |
| Reporter | FirasH | Assigned To | |||
| Priority | normal | Severity | crash | Reproducibility | always |
| Status | confirmed | Resolution | open | ||
| Platform | x86_64 | OS | openSUSE | OS Version | 13.2 |
| Product Version | 1.5.1svn | ||||
| Target Version | 1.5.5 | ||||
| Summary | 0013281: Undo/Redo of imported items (Barcode/PDF) casues Scribus crash on document closing | ||||
| Description | Undo/Redo of imported items (Barcode/PDF) casues Scribus crash on document closing. | ||||
| Steps To Reproduce | 0) Create a new document 1) Insert a Barcode (or import a vector file like PDF) 2) Undo 3) Redo 4) Undo 5) Redo 6) Close Scribus > Discard Scribus crashes due to Signal 11 | ||||
| Additional Information | 1.5.1.svn (20300) | ||||
| Tags | HOST-Oman | ||||
| Patch | No | ||||
|
|
hi , I was able to reproduce the crash and tried to fix it. so here is what I think went wrong. in step 3 it produce a duplicate of the Barcode object and then in the last step the program tries to access an item that does not exist. so I replaced takefirst() with removeFirst() which removes an item without returning an item . |
|
|
issue0013281.patch (377 bytes)
Index: scribusdoc.cpp
===================================================================
--- scribusdoc.cpp (revision 20473)
+++ scribusdoc.cpp (working copy)
@@ -715,7 +715,7 @@
numerations.clear();
while (!DocItems.isEmpty())
{
- delete DocItems.takeFirst();
+ DocItems.removeFirst();
}
QList<PageItem*> tmList = FrameItems.values();
while (!tmList.isEmpty())
|
|
|
Thanks for the patch :) That would be fantastic if the patch was that simple! Lets see what the devs say. Cheers |
|
|
The patch is unfortunately incorrect as it cause memory leaks and in fact does not fix the source of the problem. |
|
|
Nevertheless, nice try as.bahanta |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2015-08-08 23:42 | FirasH | New Issue | |
| 2015-08-08 23:42 | FirasH | Relationship added | child of 0012500 |
| 2015-08-08 23:43 | FirasH | Relationship added | related to 0012374 |
| 2015-08-08 23:43 | FirasH | Relationship added | related to 0012194 |
| 2015-10-04 23:26 | Kunda | Status | new => confirmed |
| 2015-10-04 23:26 | Kunda | Target Version | => 1.5.1 |
| 2015-10-20 08:35 | as.bahanta | Note Added: 0036723 | |
| 2015-10-20 08:36 | as.bahanta | File Added: issue0013281.patch | |
| 2015-10-20 12:46 | Kunda | Note Added: 0036729 | |
| 2015-10-20 12:52 | jghali | Note Added: 0036730 | |
| 2015-10-26 07:44 | as.bahanta | Tag Attached: HOST-Oman | |
| 2015-10-27 23:17 | Kunda | Note Added: 0037005 | |
| 2016-01-23 17:16 | cbradney | Target Version | 1.5.1 => 1.5.3 |
| 2016-12-08 21:30 | Kunda | Target Version | 1.5.3 => 1.5.5 |
