View Issue Details

IDProjectCategoryView StatusLast Update
0014861ScribusInternalpublic2020-12-15 17:08
Reporterkervala Assigned To 
PrioritylowSeverityfeatureReproducibilityalways
Status newResolutionopen 
PlatformWindowsOS10 (64 bits)OS Version10.0.14393
Product Version1.5.3 
Target VersionFixed in Version 
Summary0014861: Keep same ItemID when saving
DescriptionHi there,

I like to compare several versions of SLA files to see changes and fix them (for example to keep synchronization of 2 variants of a SLA), unfortunately each ItemID is different after each save :( So it's very difficult to quickly check what changed in that documents...

Please could it be possible to keep their value when saving again the same document ?
Steps To ReproduceJust open a Scribus document, change it slightly and resave it, all ItemID will change.
TagsNo tags attached.
PatchNo

Activities

kervala

2017-06-12 08:33

reporter  

ale

2017-06-12 12:15

manager   ~0044034

please, if you make changes to the way item IDs work, make them not editable!
the label a user can attach to an item should be just that, a label, not the id used by scribus internally.

this is also valid for all resources like colors and styles! (that is: never use user input for internally referencing resources... not translate the references).

kervala

2017-06-12 12:29

reporter   ~0044036

Yes, I agree with you :) I know they're internally used and shouldn't be changed by user, but it's really annoying Scribus decides to change them all after every save :(

If nobody can have a look to this "issue", I could eventually fix it myself (and propose a patch), but since I never modified Scribus code, I prefer to let experts do that :)

About your comment "this is also valid for all resources like colors and styles", there are also problems with styles and colors that are internally referenced in SLA file using user input, which is I think a bad idea :s

cwalther

2017-10-28 08:45

reporter   ~0044605

+1
I keep Scribus documents under version control (using Git). Version control becomes much more useful when files are diffable and mergeable. Thanks to the human-readable XML format, Scribus documents would be very easy to diff and merge, if it weren’t for these changing ItemIDs.

kervala

2017-10-28 08:58

reporter   ~0044606

Indeed :) I really don't understand why ItemIDs are not kept :(

deep42thought

2020-07-11 19:48

reporter   ~0047821

I looked into this and the problem is, that the ItemID is not some value stored alongside other values inside the class, but it's rather derived from the qHash of the pointer to the instance. This way, the ItemID will change, when the location in memory changes - which is obviously the case when loading an old .sla file. IMO, the ItemID should really be a value stored inside each instance which gets randomly initialized on creation.

cwalther

2020-07-12 18:54

reporter   ~0047825

If that is so, then why does the ItemID need to be written to the XML file at all? (I haven’t looked at the code.)

kervala

2020-07-12 19:02

reporter   ~0047826

I think some other tags/options could be referencing them by ItemID but I'm not sure :(

deep42thought

2020-07-12 19:41

reporter   ~0047827

Yes, there are definitely references to ItemIDs in the sla. However, I did not see a relevant reading from the sla of those on first glance - but I need to check more thoroughly again.

JLuc

2020-07-12 21:17

developer   ~0047828

Changing ids every time document is Saved prevents any usefull diff or version control. Keeping them would enable that.

emmkei

2020-12-15 09:45

reporter   ~0048558

+1 for that topic :-).
As a work around, I wrote a perl script that temporary sets all ItemID = "0" before I commit my changes.

JLuc

2020-12-15 12:22

developer   ~0048563

Setting all ItemID to 0 prevents reopening the saved files @emmkei isnt ? how do you envision the use of such id-stripped files ?

emmkei

2020-12-15 13:00

reporter   ~0048564

@JLuc: From my experience, Scibus is opening these files as well as with changing the IDs to any other value (I hope I did not miss anything...). Therefore I would also raise the question from cwalther: Why do we need these values in the sla-file?

kervala

2020-12-15 13:09

reporter   ~0048565

I really thought ItemID were referenced by other items, but in my own SLA files, it's not the case, each ItemID is used only once ;p

emmkei

2020-12-15 17:08

reporter   ~0048569

I also don't see any refs

Issue History

Date Modified Username Field Change
2017-06-12 08:33 kervala New Issue
2017-06-12 08:33 kervala File Added: Capture d’écran (201).png
2017-06-12 12:15 ale Note Added: 0044034
2017-06-12 12:29 kervala Note Added: 0044036
2017-10-28 08:45 cwalther Note Added: 0044605
2017-10-28 08:58 kervala Note Added: 0044606
2020-07-11 19:48 deep42thought Note Added: 0047821
2020-07-12 18:54 cwalther Note Added: 0047825
2020-07-12 19:02 kervala Note Added: 0047826
2020-07-12 19:41 deep42thought Note Added: 0047827
2020-07-12 21:17 JLuc Note Added: 0047828
2020-12-15 09:45 emmkei Note Added: 0048558
2020-12-15 12:22 JLuc Note Added: 0048563
2020-12-15 13:00 emmkei Note Added: 0048564
2020-12-15 13:09 kervala Note Added: 0048565
2020-12-15 17:08 emmkei Note Added: 0048569