View Issue Details

IDProjectCategoryView StatusLast Update
0015447ScribusInternalpublic2018-09-30 23:18
Reporterale Assigned To 
PrioritynormalSeverityminorReproducibilityN/A
Status newResolutionopen 
Product Version 
Target VersionFixed in Version 
Summary0015447: [patch] remove a specific disabled broken code or document what it should do
Descriptionremove a specific disabled broken code or document what it should do...

looks old and the values it sets do not seem to be use after the commented out snippet.
TagsNo tags attached.
PatchYes

Activities

ale

2018-09-30 07:49

manager  

broken-code.patch (1,066 bytes)
diff --git a/scribus/pageitem.cpp b/scribus/pageitem.cpp
index 22c5fcb3d..aa5f45132 100644
--- a/scribus/pageitem.cpp
+++ b/scribus/pageitem.cpp
@@ -9788,30 +9788,6 @@ void PageItem::AdjustPictScale()
 		m_imageXScale = xs;
 		m_imageYScale = ys;
 	}
-	// Disable broken code. Code must be independent from doc in that function
-	/*switch (m_Doc->RotMode)
-	{
-		case 0:
-			LocalX = 0;
-			LocalY = 0;
-			break;
-		case 1:
-			LocalX = (Width - static_cast<double>(OrigW) * LocalScX) / LocalScX;
-			LocalY = 0;
-			break;
-		case 2:
-			LocalX = ((Width - static_cast<double>(OrigW) * LocalScX) / LocalScX) / 2.0;
-			LocalY = ((Height - static_cast<double>(OrigH) * LocalScY) / LocalScY) / 2.0;
-			break;
-		case 3:
-			LocalX = 0;
-			LocalY = (Height - static_cast<double>(OrigH) * LocalScY) / LocalScY;
-			break;
-		case 4:
-			LocalX = (Width - static_cast<double>(OrigW) * LocalScX) / LocalScX;
-			LocalY = (Height - static_cast<double>(OrigH) * LocalScY) / LocalScY;
-			break;
-	}*/
 	if (m_Doc && m_Doc->isLoading())
 	{
 		m_imageXOffset = imgXOffs;
broken-code.patch (1,066 bytes)

Issue History

Date Modified Username Field Change
2018-09-30 07:49 ale New Issue
2018-09-30 07:49 ale File Added: broken-code.patch
2018-09-30 07:50 ale Summary remove a specific disabled broken code or document what it should do => [patch] remove a specific disabled broken code or document what it should do
2018-09-30 07:50 ale Patch No => Yes
2018-09-30 23:18 jghali Category - => Internal