View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0015447 | Scribus | Internal | public | 2018-09-30 07:49 | 2023-12-24 10:00 |
| Reporter | ale | Assigned To | cbradney | ||
| Priority | normal | Severity | minor | Reproducibility | N/A |
| Status | closed | Resolution | fixed | ||
| Fixed in Version | 1.6.0.svn | ||||
| Summary | 0015447: [patch] remove a specific disabled broken code or document what it should do | ||||
| Description | remove a specific disabled broken code or document what it should do... looks old and the values it sets do not seem to be use after the commented out snippet. | ||||
| Tags | No tags attached. | ||||
| Attached Files | broken-code.patch (1,066 bytes)
diff --git a/scribus/pageitem.cpp b/scribus/pageitem.cpp
index 22c5fcb3d..aa5f45132 100644
--- a/scribus/pageitem.cpp
+++ b/scribus/pageitem.cpp
@@ -9788,30 +9788,6 @@ void PageItem::AdjustPictScale()
m_imageXScale = xs;
m_imageYScale = ys;
}
- // Disable broken code. Code must be independent from doc in that function
- /*switch (m_Doc->RotMode)
- {
- case 0:
- LocalX = 0;
- LocalY = 0;
- break;
- case 1:
- LocalX = (Width - static_cast<double>(OrigW) * LocalScX) / LocalScX;
- LocalY = 0;
- break;
- case 2:
- LocalX = ((Width - static_cast<double>(OrigW) * LocalScX) / LocalScX) / 2.0;
- LocalY = ((Height - static_cast<double>(OrigH) * LocalScY) / LocalScY) / 2.0;
- break;
- case 3:
- LocalX = 0;
- LocalY = (Height - static_cast<double>(OrigH) * LocalScY) / LocalScY;
- break;
- case 4:
- LocalX = (Width - static_cast<double>(OrigW) * LocalScX) / LocalScX;
- LocalY = (Height - static_cast<double>(OrigH) * LocalScY) / LocalScY;
- break;
- }*/
if (m_Doc && m_Doc->isLoading())
{
m_imageXOffset = imgXOffs;
| ||||
| Patch | Yes | ||||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2018-09-30 07:49 | ale | New Issue | |
| 2018-09-30 07:49 | ale | File Added: broken-code.patch | |
| 2018-09-30 07:50 | ale | Summary | remove a specific disabled broken code or document what it should do => [patch] remove a specific disabled broken code or document what it should do |
| 2018-09-30 07:50 | ale | Patch | No => Yes |
| 2018-09-30 23:18 | jghali | Category | - => Internal |
| 2023-12-20 22:16 | cbradney | Assigned To | => cbradney |
| 2023-12-20 22:16 | cbradney | Status | new => resolved |
| 2023-12-20 22:16 | cbradney | Resolution | open => fixed |
| 2023-12-20 22:16 | cbradney | Fixed in Version | => 1.6.0.svn |
| 2023-12-24 10:00 | cbradney | Status | resolved => closed |