View Issue Details

IDProjectCategoryView StatusLast Update
0015803ScribusInternalpublic2019-09-11 13:22
Reporterale Assigned Tojghali  
PrioritynormalSeverityminorReproducibilityhave not tried
Status resolvedResolutionfixed 
Product Version1.5.6.svn 
Target VersionFixed in Version1.5.6.svn 
Summary0015803: a few warnings about comparison of integers of different signednes
Description../scribus/text/storytext.cpp: In member function ‘void StoryText::removeChars(int, uint)’:
../scribus/text/storytext.cpp:558:33: warning: comparison of integer expressions of different signedness: ‘uint’ {aka ‘unsigned int’} and ‘int’ [-Wsign-compare]
  558 | if (pos == 0 && len > 0 && len == length())
      | ~~~~^~~~~~~~~~~


../scribus/pageitem_textframe.cpp: In member function ‘void PageItem_TextFrame::slotInvalidateLayout(int, int)’:
../scribus/pageitem_textframe.cpp:3031:31: warning: comparison of integer expressions of different signedness: ‘uint’ {aka ‘unsigned int’} and ‘int’ [-Wsign-compare]
 3031 | if (firstInvalid->firstChar <= firstItem && firstItem <= firstInvalid->m_maxChars)
      | ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~
../scribus/pageitem_textframe.cpp:3031:57: warning: comparison of integer expressions of different signedness: ‘int’ and ‘uint’ {aka ‘unsigned int’} [-Wsign-compare]
 3031 | if (firstInvalid->firstChar <= firstItem && firstItem <= firstInvalid->m_maxChars)
      | ~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~


../scribus/pslib.cpp: In member function ‘virtual int PSLib::CreatePS(ScribusDoc*, PrintOptions&)’:
../scribus/pslib.cpp:1630:21: warning: comparison of integer expressions of different signedness: ‘int’ and ‘std::vector<int>::size_type’ {aka ‘long unsigned int’} [-Wsign-compare]
 1630 | for (int i = 0; i < pageNs.size(); ++i)

../scribus/scribusdoc.cpp: In member function ‘bool ScribusDoc::startAlign(uint)’:
../scribus/scribusdoc.cpp:11932:24: warning: comparison of integer expressions of different signedness: ‘int’ and ‘uint’ {aka ‘unsigned int’} [-Wsign-compare]
11932 | if (alignObjectsCount < minObjects)
      | ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~
TagsNo tags attached.
PatchNo

Activities

There are no notes attached to this issue.

Issue History

Date Modified Username Field Change
2019-09-04 08:30 ale New Issue
2019-09-04 12:39 jghali Category Build System => Internal
2019-09-11 13:21 jghali Summary a few warnings about wrong int comparison type mismatch => a few warnings about comparison of integers of different signednes
2019-09-11 13:22 jghali Assigned To => jghali
2019-09-11 13:22 jghali Status new => resolved
2019-09-11 13:22 jghali Resolution open => fixed
2019-09-11 13:22 jghali Fixed in Version => 1.5.6.svn