View Issue Details

IDProjectCategoryView StatusLast Update
0015929ScribusBuild Systempublic2020-08-11 20:56
Reporterale Assigned Tojghali  
PrioritynormalSeverityminorReproducibilityN/A
Status closedResolutionfixed 
Product Version1.5.6.svn 
Fixed in Version1.5.6.svn 
Summary0015929: a few warnings about unused variables...
Description../scribus/scribusdoc.cpp:14544:10: warning: unused variable ‘oldX’ [-Wunused-variable]
14544 | double oldX = currItem->xPos();
      | ^~~~
../scribus/scribusdoc.cpp:14545:10: warning: unused variable ‘oldY’ [-Wunused-variable]
14545 | double oldY = currItem->yPos();
      | ^~~~
../scribus/scribusdoc.cpp:14546:10: warning: unused variable ‘oldW’ [-Wunused-variable]
14546 | double oldW = currItem->width();
      | ^~~~
../scribus/scribusdoc.cpp:14547:10: warning: unused variable ‘oldH’ [-Wunused-variable]
14547 | double oldH = currItem->height();
      | ^~~~
../scribus/scribusdoc.cpp:14548:10: warning: unused variable ‘oldgW’ [-Wunused-variable]
14548 | double oldgW = currItem->groupWidth;
      | ^~~~~
../scribus/scribusdoc.cpp:14549:10: warning: unused variable ‘oldgH’ [-Wunused-variable]
14549 | double oldgH = currItem->groupHeight;

this is due to the commented out lines on 14575.

i would be glad if code could be simply deleted before the commit and not left in commented out...
and if you must leave inactive code around, there should always be a remark with the conditions for removal (after some time, after some other changes).
TagsNo tags attached.
PatchNo

Activities

There are no notes attached to this issue.

Issue History

Date Modified Username Field Change
2019-11-08 05:46 ale New Issue
2020-04-20 11:12 jghali Assigned To => jghali
2020-04-20 11:12 jghali Status new => resolved
2020-04-20 11:12 jghali Resolution open => fixed
2020-04-20 11:12 jghali Fixed in Version => 1.5.6.svn
2020-08-11 20:56 cbradney Status resolved => closed