View Issue Details

IDProjectCategoryView StatusLast Update
0016031ScribusUser Interfacepublic2020-04-05 19:37
Reporterebray187 Assigned Tojghali  
PrioritynormalSeveritytweakReproducibilityalways
Status closedResolutionfixed 
Platformx86-64OSLinuxOS VersionGentoo
Product Version1.5.5 
Target VersionFixed in Version1.5.6.svn 
Summary0016031: Wrong color scheme on the side panel of the Story editor
DescriptionWrong color scheme on the side panel of the Story editor make it unreadable (white fonts on white background).
Same problem on the text section but there the background color can be easily changed in the background setup menu.
See the attached screenshot.


Steps To ReproduceIn KDE global settings, set "Breeze-dark" as global theme.
Open Scribus. Create a text frame and open the story editor.
Additional InformationDE: KDE 5.64.0 / Plasma 5.17.4
WM: KWin
Theme: Breeze-dark
Tagsstory editor
PatchNo

Activities

ebray187

2020-01-09 01:04

reporter  

emerge-info.txt (5,910 bytes)
Portage 2.3.79 (python 3.6.9-final-0, default/linux/amd64/17.1/desktop/plasma/systemd, gcc-8.3.0, glibc-2.29-r2, 4.19.57-gentoo x86_64)
=================================================================
System uname: Linux-4.19.57-gentoo-x86_64-Intel-R-_Core-TM-_i5_CPU_750_@_2.67GHz-with-gentoo-2.6
KiB Mem:     4035800 total,     48164 free
KiB Swap:    1049596 total,   1049596 free
Timestamp of repository gentoo: Tue, 07 Jan 2020 03:00:01 +0000
Head commit of repository gentoo: 4edd04b727e428dbe617c8a56d304ca23e00cf79
sh bash 4.4_p23-r1
ld GNU ld (Gentoo 2.32 p2) 2.32.0
app-shells/bash:          4.4_p23-r1::gentoo
dev-java/java-config:     2.2.0-r4::gentoo
dev-lang/perl:            5.28.2-r1::gentoo
dev-lang/python:          2.7.16::gentoo, 3.6.9::gentoo
dev-util/cmake:           3.14.6::gentoo
dev-util/pkgconfig:       0.29.2::gentoo
sys-apps/baselayout:      2.6-r1::gentoo
sys-apps/sandbox:         2.13::gentoo
sys-devel/autoconf:       2.13-r1::gentoo, 2.69-r4::gentoo
sys-devel/automake:       1.16.1-r1::gentoo
sys-devel/binutils:       2.32-r1::gentoo
sys-devel/gcc:            8.3.0-r1::gentoo, 9.2.0-r2::gentoo
sys-devel/gcc-config:     2.0::gentoo
sys-devel/libtool:        2.4.6-r3::gentoo
sys-devel/make:           4.2.1-r4::gentoo
sys-kernel/linux-headers: 4.19::gentoo (virtual/os-headers)
sys-libs/glibc:           2.29-r2::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000
    sync-rsync-verify-max-age: 24
    sync-rsync-extra-opts: 
    sync-rsync-verify-metamanifest: yes
    sync-rsync-verify-jobs: 1

Installed sets: @steam
ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="* -@EULA"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=nehalem -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-march=nehalem -O2 -pipe"
DISTDIR="/usr/portage/distfiles"
ENV_UNSET="DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="es_CL.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LINGUAS="es es_CL"
MAKEOPTS="-j5"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="X a52 aac acl acpi activities alsa amd64 berkdb branding bzip2 cairo cli crypt cups cxx dbus declarative dri dts emboss encode exif fam ffmpeg flac fortran gdbm gif gpm iconv icu ipv6 jack jpeg kde kipi kwallet lcms ldap libnotify libtirpc mad mmx mmxext mng mp3 mp4 mpeg mtp multilib ncurses nls nptl ogg opengl openmp pam pango pcre pdf phonon php plasma png policykit popcnt ppds pulseaudio qml qt5 readline sdl seccomp semantic-desktop spell split-usr sse sse2 sse3 sse4_1 sse4_2 ssl ssse3 startup-notification svg systemd tcpd tiff truetype udev udisks unicode upower usb vorbis widgets wxwidgets x264 xattr xcb xcomposite xml xmlrpc xv xvid zlib" ABI_X86="64" ADA_TARGET="gnat_2018" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="mmx mmxext popcnt sse sse2 sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="evdev keyboard mouse" KERNEL="linux" L10N="es es-CL" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" NETBEANS_MODULES="apisupport cnd groovy gsf harness ide identity j2ee java mobility nb php profiler soa visualweb webcommon websvccommon xml" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-2" POSTGRES_TARGETS="postgres10 postgres11" PYTHON_SINGLE_TARGET="python3_6" PYTHON_TARGETS="python2_7 python3_4 python3_6" RUBY_TARGETS="ruby24 ruby25" USERLAND="GNU" VIDEO_CARDS="radeon" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

emerge-info.txt (5,910 bytes)

ebray187

2020-01-09 02:48

reporter   ~0047324

Just a nasty quick fix.

scribus-1.5.5-storyeditor.patch (425 bytes)
diff --git a/scribus/ui/storyeditor.cpp b/scribus/ui/storyeditor.cpp
index 2fc5f35..f430bee 100644
--- a/scribus/ui/storyeditor.cpp
+++ b/scribus/ui/storyeditor.cpp
@@ -116,7 +116,7 @@ public:
 SideBar::SideBar(QWidget *pa) : QLabel(pa)
 {
 	QPalette pal;
-	pal.setColor(QPalette::Window, QColor(255,255,255));
+	pal.setColor(QPalette::Window, QColor(35,48,51));
 	setAutoFillBackground(true);
 	setPalette(pal);
 	offs = 0;

jghali

2020-01-09 11:13

administrator   ~0047325

Would this patch work for you?

16031_storyeditor_sidebar_color.patch (6,057 bytes)
Index: scribus/ui/storyeditor.cpp
===================================================================
--- scribus/ui/storyeditor.cpp	(revision 23427)
+++ scribus/ui/storyeditor.cpp	(working copy)
@@ -121,7 +121,7 @@
 	setPalette(pal);
 	offs = 0;
 	currentPar = 0;
-	editor = nullptr;
+	m_editor = nullptr;
 	noUpdt = true;
 	inRep = false;
 	pmen = new QMenu(this);
@@ -129,24 +129,35 @@
 	setMinimumWidth(fontMetrics().width( tr("No Style") )+30);
 }
 
+void SideBar::setEditor(SEditor* editor)
+{
+	m_editor = editor;
+	if (editor)
+	{
+		QPalette pal;
+		pal.setColor(QPalette::Window, editor->palette().color(QPalette::Base));
+		setPalette(pal);
+	}
+}
+
 void SideBar::mouseReleaseEvent(QMouseEvent *m)
 {
 	QPoint globalPos = m->globalPos();
-	QPoint viewPos   = editor->viewport()->mapFromGlobal(globalPos);
-	int p = editor->cursorForPosition(QPoint(2, viewPos.y())).position();
-	currentPar = editor->StyledText.nrOfParagraph(p);
-	int pos = editor->StyledText.startOfParagraph( editor->StyledText.nrOfParagraph(p) );
+	QPoint viewPos   = m_editor->viewport()->mapFromGlobal(globalPos);
+	int p = m_editor->cursorForPosition(QPoint(2, viewPos.y())).position();
+	currentPar = m_editor->StyledText.nrOfParagraph(p);
+	int pos = m_editor->StyledText.startOfParagraph( m_editor->StyledText.nrOfParagraph(p) );
 
 	pmen->clear();
 
 	QString styleName = "";
 	ParaStyleComboBox* paraStyleCombo = new ParaStyleComboBox(pmen);
-	paraStyleCombo->setDoc(editor->doc);
-	if ((currentPar < static_cast<int>(editor->StyledText.nrOfParagraphs())) && (editor->StyledText.length() != 0))
+	paraStyleCombo->setDoc(m_editor->doc);
+	if ((currentPar < static_cast<int>(m_editor->StyledText.nrOfParagraphs())) && (m_editor->StyledText.length() != 0))
 	{
-		int len = editor->StyledText.endOfParagraph(currentPar) - editor->StyledText.startOfParagraph(currentPar);
+		int len = m_editor->StyledText.endOfParagraph(currentPar) - m_editor->StyledText.startOfParagraph(currentPar);
 		if (len > 0)
-			styleName = editor->StyledText.paragraphStyle(pos).parent(); //FIXME ParaStyleComboBox and use localized style name
+			styleName = m_editor->StyledText.paragraphStyle(pos).parent(); //FIXME ParaStyleComboBox and use localized style name
 	}
 	paraStyleCombo->setFormat(styleName);
 	connect(paraStyleCombo, SIGNAL(newStyle(const QString&)), this, SLOT(setPStyle(const QString&)));
@@ -174,20 +185,20 @@
 	QLabel::paintEvent(e);
 	QPair<int, int> paraInfo;
 	QList< QPair<int,int> > paraList;
-	if (editor != nullptr)
+	if (m_editor != nullptr)
 	{
-		QRect  edRect = editor->viewport()->rect();
+		QRect  edRect = m_editor->viewport()->rect();
 		QPoint pt1 = edRect.topLeft(), pt2 = edRect.bottomRight();
-		QTextCursor cur1 = editor->cursorForPosition(pt1);
-		QTextCursor cur2 = editor->cursorForPosition(pt2);
+		QTextCursor cur1 = m_editor->cursorForPosition(pt1);
+		QTextCursor cur2 = m_editor->cursorForPosition(pt2);
 		int pos1 = cur1.position(), pos2 = cur2.position();
-		pos1 = editor->StyledText.prevParagraph(pos1);
+		pos1 = m_editor->StyledText.prevParagraph(pos1);
 		pos1 = (pos1 == 0) ? 0 : (pos1 + 1);
-		pos2 = editor->StyledText.nextParagraph(pos2);
-		while ((pos1 <= pos2) && (pos1 < editor->StyledText.length()))
+		pos2 = m_editor->StyledText.nextParagraph(pos2);
+		while ((pos1 <= pos2) && (pos1 < m_editor->StyledText.length()))
 		{
 			paraInfo.first = pos1;
-			if (editor->StyledText.text(pos1) == SpecialChars::PARSEP)
+			if (m_editor->StyledText.text(pos1) == SpecialChars::PARSEP)
 			{
 				paraInfo.second = pos1;
 				pos1 += 1;
@@ -194,8 +205,8 @@
 			}
 			else
 			{
-				pos1 = editor->StyledText.nextParagraph(pos1) + 1;
-				paraInfo.second = qMax(0, qMin(pos1 - 1, editor->StyledText.length() - 1));
+				pos1 = m_editor->StyledText.nextParagraph(pos1) + 1;
+				paraInfo.second = qMax(0, qMin(pos1 - 1, m_editor->StyledText.length() - 1));
 			}
 			paraList.append(paraInfo);
 		}
@@ -202,7 +213,7 @@
 	}
 	QPainter p;
 	p.begin(this);
-	if ((editor != nullptr) && (noUpdt))
+	if ((m_editor != nullptr) && (noUpdt))
 	{
 		QString trNoStyle = tr("No Style");
 		for (int pa = 0; pa < paraList.count(); ++pa)
@@ -209,7 +220,7 @@
 		{
 			QPair<int,int> paraInfo = paraList[pa];
 			// Draw paragraph style name first
-			QTextCursor cur(editor->document());
+			QTextCursor cur(m_editor->document());
 			cur.setPosition(paraInfo.first);
 			QTextBlock blockStart = cur.block();
 			QTextLine  lineStart  = blockStart.layout()->lineForTextPosition(paraInfo.first - blockStart.position());
@@ -222,7 +233,7 @@
 				re.translate(5, 2-offs);
 				if ((re.top() < height()) && (re.top() >= 0))
 				{
-					QString parname = editor->StyledText.paragraphStyle(paraInfo.first).parent();
+					QString parname = m_editor->StyledText.paragraphStyle(paraInfo.first).parent();
 					if (parname.isEmpty())
 						parname = trNoStyle;
 					p.drawText(re, Qt::AlignLeft | Qt::AlignTop, parname);
@@ -1992,7 +2003,7 @@
 	//Final setup
 	resize( QSize(660, 500).expandedTo(minimumSizeHint()) );
 
-	EditorBar->editor = Editor;
+	EditorBar->setEditor(Editor);
 	Editor->installEventFilter(this);
 	languageChange();
 	ActionManager::setActionTooltips(&seActions);
Index: scribus/ui/storyeditor.h
===================================================================
--- scribus/ui/storyeditor.h	(revision 23427)
+++ scribus/ui/storyeditor.h	(working copy)
@@ -91,6 +91,7 @@
 public:
 	SEditor (QWidget* parent, ScribusDoc *docc, StoryEditor* parentSE);
 	~SEditor() {}
+
 	void setCurrentDocument(ScribusDoc *docc);
 	void setAlign(int align);
 	void setDirection(int align);
@@ -196,9 +197,11 @@
 public:
 	SideBar(QWidget *pa);
 	~SideBar() {};
+
+	void setEditor(SEditor* editor);
+
 	int offs;
 	int currentPar;
-	SEditor *editor;
 	QMenu *pmen;
 	QWidgetAction* paraStyleAct;
 	bool noUpdt;
@@ -208,6 +211,9 @@
 	void paintEvent(QPaintEvent *e);
 	void mouseReleaseEvent(QMouseEvent *m);
 
+private:
+	SEditor *m_editor;
+
 signals:
 	void ChangeStyle(int, const QString&);
 	//! signal raised when user ask for style manager

ebray187

2020-01-09 16:17

reporter   ~0047326

Work like a charm. Thanks!
Attached adjusted patch for Gentoo

scribus-1.5.5-storyeditor_sidebar_color.patch (6,229 bytes)
diff --git a/scribus/ui/storyeditor.cpp b/scribus/ui/storyeditor.cpp
index 2fc5f35..b51bf48 100644
--- a/scribus/ui/storyeditor.cpp
+++ b/scribus/ui/storyeditor.cpp
@@ -121,7 +121,7 @@ SideBar::SideBar(QWidget *pa) : QLabel(pa)
 	setPalette(pal);
 	offs = 0;
 	currentPar = 0;
-	editor = nullptr;
+	m_editor = nullptr;
 	noUpdt = true;
 	inRep = false;
 	pmen = new QMenu(this);
@@ -129,24 +129,35 @@ SideBar::SideBar(QWidget *pa) : QLabel(pa)
 	setMinimumWidth(fontMetrics().width( tr("No Style") )+30);
 }
 
+void SideBar::setEditor(SEditor* editor)
+{
+	m_editor = editor;
+	if (editor)
+	{
+		QPalette pal;
+		pal.setColor(QPalette::Window, editor->palette().color(QPalette::Base));
+		setPalette(pal);
+	}
+}
+
 void SideBar::mouseReleaseEvent(QMouseEvent *m)
 {
 	QPoint globalPos = m->globalPos();
-	QPoint viewPos   = editor->viewport()->mapFromGlobal(globalPos);
-	int p = editor->cursorForPosition(QPoint(2, viewPos.y())).position();
-	currentPar = editor->StyledText.nrOfParagraph(p);
-	int pos = editor->StyledText.startOfParagraph( editor->StyledText.nrOfParagraph(p) );
+	QPoint viewPos   = m_editor->viewport()->mapFromGlobal(globalPos);
+	int p = m_editor->cursorForPosition(QPoint(2, viewPos.y())).position();
+	currentPar = m_editor->StyledText.nrOfParagraph(p);
+	int pos = m_editor->StyledText.startOfParagraph( m_editor->StyledText.nrOfParagraph(p) );
 
 	pmen->clear();
 
 	QString styleName = "";
 	ParaStyleComboBox* paraStyleCombo = new ParaStyleComboBox(pmen);
-	paraStyleCombo->setDoc(editor->doc);
-	if ((currentPar < static_cast<int>(editor->StyledText.nrOfParagraphs())) && (editor->StyledText.length() != 0))
+	paraStyleCombo->setDoc(m_editor->doc);
+	if ((currentPar < static_cast<int>(m_editor->StyledText.nrOfParagraphs())) && (m_editor->StyledText.length() != 0))
 	{
-		int len = editor->StyledText.endOfParagraph(currentPar) - editor->StyledText.startOfParagraph(currentPar);
+		int len = m_editor->StyledText.endOfParagraph(currentPar) - m_editor->StyledText.startOfParagraph(currentPar);
 		if (len > 0)
-			styleName = editor->StyledText.paragraphStyle(pos).parent(); //FIXME ParaStyleComboBox and use localized style name
+			styleName = m_editor->StyledText.paragraphStyle(pos).parent(); //FIXME ParaStyleComboBox and use localized style name
 	}
 	paraStyleCombo->setFormat(styleName);
 	connect(paraStyleCombo, SIGNAL(newStyle(const QString&)), this, SLOT(setPStyle(const QString&)));
@@ -174,42 +185,42 @@ void SideBar::paintEvent(QPaintEvent *e)
 	QLabel::paintEvent(e);
 	QPair<int, int> paraInfo;
 	QList< QPair<int,int> > paraList;
-	if (editor != nullptr)
+	if (m_editor != nullptr)
 	{
-		QRect  edRect = editor->viewport()->rect();
+		QRect  edRect = m_editor->viewport()->rect();
 		QPoint pt1 = edRect.topLeft(), pt2 = edRect.bottomRight();
-		QTextCursor cur1 = editor->cursorForPosition(pt1);
-		QTextCursor cur2 = editor->cursorForPosition(pt2);
+		QTextCursor cur1 = m_editor->cursorForPosition(pt1);
+		QTextCursor cur2 = m_editor->cursorForPosition(pt2);
 		int pos1 = cur1.position(), pos2 = cur2.position();
-		pos1 = editor->StyledText.prevParagraph(pos1);
+		pos1 = m_editor->StyledText.prevParagraph(pos1);
 		pos1 = (pos1 == 0) ? 0 : (pos1 + 1);
-		pos2 = editor->StyledText.nextParagraph(pos2);
-		while ((pos1 <= pos2) && (pos1 < editor->StyledText.length()))
+		pos2 = m_editor->StyledText.nextParagraph(pos2);
+		while ((pos1 <= pos2) && (pos1 < m_editor->StyledText.length()))
 		{
 			paraInfo.first = pos1;
-			if (editor->StyledText.text(pos1) == SpecialChars::PARSEP)
+			if (m_editor->StyledText.text(pos1) == SpecialChars::PARSEP)
 			{
 				paraInfo.second = pos1;
 				pos1 += 1;
 			}
 			else
 			{
-				pos1 = editor->StyledText.nextParagraph(pos1) + 1;
-				paraInfo.second = qMax(0, qMin(pos1 - 1, editor->StyledText.length() - 1));
+				pos1 = m_editor->StyledText.nextParagraph(pos1) + 1;
+				paraInfo.second = qMax(0, qMin(pos1 - 1, m_editor->StyledText.length() - 1));
 			}
 			paraList.append(paraInfo);
 		}
 	}
 	QPainter p;
 	p.begin(this);
-	if ((editor != nullptr) && (noUpdt))
+	if ((m_editor != nullptr) && (noUpdt))
 	{
 		QString trNoStyle = tr("No Style");
 		for (int pa = 0; pa < paraList.count(); ++pa)
 		{
 			QPair<int,int> paraInfo = paraList[pa];
 			// Draw paragraph style name first
-			QTextCursor cur(editor->document());
+			QTextCursor cur(m_editor->document());
 			cur.setPosition(paraInfo.first);
 			QTextBlock blockStart = cur.block();
 			QTextLine  lineStart  = blockStart.layout()->lineForTextPosition(paraInfo.first - blockStart.position());
@@ -222,7 +233,7 @@ void SideBar::paintEvent(QPaintEvent *e)
 				re.translate(5, 2-offs);
 				if ((re.top() < height()) && (re.top() >= 0))
 				{
-					QString parname = editor->StyledText.paragraphStyle(paraInfo.first).parent();
+					QString parname = m_editor->StyledText.paragraphStyle(paraInfo.first).parent();
 					if (parname.isEmpty())
 						parname = trNoStyle;
 					p.drawText(re, Qt::AlignLeft | Qt::AlignTop, parname);
@@ -1980,7 +1991,7 @@ void StoryEditor::buildGUI()
 	//Final setup
 	resize( QSize(660, 500).expandedTo(minimumSizeHint()) );
 
-	EditorBar->editor = Editor;
+	EditorBar->setEditor(Editor);
 	Editor->installEventFilter(this);
 	languageChange();
 	ActionManager::setActionTooltips(&seActions);
diff --git a/scribus/ui/storyeditor.h b/scribus/ui/storyeditor.h
index be5ec2a..a35fa67 100644
--- a/scribus/ui/storyeditor.h
+++ b/scribus/ui/storyeditor.h
@@ -89,6 +89,7 @@ class SCRIBUS_API SEditor : public QTextEdit
 public:
 	SEditor (QWidget* parent, ScribusDoc *docc, StoryEditor* parentSE);
 	~SEditor() {}
+	
 	void setCurrentDocument(ScribusDoc *docc);
 	void setAlign(int align);
 	void setDirection(int align);
@@ -194,9 +195,11 @@ class SCRIBUS_API SideBar : public QLabel
 public:
 	SideBar(QWidget *pa);
 	~SideBar() {};
+
+	void setEditor(SEditor* editor);
+
 	int offs;
 	int currentPar;
-	SEditor *editor;
 	QMenu *pmen;
 	QWidgetAction* paraStyleAct;
 	bool noUpdt;
@@ -206,6 +209,9 @@ protected:
 	void paintEvent(QPaintEvent *e);
 	void mouseReleaseEvent(QMouseEvent *m);
 
+private:
+	SEditor *m_editor;
+
 signals:
 	void ChangeStyle(int, const QString&);
 	//! signal raised when user ask for style manager

jghali

2020-01-09 17:47

administrator   ~0047327

Committed!

Issue History

Date Modified Username Field Change
2020-01-09 01:04 ebray187 New Issue
2020-01-09 01:04 ebray187 File Added: Screenshot_20200108_213503.png
2020-01-09 01:04 ebray187 File Added: emerge-info.txt
2020-01-09 01:06 ebray187 Tag Attached: story editor
2020-01-09 02:48 ebray187 File Added: scribus-1.5.5-storyeditor.patch
2020-01-09 02:48 ebray187 Note Added: 0047324
2020-01-09 11:13 jghali File Added: 16031_storyeditor_sidebar_color.patch
2020-01-09 11:13 jghali Note Added: 0047325
2020-01-09 16:17 ebray187 File Added: scribus-1.5.5-storyeditor_sidebar_color.patch
2020-01-09 16:17 ebray187 File Added: Screenshot_20200109_131202.png
2020-01-09 16:17 ebray187 Note Added: 0047326
2020-01-09 17:47 jghali Assigned To => jghali
2020-01-09 17:47 jghali Status new => resolved
2020-01-09 17:47 jghali Resolution open => fixed
2020-01-09 17:47 jghali Fixed in Version => 1.5.6.svn
2020-01-09 17:47 jghali Note Added: 0047327
2020-04-05 19:37 cbradney Status resolved => closed