View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001655 | Scribus | Internal | public | 2005-02-09 08:55 | 2005-02-09 09:21 |
| Reporter | Assigned To | Tsoots | |||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Platform | x86 Linux | OS | Fedora Core | OS Version | 3 |
| Product Version | 1.3.0cvs | ||||
| Fixed in Version | 1.3.0cvs | ||||
| Summary | 0001655: PATCH: remove last traces of PType | ||||
| Description | Remove PType from pageitem.h and remove one last usage that slipped through the net. | ||||
| Tags | No tags attached. | ||||
| Patch | |||||
| child of | 0001653 | confirmed | Convert all PageItem direct member access to use getters and setters |
|
2005-02-09 08:55
|
ptype_removal_final.diff (1,331 bytes)
Index: scribus/pageitem.h =================================================================== RCS file: /cvs/Scribus/scribus/pageitem.h,v retrieving revision 1.26.2.39 diff -u -r1.26.2.39 pageitem.h --- scribus/pageitem.h 8 Feb 2005 16:31:16 -0000 1.26.2.39 +++ scribus/pageitem.h 9 Feb 2005 09:54:18 -0000 @@ -155,7 +155,6 @@ double oldHeight; /** Eckrundung von Rechtecken */ double RadRect; - ItemType PType; /** Winkel um den das Item gedreht wird */ double Rot; /** @brief Stores the old rotation value for undo action. Is used to detect rotation actions. */ Index: scribus/plugins/scriptplugin/scriptplugin.cpp =================================================================== RCS file: /cvs/Scribus/scribus/plugins/scriptplugin/scriptplugin.cpp,v retrieving revision 1.33.2.42 diff -u -r1.33.2.42 scriptplugin.cpp --- scribus/plugins/scriptplugin/scriptplugin.cpp 4 Feb 2005 20:03:54 -0000 1.33.2.42 +++ scribus/plugins/scriptplugin/scriptplugin.cpp 9 Feb 2005 09:54:19 -0000 @@ -248,7 +248,7 @@ Carrier->Sepal->SetView(Carrier->view); Carrier->Sepal->Rebuild(); if (Carrier->view->SelItem.count() != 0) - Carrier->HaveNewSel(Carrier->view->SelItem.at(0)->PType); + Carrier->HaveNewSel(Carrier->view->SelItem.at(0)->itemType()); else Carrier->HaveNewSel(-1); Carrier->view->DrawNew(); |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2005-02-09 08:55 |
|
New Issue | |
| 2005-02-09 08:55 |
|
File Added: ptype_removal_final.diff | |
| 2005-02-09 08:57 |
|
Relationship added | child of 0001653 |
| 2005-02-09 09:00 |
|
Category | Default => Internal |
| 2005-02-09 09:16 | Tsoots | Status | new => resolved |
| 2005-02-09 09:16 | Tsoots | Fixed in Version | => 1.3.0cvs |
| 2005-02-09 09:16 | Tsoots | Resolution | open => fixed |
| 2005-02-09 09:16 | Tsoots | Assigned To | => Tsoots |
| 2005-02-09 09:21 |
|
Status | resolved => closed |
