View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0017076 | Scribus | General | public | 2023-12-13 17:03 | 2023-12-13 17:12 |
Reporter | ale | Assigned To | |||
Priority | normal | Severity | minor | Reproducibility | N/A |
Status | new | Resolution | open | ||
Product Version | 1.7.0.svn | ||||
Summary | 0017076: More Info... && itemImageInfo | ||||
Description | while studying if and how to put the information of "extra > manage images" into the image's content palette, i stumbled on ui/imageinfodialog.cpp it's referenced in scribus.cpp as ScribusMainWindow::getImageInfo(), which is in actionmanager.cpp as itemImageInfo. but there seems to be no way to trigger it... i've added it everywhere i saw "embed image" and i could find and trigger it. the screenshot is attached. is the information interesting? is it somewhere else in scribus? should we make the dialog accessible? or integrate the information show in the image content palette? i also attach the diff with the changes as a reference (or for further testing) | ||||
Tags | No tags attached. | ||||
Patch | No | ||||
related to | 0017073 | new | integrate "extra > manage images" into the the image content palette |
|
more-image-info.diff (3,117 bytes)
diff --git a/scribus/actionmanager.cpp b/scribus/actionmanager.cpp index 7bbd81527..a042e2c6f 100644 --- a/scribus/actionmanager.cpp +++ b/scribus/actionmanager.cpp @@ -2168,6 +2168,7 @@ void ActionManager::createDefaultMenus() << "itemAdjustFrameToImage" << "itemAdjustImageToFrame" << "itemToggleInlineImage" + << "itemImageInfo" << "itemExtendedImageProperties" << "itemPreviewFull" << "itemPreviewNormal" diff --git a/scribus/appmodehelper.cpp b/scribus/appmodehelper.cpp index aa3cdee23..241994d75 100644 --- a/scribus/appmodehelper.cpp +++ b/scribus/appmodehelper.cpp @@ -455,6 +455,7 @@ void AppModeHelper::enableActionsForSelection(ScribusMainWindow* scmw, ScribusDo (*a_scrActions)["itemAdjustImageToFrame"]->setEnabled(isImageFrame && currItem->imageIsAvailable); (*a_scrActions)["itemExtendedImageProperties"]->setEnabled(isImageFrame && currItem->imageIsAvailable && currItem->pixm.imgInfo.valid); (*a_scrActions)["itemToggleInlineImage"]->setEnabled(isImageFrame && currItem->imageIsAvailable); + (*a_scrActions)["itemImageInfo"]->setEnabled(isImageFrame && currItem->imageIsAvailable); (*a_scrActions)["itemImageIsVisible"]->setEnabled(isImageFrame); (*a_scrActions)["itemPreviewFull"]->setEnabled(isImageFrame); (*a_scrActions)["itemPreviewNormal"]->setEnabled(isImageFrame); @@ -576,6 +577,7 @@ void AppModeHelper::enableActionsForSelection(ScribusMainWindow* scmw, ScribusDo (*a_scrActions)["toolsCopyProperties"]->setEnabled(!inAnEditMode); (*a_scrActions)["itemImageIsVisible"]->setChecked(currItem->imageVisible()); (*a_scrActions)["itemToggleInlineImage"]->setChecked(currItem->isImageInline()); + (*a_scrActions)["itemImageInfo"]->setChecked(currItem->isImageInline()); (*a_scrActions)["itemPreviewFull"]->setChecked(currItem->pixm.imgInfo.lowResType==(*a_scrActions)["itemPreviewFull"]->actionInt()); (*a_scrActions)["itemPreviewNormal"]->setChecked(currItem->pixm.imgInfo.lowResType==(*a_scrActions)["itemPreviewNormal"]->actionInt()); (*a_scrActions)["itemPreviewLow"]->setChecked(currItem->pixm.imgInfo.lowResType==(*a_scrActions)["itemPreviewLow"]->actionInt()); @@ -1688,6 +1690,7 @@ void AppModeHelper::mainWindowCloseLastDoc() (*a_scrActions)["itemSendToInline"]->setEnabled(false); (*a_scrActions)["itemSendToPattern"]->setEnabled(false); (*a_scrActions)["itemToggleInlineImage"]->setEnabled(false); + (*a_scrActions)["itemImageInfo"]->setEnabled(false); (*a_scrActions)["itemTransform"]->setEnabled(false); (*a_scrActions)["itemUpdateImage"]->setEnabled(false); (*a_scrActions)["pageApplyMasterPage"]->setEnabled(false); diff --git a/scribus/pageitem_imageframe.cpp b/scribus/pageitem_imageframe.cpp index af9679cf0..3aeac0899 100644 --- a/scribus/pageitem_imageframe.cpp +++ b/scribus/pageitem_imageframe.cpp @@ -465,6 +465,7 @@ void PageItem_ImageFrame::applicableActions(QStringList & actionList) actionList << "itemUpdateImage"; actionList << "editCopyContents"; actionList << "itemToggleInlineImage"; + actionList << "itemImageInfo"; if (isRaster) { actionList << "styleImageEffects"; |