View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0017288 | Scribus | Graphics / Image Frames | public | 2024-10-14 13:38 | 2024-10-23 18:42 |
| Reporter | AkiSakurai | Assigned To | jghali | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 1.7.0.svn | ||||
| Fixed in Version | 1.6.3.svn | ||||
| Summary | 0017288: "Update Image" does not work when the image is not available. | ||||
| Description | To reproduce, add an image, move the image to another folder, click "Update Image". Now, the image becomes a cross as expected. Move the image back to the original location, click "Update Image" again, and the image frame is still a cross. | ||||
| Additional Information | I believe this checking is unnecessary . diff --git a/scribus/scribusdoc.cpp b/scribus/scribusdoc.cpp index 906e533a2..2cd68404a 100644 --- a/scribus/scribusdoc.cpp +++ b/scribus/scribusdoc.cpp @@ -10472,19 +10472,17 @@ void ScribusDoc::updatePic() } else if ((currItem->isImageFrame()) || (currItem->isOSGFrame())) { - if (currItem->imageIsAvailable) - { - int fho = currItem->imageFlippedH(); - int fvo = currItem->imageFlippedV(); - double imgX = currItem->imageXOffset(); - double imgY = currItem->imageYOffset(); - loadPict(currItem->Pfile, currItem, true); - currItem->setImageFlippedH(fho); - currItem->setImageFlippedV(fvo); - currItem->setImageXOffset(imgX); - currItem->setImageYOffset(imgY); - toUpdate = true; - } + int fho = currItem->imageFlippedH(); + int fvo = currItem->imageFlippedV(); + double imgX = currItem->imageXOffset(); + double imgY = currItem->imageYOffset(); + loadPict(currItem->Pfile, currItem, true); + currItem->setImageFlippedH(fho); + currItem->setImageFlippedV(fvo); + currItem->setImageXOffset(imgX); + currItem->setImageYOffset(imgY); + toUpdate = true; | ||||
| Tags | No tags attached. | ||||
| Patch | No | ||||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2024-10-14 13:38 | AkiSakurai | New Issue | |
| 2024-10-18 18:47 | jghali | Assigned To | => jghali |
| 2024-10-18 18:47 | jghali | Status | new => resolved |
| 2024-10-18 18:47 | jghali | Resolution | open => fixed |
| 2024-10-18 18:47 | jghali | Fixed in Version | => 1.6.3.svn |
| 2024-10-23 18:42 | cbradney | Status | resolved => closed |