View Issue Details

IDProjectCategoryView StatusLast Update
0017653ScribusScripterpublic2025-10-18 08:44
Reporterale Assigned To 
PrioritynormalSeverityfeatureReproducibilityN/A
Status newResolutionopen 
Summary0017653: Do not let Scripter commands call slotDocCh
DescriptionThe Scripter has the command docChanged() for notifying Scribus that the script has modified the document.

Still, a few Scripter commands call slotDocCh on primaryMainWindow.

I suggest to remove the calls from...

../scribus/plugins/scriptplugin/cmddoc.cpp
307:    ScCore->primaryMainWindow()->slotDocCh();
418:    ScCore->primaryMainWindow()->slotDocCh();

../scribus/plugins/scriptplugin/cmdobj.cpp
578:    ScCore->primaryMainWindow()->slotDocCh(true);

../scribus/plugins/scriptplugin/guiapp.cpp
81:     ScCore->primaryMainWindow()->slotDocCh(static_cast<bool>(aValue));
84:             ScCore->primaryMainWindow()->slotDocCh(true);
86:             ScCore->primaryMainWindow()->slotDocCh(false);*/

../scribus/plugins/scriptplugin/cmdtext.cpp
1558:   ScCore->primaryMainWindow()->slotDocCh();
1610:   ScCore->primaryMainWindow()->slotDocCh();


... and always rely on explicit calls to docChanged()
(the alternative would be to add (optional?) calls to slotDocCh() to every Scripter commands that changes the document: probably the better solution, but not realistic at all).
TagsNo tags attached.
PatchNo

Activities

There are no notes attached to this issue.

Issue History

Date Modified Username Field Change
2025-10-18 08:44 ale New Issue
2025-10-18 08:44 ale Description Updated