View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002947 | Scribus | Scripter | public | 2005-12-31 17:27 | 2006-05-04 21:42 |
| Reporter | TomK32 | Assigned To | fschmid | ||
| Priority | normal | Severity | tweak | Reproducibility | always |
| Status | feedback | Resolution | reopened | ||
| Platform | MacOSX | OS | MacOSX | OS Version | 10.4 Tiger |
| Product Version | 1.3.2cvs | ||||
| Summary | 0002947: faster FinishScriptRun | ||||
| Description | I'm not absolutely sure if that litte if shouldn't be somewhere more in the core than in the scripter, but it is an improvment for me. BTW: What is GroupOnPage() doing? p54916e07:/Users/tomk32/Downloads/scribus/Scribus/scribus/plugins/scriptplugin root# cvs diff -u scriptercore.cpp cvs diff: warning: failed to open /var/root/.cvspass for reading: No such file or directory Index: scriptercore.cpp =================================================================== RCS file: /cvs/Scribus/scribus/plugins/scriptplugin/scriptercore.cpp,v retrieving revision 1.1.2.38 diff -u -r1.1.2.38 scriptercore.cpp --- scriptercore.cpp 28 Dec 2005 21:59:41 -0000 1.1.2.38 +++ scriptercore.cpp 31 Dec 2005 17:22:30 -0000 @@ -151,9 +151,12 @@ for (uint azz=0; azz<ScMW->doc->Items->count(); ++azz) { PageItem *ite = ScMW->doc->Items->at(azz); + if (ite->Groups.count() != 0) ScMW->doc->GroupOnPage(ite); else + if ( ! ite->Dirty) + continue; ite->OwnPage = ScMW->doc->OnPage(ite); //ScMW->view->setRedrawBounding(ite); ite->setRedrawBounding(); | ||||
| Tags | No tags attached. | ||||
| Patch | |||||
| child of | 0003813 | acknowledged | Metabug: Scripter |
|
|
Reminder sent to: subik Thoughts on this ? |
|
|
well, I'll look at it. Unfortunatelly I'm not an author of this code ;) |
|
|
This patch would result in a faster execution sure, but the results would be incorrect as the dirty flag is meant for fast redraw of already correct layouted textframes. This is not the case here, textframe need a complete relayouting here. |
|
|
Right now the complete document is redraw, not only the text frame. and with my 60+ pages documentes, even if half empty, it's a pain and takes half a minute sometimes. |
|
|
is it a "won't fix", can we close? |
|
|
This will get fixed with Andrea's refactoring of some of the drawing code. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2005-12-31 17:27 | TomK32 | New Issue | |
| 2006-01-01 00:52 |
|
Status | new => assigned |
| 2006-01-01 00:52 |
|
Assigned To | => fschmid |
| 2006-01-01 00:53 |
|
Note Added: 0007876 | |
| 2006-01-01 17:37 | subik | Note Added: 0007888 | |
| 2006-01-03 09:56 | fschmid | Status | assigned => resolved |
| 2006-01-03 09:56 | fschmid | Resolution | open => won't fix |
| 2006-01-03 09:56 | fschmid | Note Added: 0007905 | |
| 2006-01-03 10:14 | TomK32 | Status | resolved => feedback |
| 2006-01-03 10:14 | TomK32 | Resolution | won't fix => reopened |
| 2006-01-03 10:14 | TomK32 | Note Added: 0007906 | |
| 2006-04-14 20:07 | mhanski | Note Added: 0009972 | |
| 2006-05-04 21:42 |
|
Note Added: 0010936 | |
| 2006-05-13 21:01 | christoph_s | Relationship added | child of 0003813 |
