View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0008444ScribusTemplatespublic2009-09-20 01:592016-12-08 22:04
Reporterchristoph_s Assigned Topygmee  
PrioritynormalSeverityfeatureReproducibilityhave not tried
Status assignedResolutionopen 
Target Version1.5.4 
Summary0008444: [patch] More template info needed
DescriptionSince templates may be distributed under different licenses ([L]GPL, CC etc.), it would help to add the same copyrights and licensing info to the templates dialog and the XML files as in the About Plugins dialog.
Tagspatch
PatchYes

Activities

pygmee

2012-10-20 23:24

developer   ~0029064

I agree that as defender of the right license use we should provide such a field. As i saw it's in the roadmap for 150, here is a patch that tries to add it. TODO : check for a trouble in the resize capacities of the windows when retracting and may be add strings to po but i don't know how.

pygmee

2012-10-20 23:26

developer   ~0029065

Right field added to save as template dialog and dialog in the info area of new from template. Would it be usefull to provide a list of commont licenses ? If yes, which ?

pygmee

2012-10-20 23:27

developer  

nft_right.diff (3,715 bytes)    
Index: scribus/plugins/newfromtemplateplugin/nftdialog.cpp
===================================================================
--- scribus/plugins/newfromtemplateplugin/nftdialog.cpp	(révision 17813)
+++ scribus/plugins/newfromtemplateplugin/nftdialog.cpp	(copie de travail)
@@ -159,7 +159,9 @@
        infoText += currentDocumentTemplate->date + "<br>";
        infoText += "<b>"+ tr("Author")+"</b><br>";
        infoText += currentDocumentTemplate->author + "<br>";
-	infoText += currentDocumentTemplate->email + "<br>";
+    infoText += currentDocumentTemplate->email + "<br>";
+    infoText += "<b>"+ tr("Right")+"</b><br>";
+    infoText += currentDocumentTemplate->right + "<br>";
        textBrowser->setText(infoText);
        imageView->clear();
        QPixmap tmplImg(currentDocumentTemplate->img);
Index: scribus/plugins/saveastemplateplugin/satemplate.cpp
===================================================================
--- scribus/plugins/saveastemplateplugin/satemplate.cpp	(révision 17813)
+++ scribus/plugins/saveastemplateplugin/satemplate.cpp	(copie de travail)
@@ -295,6 +295,9 @@
        QString email = QString(dia->emailEdit->text());
        replaceIllegalChars(email);
        tag += "\t\t<email>"+email+"</email>\n";
+    QString right = QString(dia->rightEdit->text());
+    replaceIllegalChars(right);
+    tag += "\t\t<email>"+right+"</email>\n";
        tag += "\t</template>\n";

        return tag;
Index: scribus/plugins/saveastemplateplugin/satdialog.ui
===================================================================
--- scribus/plugins/saveastemplateplugin/satdialog.ui	(révision 17813)
+++ scribus/plugins/saveastemplateplugin/satdialog.ui	(copie de travail)
@@ -7,7 +7,7 @@
     <x>0</x>
     <y>0</y>
     <width>404</width>
-    <height>447</height>
+    <height>456</height>
    </rect>
   </property>
   <property name="windowTitle">
@@ -148,7 +148,21 @@
      </property>
     </widget>
    </item>
-   <item row="9" column="0" colspan="2">
+   <item row="9" column="0">
+    <widget class="QLabel" name="rightLabel">
+     <property name="text">
+      <string>Right:</string>
+     </property>
+    </widget>
+   </item>
+   <item row="9" column="1">
+    <widget class="QLineEdit" name="rightEdit">
+     <property name="toolTip">
+      <string>Rights applied to this document thanks to author wishes</string>
+     </property>
+    </widget>
+   </item>
+   <item row="11" column="0" colspan="2">
     <widget class="QDialogButtonBox" name="buttonBox">
      <property name="orientation">
       <enum>Qt::Horizontal</enum>
Index: scribus/plugins/saveastemplateplugin/satdialog.cpp
===================================================================
--- scribus/plugins/saveastemplateplugin/satdialog.cpp	(révision 17813)
+++ scribus/plugins/saveastemplateplugin/satdialog.cpp	(copie de travail)
@@ -49,6 +49,7 @@
        setupPageSize(pageW, pageH);
        authorEdit->setText(author);
        emailEdit->setText(email);
+    //rightEdit->setText(right);

        // Slots and signals connections
        connect(detailButton, SIGNAL(stateChanged(int)), this, SLOT(detailClicked(int)));
@@ -65,6 +66,7 @@
        usageLabel->setVisible(isFullDetail);
        authorLabel->setVisible(isFullDetail);
        emailLabel->setVisible(isFullDetail);
+    rightLabel->setVisible(isFullDetail);
        psizeEdit->setVisible(isFullDetail);
        catsCombo->setVisible(isFullDetail);
        colorsEdit->setVisible(isFullDetail);
@@ -72,6 +74,7 @@
        usageEdit->setVisible(isFullDetail);
        authorEdit->setVisible(isFullDetail);
        emailEdit->setVisible(isFullDetail);
+    rightEdit->setVisible(isFullDetail);
 }

 void SATDialog::readPrefs()
nft_right.diff (3,715 bytes)   

ale

2012-10-22 11:14

manager   ~0029075

since creating a template is for most people not an everyday task and there may be lot of different licenses to propose (CC is translated to many countries...) i think that a default for the templates seems to me a bit overkill.

but we could have a license field for the documents, and offer there a license field where the user could set the license for each specific document.

the value the person will set in the preferences will be used for each future document and template.

pygmee

2012-10-22 12:13

developer   ~0029077

the patch already provide a new input field for that. My question was more on replacing an input field by a dropdown list with common licences (personnaly i think this will be too much).
But getting info from preferences or document settings might be nice. I'll look how to do it. I also need it for collect4output report.

Issue History

Date Modified Username Field Change
2009-09-20 01:59 christoph_s New Issue
2012-10-20 23:24 pygmee Note Added: 0029064
2012-10-20 23:26 pygmee Note Added: 0029065
2012-10-20 23:26 pygmee Assigned To => pygmee
2012-10-20 23:26 pygmee Status new => feedback
2012-10-20 23:27 pygmee File Added: nft_right.diff
2012-10-21 07:27 pygmee Summary More template info needed => [patch] More template info needed
2012-10-22 11:14 ale Note Added: 0029075
2012-10-22 12:13 pygmee Note Added: 0029077
2012-10-25 06:50 ale Status feedback => assigned
2014-06-13 00:23 Kunda Tag Attached: patch
2014-07-03 19:38 Kunda Target Version 1.5.0 => 1.5.1
2014-10-24 23:00 Kunda Patch => Yes
2015-08-31 12:30 Kunda Category User Interface => Templates
2016-01-23 17:17 cbradney Target Version 1.5.1 => 1.5.3
2016-12-08 22:04 Kunda Target Version 1.5.3 => 1.5.4