|· Hosting provided by Anduin.net / Øverby Consulting ·|
|Anonymous | Login | Signup for a new account||2014-12-18 14:26 CET|
|My View | View Issues | Change Log | Roadmap | Repositories|
|View Issue Details|
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0010289||Scribus||Styles||public||2011-09-29 18:13||2014-10-25 01:00|
|Target Version||Fixed in Version|
|Summary||0010289: [patch] make shortcuts for styles working|
|Description||My patch enabling feature of shortcuts for styles: paragraphs, chars, line and introducing feature for incoming table and cell styles.|
|Attached Files|| stylesshortcut.patch [^] (4,980 bytes) 2011-09-29 18:13 [Show Content]
stylesShortCuts.diff [^] (5,344 bytes) 2012-06-27 09:49 [Show Content]
scribus-stylesShortCuts-20140321.diff [^] (5,246 bytes) 2014-03-21 09:51 [Show Content]
keyboardshortcutpatch_2014-05-03.diff [^] (4,892 bytes) 2014-05-03 11:54 [Show Content]
10289_stylesshortcut.patch [^] (11,824 bytes) 2014-05-05 23:30 [Show Content]
edited on: 2011-10-02 20:31
Several notes about the initial patch
- processing of gui element in a non gui element (ScribusDoc) : i would feel quite uncomfortable in committing that
- circumvent Qt shortcut system hence opening path to future bugs
I looked if another approach was possible and discovered what we probably need in this case : QShortcut (damn, how did i not see that one before...). Contrary to QAction/ScrAction which need to be bound to a visible gui element to have its shortcut usable, QShortcut does not have such requirement. I consequently add a try to see how it works and... it works :) Attached the corresponding patch. We need to look a bit closer at how StyleManager manage shortcuts tho. Given how it works, i'm almost sure there are some bugs around here.
|What about this feature Jean? What can I do with it?|
Jean needs to comment here.. so I will assign it to him.
We'd need a patch against current trunk, we'd need separation of GUI/non GUI, shortcut de-duplication with existing actions if its not there already.
edited on: 2012-06-27 09:53
New patch. Processing moved to ScMW. As for now old Scrobus shortcuts manner. I think there should be complex move to usage of QShortcuts class for all shortcuts in Scribus, not only here.
edited on: 2012-09-21 12:28
I have tested this feature in the scribusECE build to be found on http://www.scribus-ece.info/ [^] and i must say it is a great enhancement for my use of 1.4
As for now, as a 1.4 user, so as to apply a style to some parts of text i need to reach the option where available, that is not easily : 1) In the PP it is a maze through opening and scrolling panes and subpanes just to reach the style selects. 2) Other ways are through the story editor, but since it doesnt open at the right place (see 0010963) it is difficult to use, since it takes very long and cautious reading to find the place where is the text to be styled.
Whit this "shortcut for styles" patch, i have defined shortcuts for all the most common styles. I can then apply them at the speed of a keystroke. It speeds greatly my layout work, particularly on documents with long textes (where the story editor cannot be used).
This patch is a must for scribus. I strongly recommend to bring it to 1.5 and even to 1.4 !
|The "clear previous formatting before applying" option, that goes along with this patch too, is an greaaaat feature too, that helps really.|
|No JLuc, ClearOnApply property is only in my ECE branches, not in this patch.|
|Like JLuc i think this patch really improves comfort in text manipulation and increase productivity. The old patch now make rejection. here is a new one.|
edited on: 2014-04-26 14:36
0012283 has been closed because dupe of this one, but it isn't.
Cezariece's #31818 patch and its by pygmee renewed version introduce a new property for each style, that possibly enables to apply the style using a user defined shortcut.
0012283 is about the allready existing "Apply" stylewindow context menu, whose supposed to exist shortcut (ALT+CTRL+") does not work properly.
Unless you mean that this allready existing shortcut will not be necessary anymore because cezariece's new feature has to be merged and can to some extent replace it more powerfully ?
FYI, " is available directly on the french keyboard (no need for a SHIFT modifier to reach it).
|I've uploaded updodate patch|
My comment on the mailing list today:
Right now, Scribus shortcuts do not allow a differentiation between application mode shortcuts or
text mode shortcuts, nor do we set up actions with default keys like a,A,b,B.
So, with this patch, styles can have a shortcut set as 'b', or 'shift b' for example.. which then
stops you typing any more 'b's.
Any thoughts on how to avoid that?
|2011-09-29 18:13||cezaryece||New Issue|
|2011-09-29 18:13||cezaryece||File Added: stylesshortcut.patch|
|2011-09-30 10:55||ale||Tag Attached: oif|
|2011-09-30 10:55||ale||Tag Attached: oif 2011|
|2011-10-01 16:50||jghali||File Added: 10289_stylesshortcut.patch|
|2011-10-01 16:59||jghali||File Deleted: 10289_stylesshortcut.patch|
|2011-10-01 17:03||jghali||File Added: 10289_stylesshortcut.patch|
|2011-10-01 17:11||jghali||Note Added: 0026937|
|2011-10-02 20:31||jghali||Note Edited: 0026937||View Revisions|
|2012-06-18 14:50||cezaryece||Note Added: 0028183|
|2012-06-18 20:41||cbradney||Note Added: 0028185|
|2012-06-27 09:49||cezaryece||File Added: stylesShortCuts.diff|
|2012-06-27 09:51||cezaryece||Note Added: 0028309|
|2012-06-27 09:53||cezaryece||Note Edited: 0028309||View Revisions|
|2012-09-21 10:44||JLuc||Note Added: 0028952|
|2012-09-21 12:28||JLuc||Note Edited: 0028952||View Revisions|
|2012-09-23 21:31||JLuc||Note Added: 0028965|
|2012-09-24 07:18||cezaryece||Note Added: 0028968|
|2014-03-21 09:51||pygmee||Note Added: 0031530|
|2014-03-21 09:51||pygmee||File Added: scribus-stylesShortCuts-20140321.diff|
|2014-04-05 17:52||christoph_s||Tag Attached: patch|
|2014-04-26 11:52||jghali||Relationship added||has duplicate 0012283|
|2014-04-26 13:43||JLuc||Note Added: 0031818|
|2014-04-26 14:35||JLuc||Note Edited: 0031818||View Revisions|
|2014-04-26 14:36||JLuc||Note Edited: 0031818||View Revisions|
|2014-05-03 11:51||JLuc||File Added: keyboardshortcutpatch_2014-05-03.diff|
|2014-05-03 11:51||JLuc||Note Added: 0031836|
|2014-05-03 11:54||JLuc||File Deleted: keyboardshortcutpatch_2014-05-03.diff|
|2014-05-03 11:54||JLuc||File Added: keyboardshortcutpatch_2014-05-03.diff|
|2014-05-04 20:08||cbradney||Note Added: 0031837|
|2014-05-05 23:27||jghali||File Deleted: 10289_stylesshortcut.patch|
|2014-05-05 23:30||jghali||File Added: 10289_stylesshortcut.patch|
|2014-10-09 00:59||Kunda||Tag Attached: oif2011|
|2014-10-09 00:59||Kunda||Tag Detached: oif 2011|
|2014-10-11 20:35||Kunda||Tag Detached: oif2011|
|2014-10-25 00:57||Kunda||Patch||=> Yes|
|My View | View Issues | Change Log | Roadmap | Repositories|
|Copyright © 2000 - 2014 MantisBT Team|