View Issue Details

IDProjectCategoryView StatusLast Update
0010528ScribusStory Editor / Text Framespublic2012-04-29 10:59
Reportercezaryece Assigned Tofschmid  
PrioritynormalSeveritymajorReproducibilitysometimes
Status closedResolutionfixed 
Product Version1.4.0 
Fixed in Version1.4.1.svn 
Summary0010528: [BUG] wrong line spacing between paragraphs calculation after overflow
DescriptionSometimes yPos value is calculated wrong for first line of paragraph if there is overflow at end of that line.
Steps To ReproduceSe attached screen. All paragraphs has same style without set any gaps between paragraphs. For 3th paragraph addition space on top is added.
Additional InformationUploaded patch fixes that issue.
TagsNo tags attached.
Patch

Activities

cezaryece

2012-01-18 12:03

updater  

fixLineSpacing.patch (727 bytes)   
Index: scribus/pageitem_textframe.cpp
===================================================================
--- scribus/pageitem_textframe.cpp	(wersja 17211)
+++ scribus/pageitem_textframe.cpp	(kopia robocza)
@@ -1874,6 +1891,12 @@
 					double newXAdd = overflowWidth - style.rightMargin() + style.minGlyphExtension() * wide + hyphWidth;
 					if (current.isEndOfLine(newXAdd) || current.xPos + newXAdd >= current.colRight || realEnd >= current.mustLineEnd)
 					{
+						if (!current.afterOverflow)
+						{
+							current.addLine = true;
+							current.lastInRowLine = true;
+						}
+						//line must end before overflov
 						if (!current.addLine && !current.lastInRowLine)
 						{
 							if (current.afterOverflow)
 
fixLineSpacing.patch (727 bytes)   

cezaryece

2012-01-18 12:04

updater  

linespaceissue.jpg (113,490 bytes)   
linespaceissue.jpg (113,490 bytes)   

jghali

2012-01-18 23:08

administrator   ~0027564

Weird, cannot reproduce the issue here, could you upload a sample document so i can test?

cezaryece

2012-01-19 08:00

updater  

indent.sla (17,544 bytes)

cezaryece

2012-01-19 08:01

updater   ~0027566

Open indent.sla file and play with center frame...

Issue History

Date Modified Username Field Change
2012-01-18 12:03 cezaryece New Issue
2012-01-18 12:03 cezaryece File Added: fixLineSpacing.patch
2012-01-18 12:04 cezaryece File Added: linespaceissue.jpg
2012-01-18 23:08 jghali Note Added: 0027564
2012-01-19 08:00 cezaryece File Added: indent.sla
2012-01-19 08:01 cezaryece Note Added: 0027566
2012-01-29 09:59 fschmid Status new => resolved
2012-01-29 09:59 fschmid Fixed in Version => 1.4.1.svn
2012-01-29 09:59 fschmid Resolution open => fixed
2012-01-29 09:59 fschmid Assigned To => fschmid
2012-04-29 10:59 cbradney Status resolved => closed
2015-09-17 20:08 Kunda Category Story Editor / Text Frames => Story Ed/Txt Frames
2015-09-17 20:12 Kunda Category Story Ed/Txt Frames => Story Editor / Text Frames