View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0010715 | Scribus | Shape Drawing | public | 2012-05-20 22:31 | 2012-06-19 18:35 |
| Reporter | gpittman | Assigned To | cbradney | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 1.4.1 | ||||
| Fixed in Version | 1.4.2.svn | ||||
| Summary | 0010715: cannot create a Polygon from the menu Insert > Polygon | ||||
| Description | Fails to activate the mouse to draw the polygon. You can bring up the dialog to choose features of the polygon, but then nothing... Not working in 1.4.2svn either. Working Ok in 1.5.0 | ||||
| Steps To Reproduce | Click Insert > Polygon > Properties Click Ok, with or without adjustments. Mouse not activated for drawing the polygon. Toolbar and keyboard shortcut work Ok. | ||||
| Tags | No tags attached. | ||||
| Patch | |||||
|
|
Here is something that fixes the problem, found by looking at the differences between 1.4.1 and 1.5.0. In the file scribus/ui/modetoolbar.cpp, line 93 (in 1.4.1svn): if (dia->exec()) dia->getValues(&m_ScMW->doc->toolSettings.polyC, &m_ScMW->doc->toolSettings.polyFd, &m_ScMW->doc->toolSettings.polyF, &m_ScMW->doc->toolSettings.polyS, &m_ScMW->doc->toolSettings.polyR, &m_ScMW->doc->toolSettings.polyCurvature); delete dia; should be:(?) if (dia->exec()) { dia->getValues(&m_ScMW->doc->toolSettings.polyC, &m_ScMW->doc->toolSettings.polyFd, &m_ScMW->doc->toolSettings.polyF, &m_ScMW->doc->toolSettings.polyS, &m_ScMW->doc->toolSettings.polyR, &m_ScMW->doc->toolSettings.polyCurvature); m_ScMW->scrActions["toolsInsertPolygon"]->trigger(); } delete dia; |
|
|
polygon_patch.diff (805 bytes)
Index: scribus/ui/modetoolbar.cpp
===================================================================
--- scribus/ui/modetoolbar.cpp (revision 17508)
+++ scribus/ui/modetoolbar.cpp (working copy)
@@ -91,7 +91,10 @@
{
PolygonProps* dia = new PolygonProps(this, m_ScMW->doc->toolSettings.polyC, m_ScMW->doc->toolSettings.polyFd, m_ScMW->doc->toolSettings.polyF, m_ScMW->doc->toolSettings.polyS, m_ScMW->doc->toolSettings.polyR, m_ScMW->doc->toolSettings.polyCurvature);
if (dia->exec())
+ {
dia->getValues(&m_ScMW->doc->toolSettings.polyC, &m_ScMW->doc->toolSettings.polyFd, &m_ScMW->doc->toolSettings.polyF, &m_ScMW->doc->toolSettings.polyS, &m_ScMW->doc->toolSettings.polyR, &m_ScMW->doc->toolSettings.polyCurvature);
+ m_ScMW->scrActions["toolsInsertPolygon"]->trigger();
+ }
delete dia;
}
|
|
|
I added my first attempt to submit a patch file...hope it works. Tried it on another computer, and patch was applied correctly. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2012-05-20 22:31 | gpittman | New Issue | |
| 2012-05-21 00:32 | gpittman | Note Added: 0028019 | |
| 2012-05-21 00:50 | gpittman | File Added: polygon_patch.diff | |
| 2012-05-21 00:51 | gpittman | Note Added: 0028020 | |
| 2012-05-21 01:47 | gpittman | Note Edited: 0028020 | |
| 2012-05-21 15:57 | cbradney | Assigned To | => cbradney |
| 2012-05-21 15:57 | cbradney | Status | new => assigned |
| 2012-05-21 16:01 | cbradney | Status | assigned => resolved |
| 2012-05-21 16:01 | cbradney | Fixed in Version | => 1.4.2.svn |
| 2012-05-21 16:01 | cbradney | Resolution | open => fixed |
| 2012-06-19 18:35 | cbradney | Status | resolved => closed |
