View Issue Details

IDProjectCategoryView StatusLast Update
0010922ScribusGeneralpublic2012-07-23 07:33
Reporterale Assigned Tocezaryece  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version1.5.0svn 
Fixed in Version1.5.0svn 
Summary0010922: Footnotes: two warnings from make
Descriptioni had two warnings from make that seem to be related with the footnotes code:

  /home/ale/docs/src/scribus.git/Scribus/scribus/pageitem_textframe.cpp: In member function ‘virtual void PageItem_TextFrame::layout()’:
  /home/ale/docs/src/scribus.git/Scribus/scribus/pageitem_textframe.cpp:1366:33: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
  /home/ale/docs/src/scribus.git/Scribus/scribus/pageitem_textframe.cpp: In member function ‘NotesInFrameMap PageItem_TextFrame::updateNotesFrames(QMap<int, Mark*>)’:
  /home/ale/docs/src/scribus.git/Scribus/scribus/pageitem_textframe.cpp:4908:13: warning: enumeration value ‘NSRframe’ not handled in switch [-Wswitch]

not sure, but the second may not be as unproblematic as a warning would suggest...
TagsNo tags attached.
Patch

Activities

cezaryece

2012-07-23 06:25

updater   ~0028558

1. "comparison" - it is because we have itemText.lenght() return as int, and firstChar definied as uint (but OK, changed to firstInFrame())
2. it is case of endnotes - for endnotes range frame is prohibited as has not many sense (endnotes for frame = footnotes for frame)

Issue History

Date Modified Username Field Change
2012-07-21 11:46 ale New Issue
2012-07-21 11:46 ale Status new => assigned
2012-07-21 11:46 ale Assigned To => cezaryece
2012-07-21 11:46 ale Issue generated from: 0010921
2012-07-23 06:25 cezaryece Note Added: 0028558
2012-07-23 06:25 cezaryece Status assigned => closed
2012-07-23 06:25 cezaryece Resolution open => no change required
2012-07-23 06:25 cezaryece Fixed in Version => 1.5.0svn
2012-07-23 07:33 cezaryece Status closed => feedback
2012-07-23 07:33 cezaryece Resolution no change required => reopened
2012-07-23 07:33 cezaryece Status feedback => resolved
2012-07-23 07:33 cezaryece Resolution reopened => fixed
2012-07-23 07:33 cezaryece Status resolved => closed