View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0011070 | Scribus | User Interface | public | 2012-09-13 14:23 | 2012-11-13 20:23 |
Reporter | Vladimir Savic | Assigned To | jghali | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Platform | Linux | OS | Ubuntu | OS Version | 12.04 |
Product Version | 1.5.0svn | ||||
Fixed in Version | 1.5.0svn | ||||
Summary | 0011070: Snap to Items indicator misplaced when document has bleed area | ||||
Description | When having document with bleeds set to other then 0units, snapping to items indicator is always offset to exact value of bleeds. Snapping does work like it should though. | ||||
Tags | No tags attached. | ||||
Patch | |||||
|
Sorry vlada, I am trying to reproduce it and I doesn't succeed. Can you show me where do I have to change bleed configuration? For my tests, I do : File -> Document configuration -> marge and bleeds and I set values in spinbox for blee but may be I am doing something wrong ... |
|
I've uploaded video demonstration on how problem manifests. It might be good thing if ale could replicate the problem too. :) |
|
|
|
There is a solution: diff --git a/Scribus/scribus/canvasmode.cpp b/Scribus/scribus/canvasmode.cpp index 4b98d50..8045beb 100644 --- a/Scribus/scribus/canvasmode.cpp +++ b/Scribus/scribus/canvasmode.cpp @@ -773,6 +773,7 @@ void CanvasMode::drawSnapLine(QPainter* p) if(ySnap) { p->setPen(Qt::green); + ySnap += m_doc->bleedsVal().Top* m_canvas->scale(); double x = (m_doc->currentPage()->xOffset() - m_doc->bleedsVal().Left)* m_canvas->scale(); double w = (m_doc->currentPage()->width() + m_doc->bleedsVal().Left + m_doc->bleedsVal().Right) * m_canvas->scale(); p->drawLine(x, ySnap, x+w,ySnap); @@ -781,6 +782,7 @@ void CanvasMode::drawSnapLine(QPainter* p) if(xSnap) { p->setPen(Qt::green); + xSnap += m_doc->bleedsVal().Left* m_canvas->scale(); double y = (m_doc->currentPage()->yOffset() - m_doc->bleedsVal().Top) * m_canvas->scale(); double h = (m_doc->currentPage()->height() + m_doc->bleedsVal().Bottom + m_doc->bleedsVal().Top) * m_canvas->scale(); p->drawLine(xSnap, y, xSnap,y+h); |
|
The proposed fix unfortunately does not work when using asymmetric bleed values with facing pages. Eg : 3mm for interior and top bleed, 6mm for exterior and bottom bleed. |
|
Pity! Is there any other easy solution? |
|
I think i have one, however it involves modifying a few more files and some testing. |
|
Please do so! You've got yourself a tester! :) |
|
Fix committed as r17839, r17842 and r17843. Please test! |
|
Works much, much better now. Feel free to close this report. If I find something else, I'll open another one. Thank you! |
|
:-) |
Date Modified | Username | Field | Change |
---|---|---|---|
2012-09-13 14:23 | Vladimir Savic | New Issue | |
2012-09-13 14:33 | Chelen | Assigned To | => Chelen |
2012-09-13 14:33 | Chelen | Status | new => assigned |
2012-10-08 09:22 | Chelen | Note Added: 0029021 | |
2012-10-09 20:09 | Vladimir Savic | Note Added: 0029030 | |
2012-10-09 20:10 | Vladimir Savic | File Added: out-1.ogv | |
2012-10-09 21:29 | Chelen | Note Added: 0029032 | |
2012-10-28 20:34 | jghali | Note Added: 0029123 | |
2012-10-28 21:05 | Vladimir Savic | Note Added: 0029125 | |
2012-10-28 22:14 | jghali | Note Added: 0029126 | |
2012-10-28 22:22 | Vladimir Savic | Note Added: 0029127 | |
2012-10-28 22:32 | jghali | Note Edited: 0029126 | |
2012-10-28 22:37 | jghali | Note Edited: 0029126 | |
2012-10-28 23:38 | jghali | Note Added: 0029128 | |
2012-10-29 02:04 | Vladimir Savic | Note Added: 0029129 | |
2012-10-29 05:07 | jghali | Note Added: 0029130 | |
2012-10-29 05:07 | jghali | Status | assigned => resolved |
2012-10-29 05:07 | jghali | Fixed in Version | => 1.5.0svn |
2012-10-29 05:07 | jghali | Resolution | open => fixed |
2012-10-29 05:07 | jghali | Assigned To | Chelen => jghali |
2012-11-13 20:23 | cbradney | Status | resolved => closed |