View Issue Details

IDProjectCategoryView StatusLast Update
0011586ScribusInternalpublic2013-06-20 20:54
Reportercezaryece Assigned Tojghali  
PrioritynormalSeverityminorReproducibilityN/A
Status closedResolutionfixed 
Product Version1.5.0svn 
Fixed in Version1.5.0svn 
Summary0011586: refactoring ScribusDoc* data members to m_Doc
DescriptionIn many classes in Scribus code there is pointer to ScribusDoc object.
Usualy it is named "m_Doc" but I have found few where it is named "doc" or "Doc" or "doc.
My proposal is to renaming all to common used "m_Doc".

For example ScribusMainWindow has two members pointing to ScribusDoc objects - "doc" and "m_doc". And "doc" is widely used in other classes, "m_doc" seems to be used only locally for ScribusDoc object with default settings. For me it should be vice versa - doc locally and m_Doc for public access.
TagsNo tags attached.
Patch

Activities

cbradney

2013-06-12 17:52

administrator   ~0030273

Last edited: 2013-06-12 17:54

anything m_ is internal to the class. Most classes should not share that pointer out. Most that are not called m_Doc are from history and need renaming.

Issue History

Date Modified Username Field Change
2013-06-12 12:00 cezaryece New Issue
2013-06-12 12:00 cezaryece Status new => assigned
2013-06-12 12:00 cezaryece Assigned To => jghali
2013-06-12 17:52 cbradney Note Added: 0030273
2013-06-12 17:54 cbradney Note Edited: 0030273
2013-06-17 23:05 jghali Summary Proposal: refactoring ScribusDoc* data members to m_Doc => refactoring ScribusDoc* data members to m_Doc
2013-06-19 19:46 jghali Status assigned => resolved
2013-06-19 19:46 jghali Fixed in Version => 1.5.0svn
2013-06-19 19:46 jghali Resolution open => fixed
2013-06-20 20:54 christoph_s Status resolved => closed