Mantis Issue Tracking for Scribus
· Hosting provided by Anduin.net / Øverby Consulting ·

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0011988ScribusUser Interfacepublic2014-01-17 22:392015-07-17 09:16
ReporterJLuc 
Assigned Tocbradney 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version1.5.0svn 
Target Version1.5.1Fixed in Version1.5.1svn 
Summary0011988: [Patch] Preselected glyphs hint bubble should also display the unicode name of the glyph and the name of the font
DescriptionIn the favorite glyphs palette, there is a hint on each preselected glyph : it displays the Unicode code of the glyph.

It would help a lot to display also
- the name of the font.
- the unicode name of the glyph. For example 0x273F is also known as "BLACK FLORETTE"

Usefull also for totally blank glyphs (SOFT HYPHEN, NON BREAKING THIN SPACE, ...)

AMOF scribus allready knows all unicode names as can be seen in the table that opens when clicking on the "Magnifiying Glass" button of the favorite glyphs palette.

see also
http://www.unicode.org/ucd/#UCDinXML [^]
http://www.unicode.org/Public/UCD/latest/ucd/UnicodeData.txt [^]
http://www.fileformat.info/info/unicode/char/273f/index.htm [^]
https://github.com/fontforge/libuninameslist [^]

Tagspatch
PatchYes
Attached Filespatch file icon 0011988_glyph-description-status-label_v4.patch [^] (5,535 bytes) 2015-07-16 23:16 [Show Content]
png file icon char_palette.png [^] (12,053 bytes) 2015-07-16 23:26

- Relationships
related to 0011952confirmed Character Palette UI enhancements 
related to 0012032closed Glyph/Character Menu/Window naming inconsistency 
has duplicate 0011067closed Insert glyph window 

-  Notes
(0033364)
ale (manager)
2014-08-29 15:25

the request is good...

but i would not implement it as a tooltip.

one of both:

- show the information below each glyph (probably the best way to do it).
- add a separate area where you add the information about the current item.
(0033366)
Kunda (manager)
2014-08-29 21:21

ale, if you could provide the structure template for how to add text below each glyph and a separate area to add the info for the current item...then it's just a question of compiling that info for each glyph. So most of legwork of this patch would be researching and data-entry for each glyph.
(0035667)
simonaw (reporter)
2015-07-06 21:35

Added m_statusLabel for the glyph description
(0035668)
Kunda (manager)
2015-07-06 22:07

Awesome! Will compile and test now
(0035671)
Kunda (manager)
2015-07-06 23:00

Here is a screencast of the patch implemented:
https://www.dropbox.com/s/w9vxyswspmc0qxg/GlyphInsertPatch.m4v?dl=0 [^]
(0035673)
Kunda (manager)
2015-07-07 03:22

SimonAW, perhaps we can also address 0012032 while you're tweeking this ?
(0035674)
Kunda (manager)
2015-07-07 03:24

And 0011952
(0035680)
JLuc (developer)
2015-07-07 10:00

That looks nice.
Could the text also introduce the glyph's font name ?
(0035687)
Kunda (manager)
2015-07-08 15:58

Jluc, where should it introduce the fonts name ?
(0035695)
JLuc (developer)
2015-07-08 19:17
edited on: 2015-07-09 19:22

Kunda What is it you dont understand exactly ?

The prefered glyphs can be of various fonts.
As for now, it is not possible (in the glyphs palette) to know which is the font for a prefered glyph.
This is an issue when wanting to get to the same font so as to get another glyph of same font, or when wanting to be sure this is the exact wanted glyph.

With simonaw's patch, a long text below the box explains which is the glyph.
That's nice, but this very same area should also mention the name of the font.


I wish to rise another issue : I'm surprised that there is a long english sentence to describe the glyph. There are about 120737 defined unicode glyphs. Will scribus define 120,737 sentence to describe them all ?
And how will these long english explanations be translated ?
Is there a public repo with all explanations and translations ?

In case there is no satisfying answer to the previous questions, it would be way more simple and more robust to mention the plain name of the unicode glyph (instead of the long sentence describing it).

That unicode name does not need to be translated.

(0035709)
Kunda (manager)
2015-07-09 14:38

120,737! holy smokes, that's an enormous amount.
(0035718)
simonaw (reporter)
2015-07-09 21:17

@JLuc regarding the font name I can have a look.

Regarding the glyph description there is a text file "unicodenameslist.txt" in share/scribus describing /only/ 17'824. I don't know who is maintaining this file but maybe there is some official version that also comes in various translated languages?
(0035721)
simonaw (reporter)
2015-07-09 23:07

New Patch, New Screenshot
(0035723)
simonaw (reporter)
2015-07-09 23:30

V3
(0035724)
Kunda (manager)
2015-07-10 00:36

Simon, compiles :)
Nice update :)
Found a bug:
https://www.dropbox.com/s/30q4n8aiimihm8s/charpallet-v3.m4v [^]
that second char (apostrophe) won't insert to textbox when I double clicked on it.
(0035727)
cbradney (administrator)
2015-07-10 01:09
edited on: 2015-07-10 01:31

@SimonAW...

void CharSelect::slot_selectionChanged( const QItemSelection& sel, const QItemSelection& ) {
  
QModelIndexList indexes = sel.indexes();
  if ( indexes.size() == 0 ) return;
  QModelIndex index = indexes.at(0);
  if ( !index.isValid() ) return;

  QVariant tmp = index.data(Qt::StatusTipRole);
  if ( !tmp.canConvert(QMetaType::QStringList) ) {
    m_statusLabel->setText(QString());
    return;
  }

  QStringList lst = tmp.toStringList();
  m_statusLabel->setText(
      QString("< p >< b >%1< /b >< /p >< p >Font: %2< /p>").arg(
        
m_unicodeSearchModel->descriptionFromHex( lst.at(0) )
        ).arg(
          lst.at(1)
          )
    );
}

Scribus code style wants this to be like this:

void CharSelect::slot_selectionChanged(const QItemSelection& sel, const QItemSelection&)
{
    QModelIndexList indexes = sel.indexes();
    if (indexes.size() == 0)
        return;
    QModelIndex index = indexes.at(0);
    if (!index.isValid()) 
        return;

    QVariant tmp = index.data(Qt::StatusTipRole);
    if (!tmp.canConvert(QMetaType::QStringList))
    {
        m_statusLabel->setText(QString());
        return;
    }

    QStringList lst(tmp.toStringList());
    m_statusLabel->setText(QString("< p >< b >%1< /b >< /p >< p >Font: 
%2< /p >").arg(m_unicodeSearchModel->descriptionFromHex(lst.at(0))).arg(lst.at(1)));
}


Note extra spaces around < p > to avoid mantis reformatting.

{s on new lines
tabs are spaced at 4 chars
returns on new lines

FYI I have committed a fix to remove the deprecated QString::sprintf() in chartablemodel.cpp.

(0035729)
Kunda (manager)
2015-07-10 02:11
edited on: 2015-07-10 02:11

jluc,
7:01 PM	<Kunda> do you know anything about if this file is translated in to other languages
7:01 PM	<Kunda> ?
7:02 PM	<Kunda> this is the comment: http://bugs.scribus.net/view.php?id=11988#c35718 [^]
7:02 PM	<MrB> http://unicode.org/Public/UNIDATA/NamesList.txt [^]
7:02 PM	<MrB> http://unicode.org/charts/charindex.html [^]
7:03 PM	<mrscribe> Title: Character Name Index (at unicode.org)
7:05 PM	<MrB> I am not aware of any translations of this list.. apart from this US version I found 
here http://unicode.org/notes/tn24/ [^] just now..
7:05 PM	<mrscribe> Title: UTN # 24: Sample American English Translation of Unicode Names List (at 
unicode.org)
7:05 PM	<Kunda> do these words need to be translated ?
7:05 PM	<Kunda> unicode character names
7:06 PM	<MrB> no idea.. we wouldnt add it to the translation files, no
7:06 PM	<Kunda> just shows all the words in english
7:06 PM	<Kunda> good
7:06 PM	<MrB> no idea if InDesign comes with a French version of the list or not
7:07 PM	<MrB> but no, we are not translating that stuff


(0035733)
simonaw (reporter)
2015-07-10 13:22

@cbradney I didn't consider this patch final because I didn't expect coming this far. So this is why it was not styled according to the coding style guidelines. Sorry.
(0035737)
Kunda (manager)
2015-07-10 14:08

simonaw, did you see the bug shown in the screencast? Can you recreate ?
(0035740)
cbradney (administrator)
2015-07-10 18:25

@SimonAW.. that's ok... just saying
(0035754)
Kunda (manager)
2015-07-11 03:28

Thanks to SimonAW, we figured out that what I encoutnered wasn't a bug so much. The problem pre-exists the patch. It was a 'combined' glyph that expects to be combined with another glyph. I think for now the patch that SimonAW proposes could be submitted for review and hopefully committed.

The Glyph/Char palette is low priority in regards to what is pending for the 1.5.1 release. Perhaps we can all get on the same page as to what the actual roadmap is.
(0035758)
cbradney (administrator)
2015-07-11 18:30

Work has been done, lets get an updated patch and I'll commit it
(0035762)
JLuc (developer)
2015-07-13 11:06
edited on: 2015-07-15 00:42

In case these "long sentences" are the official unicode name, then they dont have to be translated. http://www.unicode.org/Public/UCD/latest/ucd/UnicodeData.txt [^] seem to provide a (partial or complete) list. Strangely name for 00C6 is "LATIN CAPITAL LETTER AE", not "latin capitale letter ae (ash)" but i cant draw any conclusion of that apparent mismatch.


This patch is great and will improve usability of character palette !

(0035788)
JLuc (developer)
2015-07-15 00:42

SimonAw : Craig B is ready to merge your patch. He waits now for your "final" patch, that is the rewriten patch according to scribus styles guidelines.

Thanks in advance !
(0035790)
simonaw (reporter)
2015-07-15 09:46

@JLuc Sorry, was very busy lately. If you can wait I will submit the new patch in the evening. Thanks.
(0035807)
simonaw (reporter)
2015-07-16 23:27

So. Sorry for the delay. Let's see what this patch brings...

I also added a status label clear on clearing the char palette.
(0035808)
Kunda (manager)
2015-07-17 01:22

Thanks for all the work on this patch. Committed by Craig in r20254/5
(0035817)
christoph_s (administrator)
2015-07-17 09:16

Tested, fixed for the time being. Once we have a complete list of Unicode names, someone please open a new report.

- Issue History
Date Modified Username Field Change
2014-01-17 22:39 JLuc New Issue
2014-01-17 22:39 JLuc Tag Attached: easyhack
2014-01-17 22:40 JLuc Note Added: 0031115
2014-01-17 23:41 JLuc Note Added: 0031118
2014-01-17 23:45 JLuc Note Edited: 0031118 View Revisions
2014-01-17 23:52 JLuc Note Edited: 0031118 View Revisions
2014-07-04 21:10 JLuc Note Added: 0032483
2014-07-04 21:10 JLuc Tag Detached: easyhack
2014-07-04 21:11 JLuc Note Edited: 0032483 View Revisions
2014-07-05 02:05 Kunda Target Version => 1.5.1
2014-07-05 02:05 Kunda Summary The preselected glyphs hint bubble should display the name of the font => The preselected glyphs hint bubble should display the UNICODE NAME of the glyph and the name of the font
2014-07-14 18:15 Kunda Relationship added related to 0011952
2014-08-29 15:25 ale Note Added: 0033364
2014-08-29 21:21 Kunda Note Added: 0033366
2014-08-29 21:39 Kunda Relationship added related to 0012032
2015-06-26 23:24 Kunda Relationship added has duplicate 0011067
2015-06-27 08:20 JLuc Patch => No
2015-06-27 08:20 JLuc Description Updated View Revisions
2015-06-27 08:20 JLuc Note Deleted: 0031115
2015-06-27 08:20 JLuc Note Deleted: 0031118
2015-06-27 08:24 JLuc Description Updated View Revisions
2015-06-27 08:24 JLuc Note Deleted: 0032483
2015-06-27 08:25 JLuc Status new => confirmed
2015-07-05 21:35 JLuc Summary The preselected glyphs hint bubble should display the UNICODE NAME of the glyph and the name of the font => The preselected glyphs hint bubble should also display the unicode name of the glyph and the name of the font
2015-07-05 21:36 JLuc Description Updated View Revisions
2015-07-06 21:34 simonaw File Added: char-palette-with-status.png
2015-07-06 21:34 simonaw File Added: 0011988_glyph-description-status-label.patch
2015-07-06 21:35 simonaw Tag Attached: patch
2015-07-06 21:35 simonaw Note Added: 0035667
2015-07-06 22:07 Kunda Note Added: 0035668
2015-07-06 23:00 Kunda Note Added: 0035671
2015-07-07 03:20 Kunda Patch No => Yes
2015-07-07 03:20 Kunda Summary The preselected glyphs hint bubble should also display the unicode name of the glyph and the name of the font => [Patch] Preselected glyphs hint bubble should also display the unicode name of the glyph and the name of the font
2015-07-07 03:22 Kunda Note Added: 0035673
2015-07-07 03:24 Kunda Note Added: 0035674
2015-07-07 10:00 JLuc Note Added: 0035680
2015-07-08 15:58 Kunda Note Added: 0035687
2015-07-08 19:17 JLuc Note Added: 0035695
2015-07-09 14:38 Kunda Note Added: 0035709
2015-07-09 19:22 JLuc Note Edited: 0035695 View Revisions
2015-07-09 21:17 simonaw Note Added: 0035718
2015-07-09 23:03 simonaw File Deleted: char-palette-with-status.png
2015-07-09 23:04 simonaw File Deleted: 0011988_glyph-description-status-label.patch
2015-07-09 23:04 simonaw File Added: 0011988_glyph-description-status-label_v2.patch
2015-07-09 23:07 simonaw File Added: char-palette-v2.png
2015-07-09 23:07 simonaw Note Added: 0035721
2015-07-09 23:30 simonaw File Deleted: 0011988_glyph-description-status-label_v2.patch
2015-07-09 23:30 simonaw File Added: 0011988_glyph-description-status-label_v3.patch
2015-07-09 23:30 simonaw Note Added: 0035723
2015-07-10 00:36 Kunda Note Added: 0035724
2015-07-10 01:09 cbradney Note Added: 0035727
2015-07-10 01:13 cbradney Note Added: 0035728
2015-07-10 01:14 cbradney Note Deleted: 0035728
2015-07-10 01:20 Kunda Note Edited: 0035727 View Revisions
2015-07-10 01:31 Kunda Note Edited: 0035727 View Revisions
2015-07-10 01:31 Kunda Note Edited: 0035727 View Revisions
2015-07-10 02:11 Kunda Note Added: 0035729
2015-07-10 02:11 Kunda Note Edited: 0035729 View Revisions
2015-07-10 13:22 simonaw Note Added: 0035733
2015-07-10 14:08 Kunda Note Added: 0035737
2015-07-10 18:25 cbradney Note Added: 0035740
2015-07-11 03:28 Kunda Note Added: 0035754
2015-07-11 18:30 cbradney Note Added: 0035758
2015-07-13 11:06 JLuc Note Added: 0035762
2015-07-15 00:20 JLuc Description Updated View Revisions
2015-07-15 00:27 cbradney Assigned To => cbradney
2015-07-15 00:27 cbradney Status confirmed => assigned
2015-07-15 00:42 JLuc Note Added: 0035788
2015-07-15 00:42 JLuc Note Edited: 0035762 View Revisions
2015-07-15 09:46 simonaw Note Added: 0035790
2015-07-16 23:16 simonaw File Deleted: 0011988_glyph-description-status-label_v3.patch
2015-07-16 23:16 simonaw File Deleted: char-palette-v2.png
2015-07-16 23:16 simonaw File Added: 0011988_glyph-description-status-label_v4.patch
2015-07-16 23:26 simonaw File Added: char_palette.png
2015-07-16 23:27 simonaw Note Added: 0035807
2015-07-16 23:50 cbradney Status assigned => resolved
2015-07-16 23:50 cbradney Fixed in Version => 1.5.1svn
2015-07-16 23:50 cbradney Resolution open => fixed
2015-07-17 01:22 Kunda Note Added: 0035808
2015-07-17 09:16 christoph_s Note Added: 0035817
2015-07-17 09:16 christoph_s Status resolved => closed



Copyright © 2000 - 2015 MantisBT Team
Powered by Mantis Bugtracker