View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0012501 | Scribus | User Interface | public | 2014-07-09 02:23 | 2015-02-23 18:04 |
| Reporter | FirasH | Assigned To | jghali | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Platform | x86_64 | OS | openSUSE | OS Version | 13.1 |
| Product Version | 1.5.0svn | ||||
| Target Version | 1.5.0 | Fixed in Version | 1.5.0svn | ||
| Summary | 0012501: [TESTED-PATCH] Tooltip missing for Barcode | ||||
| Description | Tooltips missing for Story Editor and Barcode. EDIT: Story Editor fixed | ||||
| Steps To Reproduce | 0) Launch Scribus, no opened document is necessary 1) Move the mouse pointer on the tool: - Edit Text in the Story Editor (Ctrl+T) - Barcode No tooltip is shown in the lower-left part of the UI as with the other tools. | ||||
| Additional Information | Scribus 1.5.0.svn (19331) | ||||
| Tags | No tags attached. | ||||
| Attached Files | actionmanager.cpp.patch (1,072 bytes)
--- actionmanager2.cpp 2014-08-01 23:03:54.581561139 +0200
+++ actionmanager.cpp 2014-08-01 23:04:42.190565571 +0200
@@ -1755,9 +1755,9 @@
(*scrActions)["filePrint"]->setStatusTextAndShortcut( tr("Print the document"));
(*scrActions)["fileSave"]->setStatusTextAndShortcut( tr("Save the current document"));
(*scrActions)["toolsCopyProperties"]->setStatusTextAndShortcut( tr("Copy item properties"));
(*scrActions)["toolsEditContents"]->setStatusTextAndShortcut( tr("Edit contents of a frame"));
- (*scrActions)["toolsEditWithStoryEditor"]->setText( tr("Edit text in the Story Editor"));
+ (*scrActions)["toolsEditWithStoryEditor"]->setStatusTextAndShortcut( tr("Edit text in the Story Editor"));
(*scrActions)["toolsEyeDropper"]->setStatusTextAndShortcut( tr("Eye Dropper"));
(*scrActions)["toolsInsertArc"]->setStatusTextAndShortcut( tr("Insert an arc"));
(*scrActions)["toolsInsertBezier"]->setStatusTextAndShortcut( tr("Insert a bezier curve"));
(*scrActions)["toolsInsertCalligraphicLine"]->setStatusTextAndShortcut( tr("Insert a calligraphic line"));
patch.diff (482 bytes)
diff --git a/scribus/plugins/barcodegenerator/barcode.cpp b/scribus/plugins/barcodegenerator/barcode.cpp
index 535094d..e08db59 100644
--- a/scribus/plugins/barcodegenerator/barcode.cpp
+++ b/scribus/plugins/barcodegenerator/barcode.cpp
@@ -22,6 +22,7 @@ void Barcode::languageChange()
{
m_actionInfo.name = "BarcodeGenerator";
m_actionInfo.text = tr("Barcode");
+ m_actionInfo.helpText = tr("To include Barcode.");
if (ScCore->haveGS())
{
m_actionInfo.menu = "Insert";
patchv2.diff (2,122 bytes)
diff --git a/scribus/actionmanager.cpp b/scribus/actionmanager.cpp
index 8ce1899..6c651e7 100644
--- a/scribus/actionmanager.cpp
+++ b/scribus/actionmanager.cpp
@@ -1679,7 +1679,7 @@ void ActionManager::languageChange()
(*scrActions)["toolsZoomIn"]->setTexts( tr("Zoom in"));
(*scrActions)["toolsZoomOut"]->setTexts( tr("Zoom out"));
(*scrActions)["toolsEditContents"]->setTexts( tr("Edit Contents of Frame"));
- (*scrActions)["toolsEditWithStoryEditor"]->setText( tr("Edit Text..."));
+ (*scrActions)["toolsEditWithStoryEditor"]->setText( tr("Edit text in the Story Editor"));
(*scrActions)["toolsLinkTextFrame"]->setTexts( tr("Link Text Frames"));
(*scrActions)["toolsUnlinkTextFrame"]->setTexts( tr("Unlink Text Frames"));
(*scrActions)["toolsUnlinkTextFrameWithTextCopy"]->setTexts( tr("Unlink Text Frame with Text Copy"));
@@ -1756,7 +1756,7 @@ void ActionManager::languageChange()
(*scrActions)["fileSave"]->setStatusTextAndShortcut( tr("Save the current document"));
(*scrActions)["toolsCopyProperties"]->setStatusTextAndShortcut( tr("Copy item properties"));
(*scrActions)["toolsEditContents"]->setStatusTextAndShortcut( tr("Edit contents of a frame"));
- (*scrActions)["toolsEditWithStoryEditor"]->setText( tr("Edit text in the Story Editor"));
+ (*scrActions)["toolsEditWithStoryEditor"]->setStatusTextAndShortcut( tr("Edit text in the Story Editor"));
(*scrActions)["toolsEyeDropper"]->setStatusTextAndShortcut( tr("Eye Dropper"));
(*scrActions)["toolsInsertArc"]->setStatusTextAndShortcut( tr("Insert an arc"));
(*scrActions)["toolsInsertBezier"]->setStatusTextAndShortcut( tr("Insert a bezier curve"));
diff --git a/scribus/plugins/barcodegenerator/barcode.cpp b/scribus/plugins/barcodegenerator/barcode.cpp
index 535094d..e08db59 100644
--- a/scribus/plugins/barcodegenerator/barcode.cpp
+++ b/scribus/plugins/barcodegenerator/barcode.cpp
@@ -22,6 +22,7 @@ void Barcode::languageChange()
{
m_actionInfo.name = "BarcodeGenerator";
m_actionInfo.text = tr("Barcode");
+ m_actionInfo.helpText = tr("To include Barcode.");
if (ScCore->haveGS())
{
m_actionInfo.menu = "Insert";
patchv3.diff (2,119 bytes)
diff --git a/scribus/actionmanager.cpp b/scribus/actionmanager.cpp
index 8ce1899..6c651e7 100644
--- a/scribus/actionmanager.cpp
+++ b/scribus/actionmanager.cpp
@@ -1679,7 +1679,7 @@ void ActionManager::languageChange()
(*scrActions)["toolsZoomIn"]->setTexts( tr("Zoom in"));
(*scrActions)["toolsZoomOut"]->setTexts( tr("Zoom out"));
(*scrActions)["toolsEditContents"]->setTexts( tr("Edit Contents of Frame"));
- (*scrActions)["toolsEditWithStoryEditor"]->setText( tr("Edit Text..."));
+ (*scrActions)["toolsEditWithStoryEditor"]->setText( tr("Edit text in the Story Editor"));
(*scrActions)["toolsLinkTextFrame"]->setTexts( tr("Link Text Frames"));
(*scrActions)["toolsUnlinkTextFrame"]->setTexts( tr("Unlink Text Frames"));
(*scrActions)["toolsUnlinkTextFrameWithTextCopy"]->setTexts( tr("Unlink Text Frame with Text Copy"));
@@ -1756,7 +1756,7 @@ void ActionManager::languageChange()
(*scrActions)["fileSave"]->setStatusTextAndShortcut( tr("Save the current document"));
(*scrActions)["toolsCopyProperties"]->setStatusTextAndShortcut( tr("Copy item properties"));
(*scrActions)["toolsEditContents"]->setStatusTextAndShortcut( tr("Edit contents of a frame"));
- (*scrActions)["toolsEditWithStoryEditor"]->setText( tr("Edit text in the Story Editor"));
+ (*scrActions)["toolsEditWithStoryEditor"]->setStatusTextAndShortcut( tr("Edit text in the Story Editor"));
(*scrActions)["toolsEyeDropper"]->setStatusTextAndShortcut( tr("Eye Dropper"));
(*scrActions)["toolsInsertArc"]->setStatusTextAndShortcut( tr("Insert an arc"));
(*scrActions)["toolsInsertBezier"]->setStatusTextAndShortcut( tr("Insert a bezier curve"));
diff --git a/scribus/plugins/barcodegenerator/barcode.cpp b/scribus/plugins/barcodegenerator/barcode.cpp
index 535094d..e08db59 100644
--- a/scribus/plugins/barcodegenerator/barcode.cpp
+++ b/scribus/plugins/barcodegenerator/barcode.cpp
@@ -22,6 +22,7 @@ void Barcode::languageChange()
{
m_actionInfo.name = "BarcodeGenerator";
m_actionInfo.text = tr("Barcode");
+ m_actionInfo.helpText = tr("Insert a barcode");
if (ScCore->haveGS())
{
m_actionInfo.menu = "Insert";
| ||||
| Patch | |||||
|
|
confirmed |
|
|
Tested the patch and works! |
|
|
Important: the patch fixes only the Story Editor message in the status bar. The barcode side is something more complicated and I don't have the needed knowledge to manage it. |
|
|
As with 1.5.0.svn (19394) Story Editor tooltip is shown correctly. |
|
|
As of r19401 Barcode status bar tooltip still *not* complete. |
|
|
I am really not sure about my patch (I can't installs Scribus right now). If you want to try it, go one. Otherwise, I might look at it later. |
|
|
patchv2.diff solved both issue and is tested on my computer. |
|
|
Thanks Chelen! Tested and works. I would change the help text to "Insert a barcode" (small cap) to keep consistency with all the other help texts in the lower part of the UI. |
|
|
solved |
|
|
Applied with a few modifications, thanks! |
|
|
Thanks everybody! Confirmed & closing |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2014-07-09 02:23 | FirasH | New Issue | |
| 2014-07-09 02:38 | FirasH | File Added: 12501.png | |
| 2014-07-09 14:13 | Kunda | Tag Attached: eas | |
| 2014-07-09 14:13 | Kunda | Tag Detached: eas | |
| 2014-07-09 14:13 | Kunda | Tag Attached: easyhack | |
| 2014-07-09 14:14 | Kunda | Note Added: 0032620 | |
| 2014-07-09 14:14 | Kunda | Status | new => confirmed |
| 2014-07-09 14:14 | Kunda | Target Version | => 1.5.1 |
| 2014-08-01 20:44 | Kunda | Tag Attached: tooltips | |
| 2014-08-01 21:11 | FirasH | File Added: actionmanager.cpp.patch | |
| 2014-08-01 21:12 | Kunda | Summary | Tooltips missing for Story Editor and Barcode => [PATCH] Tooltips missing for Story Editor and Barcode |
| 2014-08-01 21:12 | FirasH | Note Added: 0033138 | |
| 2014-08-01 21:14 | FirasH | Note Added: 0033139 | |
| 2014-08-01 21:20 | Kunda | Issue cloned: 0012585 | |
| 2014-08-01 21:24 | FirasH | Relationship added | related to 0012585 |
| 2014-08-02 14:24 | FirasH | Note Added: 0033152 | |
| 2014-08-03 23:10 | Kunda | Note Added: 0033164 | |
| 2014-08-07 15:13 | Chelen | File Added: patch.diff | |
| 2014-08-07 15:14 | Chelen | Note Added: 0033201 | |
| 2014-08-08 19:12 | Kunda | Summary | [PATCH] Tooltips missing for Story Editor and Barcode => [PATCH] Tooltips missing for Barcode |
| 2014-08-08 19:12 | Kunda | Description Updated | |
| 2014-08-20 07:02 | Chelen | File Added: patchv2.diff | |
| 2014-08-20 07:03 | Chelen | Note Added: 0033294 | |
| 2014-08-20 12:00 | FirasH | Note Added: 0033299 | |
| 2014-08-20 12:04 | Chelen | File Added: patchv3.diff | |
| 2014-08-20 12:04 | Chelen | Note Added: 0033300 | |
| 2014-08-23 22:10 | FirasH | Summary | [PATCH] Tooltips missing for Barcode => [TESTED-PATCH] Tooltip missing for Barcode |
| 2014-08-24 13:33 | jghali | Note Added: 0033337 | |
| 2014-08-24 13:33 | jghali | Status | confirmed => resolved |
| 2014-08-24 13:33 | jghali | Fixed in Version | => 1.5.0svn |
| 2014-08-24 13:33 | jghali | Resolution | open => fixed |
| 2014-08-24 13:33 | jghali | Assigned To | => jghali |
| 2014-08-31 13:28 | Kunda | Note Added: 0033393 | |
| 2014-08-31 13:28 | Kunda | Status | resolved => closed |
| 2014-09-26 17:53 | FirasH | Tag Detached: tooltips | |
| 2014-09-26 17:53 | FirasH | Tag Detached: easyhack | |
| 2015-02-23 18:04 | cbradney | Target Version | 1.5.1 => 1.5.0 |