View Issue Details

IDProjectCategoryView StatusLast Update
0012585ScribusUser Interfacepublic2014-10-07 23:23
ReporterKunda Assigned Tocbradney  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version1.5.0svn 
Fixed in Version1.5.0svn 
Summary0012585: [TESTED-PATCH] Statustip missing for Preview Quality & Visual Appearance
DescriptionStatustips missing for:
Preview Quality
Visual Appearance
Steps To Reproduce0) Launch Scribus, no opened document is necessary
1) Move the mouse pointer over the tools in the screenshot

No statustip is shown in the lower-left part of the UI as with the other tools.
Additional InformationScribus 1.5.0.svn (19393)
TagsNo tags attached.
Patch

Relationships

related to 0012501 closedjghali [TESTED-PATCH] Tooltip missing for Barcode 

Activities

Kunda

2014-08-01 21:20

updater  

toolbar.png (11,870 bytes)   
toolbar.png (11,870 bytes)   

FirasH

2014-08-01 21:54

developer  

actionmanager.cpp.patch (1,840 bytes)   
--- actionmanager2.cpp	2014-08-01 23:03:54.581561139 +0200
+++ actionmanager.cpp	2014-08-01 23:48:41.515811276 +0200
@@ -1755,9 +1755,9 @@
 	(*scrActions)["filePrint"]->setStatusTextAndShortcut( tr("Print the document"));
 	(*scrActions)["fileSave"]->setStatusTextAndShortcut( tr("Save the current document"));
 	(*scrActions)["toolsCopyProperties"]->setStatusTextAndShortcut( tr("Copy item properties"));
 	(*scrActions)["toolsEditContents"]->setStatusTextAndShortcut( tr("Edit contents of a frame"));
-	(*scrActions)["toolsEditWithStoryEditor"]->setText( tr("Edit text in the Story Editor"));
+	(*scrActions)["toolsEditWithStoryEditor"]->setStatusTextAndShortcut( tr("Edit text in the Story Editor"));
 	(*scrActions)["toolsEyeDropper"]->setStatusTextAndShortcut( tr("Eye Dropper"));
 	(*scrActions)["toolsInsertArc"]->setStatusTextAndShortcut( tr("Insert an arc"));
 	(*scrActions)["toolsInsertBezier"]->setStatusTextAndShortcut( tr("Insert a bezier curve"));
 	(*scrActions)["toolsInsertCalligraphicLine"]->setStatusTextAndShortcut( tr("Insert a calligraphic line"));
@@ -1784,8 +1784,11 @@
 	(*scrActions)["toolsRotate"]->setStatusTextAndShortcut( tr("Rotate an item"));
 	(*scrActions)["toolsSelect"]->setStatusTextAndShortcut( tr("Select an item"));
 	(*scrActions)["toolsUnlinkTextFrame"]->setStatusTextAndShortcut( tr("Unlink text frames"));
 	(*scrActions)["toolsZoom"]->setStatusTextAndShortcut( tr("Zoom in or out"));
+	(*scrActions)["viewPreviewMode"]->setStatusTextAndShortcut( tr("Enable preview mode"));
+	(*scrActions)["viewEditInPreview"]->setStatusTextAndShortcut( tr("Enable editing in preview mode"));
+	(*scrActions)["viewToggleCMS"]->setStatusTextAndShortcut( tr("Toggle color management system"));
 #ifdef HAVE_OSG
 	(*scrActions)["toolsPDFAnnot3D"]->setStatusTextAndShortcut( tr("Insert 3D annotation"));
 #endif
 
actionmanager.cpp.patch (1,840 bytes)   

FirasH

2014-08-01 21:55

developer   ~0033140

Last edited: 2014-08-01 21:56

Added .patch with status tooltip for Toggle CMS, Preview Mode, Edit in Preview Mode.
(Includes the .patch of 12501)

Kunda

2014-08-03 23:14

updater   ~0033165

The patch commit r19394 successfully committed most of the missing statusbar tooltips except:
Preview Quality
Visual Appearance

Also from ticket 0012501 statusbar tooltip missing:
Barcode

Kunda

2014-08-08 19:10

updater   ~0033211

2 statusbar tooltips still incomplete:
Preview Quality
Visual Appearance

Kunda

2014-08-25 16:17

updater   ~0033347

Barcode tooltip resolved (0012501)
Just this issue still remains now.

gpittman

2014-09-26 15:57

developer   ~0033838

Seems to be fixed, not sure when.

Kunda

2014-09-26 17:12

updater   ~0033839

gpittman, no in the latest revision 19541
I'm wondering if you read the bug report correctly.
The tooltips for: 'Preview Quality' and 'Visual Appearance' work but NOT in the tooltips in the lower left status bar.

gpittman

2014-09-26 19:47

developer   ~0033841

Since I don't have any icons for these functions in the lower status bar, why would I have tooltips there?
These icons are in the toolbar, and have tooltips.

Kunda

2014-09-27 03:15

updater   ~0033842

I see. So it sounds like you don't see the utility in having those 2 non-icons having status bar tooltips. Personally, I'm OK with either decision: with or without a status bar tooltip. What do others think ?

FirasH

2014-09-29 12:08

developer   ~0033845

Tested and attached the fix for Preview Quality and Visual Appearance.

FirasH

2014-09-29 12:10

developer  

12585.diff (632 bytes)   
Index: scribus/ui/viewtoolbar.cpp
===================================================================
--- scribus/ui/viewtoolbar.cpp	(revisione 19541)
+++ scribus/ui/viewtoolbar.cpp	(copia locale)
@@ -94,6 +94,8 @@
	previewQualitySwitcher->blockSignals(false);

	previewQualitySwitcher->setToolTip( tr("Select the image preview quality"));
+	previewQualitySwitcher->setStatusTip( tr("Select image preview quality"));
	visualMenu->setToolTip( tr("Select the visual appearance of the display. You can choose between normal and several color blindness forms"));
+	visualMenu->setStatusTip( tr("Select display visual appearance"));

 }
12585.diff (632 bytes)   

Kunda

2014-10-05 23:06

updater   ~0033907

Please apply patch. Thanks!

Kunda

2014-10-07 23:16

updater   ~0033924

Patch committed in r19555. Thanks Craig and FirasH!

Issue History

Date Modified Username Field Change
2014-08-01 21:20 Kunda New Issue
2014-08-01 21:20 Kunda File Added: toolbar.png
2014-08-01 21:20 Kunda Issue generated from: 0012501
2014-08-01 21:20 Kunda Tag Attached: tooltips
2014-08-01 21:24 FirasH Relationship added related to 0012501
2014-08-01 21:31 Kunda Summary [PATCH] Tooltips missing for Toolbar icons (Preview Mode etc..) => Tooltips missing for Toolbar icons (Preview Mode etc..)
2014-08-01 21:54 FirasH File Added: actionmanager.cpp.patch
2014-08-01 21:55 FirasH Note Added: 0033140
2014-08-01 21:56 FirasH Note Edited: 0033140
2014-08-01 21:57 FirasH Status new => confirmed
2014-08-01 21:57 FirasH Summary Tooltips missing for Toolbar icons (Preview Mode etc..) => [PATCH] Tooltips missing for Toolbar icons (Preview Mode etc..)
2014-08-02 08:14 cbradney Status confirmed => resolved
2014-08-02 08:14 cbradney Fixed in Version => 1.5.0svn
2014-08-02 08:14 cbradney Resolution open => fixed
2014-08-02 08:14 cbradney Assigned To => cbradney
2014-08-03 23:14 Kunda Note Added: 0033165
2014-08-08 19:10 Kunda Note Added: 0033211
2014-08-08 19:10 Kunda Status resolved => confirmed
2014-08-08 19:13 Kunda Summary [PATCH] Tooltips missing for Toolbar icons (Preview Mode etc..) => [PATCH] Tooltips missing for Toolbar icons (Preview Quality & Visual Appearance)
2014-08-08 19:13 Kunda Description Updated
2014-08-25 16:17 Kunda Note Added: 0033347
2014-09-26 15:57 gpittman Note Added: 0033838
2014-09-26 17:12 Kunda Note Added: 0033839
2014-09-26 19:47 gpittman Note Added: 0033841
2014-09-27 03:15 Kunda Note Added: 0033842
2014-09-29 12:08 FirasH Note Added: 0033845
2014-09-29 12:10 FirasH File Added: 12585.diff
2014-09-29 12:10 FirasH Summary [PATCH] Tooltips missing for Toolbar icons (Preview Quality & Visual Appearance) => [TESTED PATCH] Tooltips missing for Toolbar icons (Preview Quality & Visual Appearance)
2014-09-29 12:20 FirasH Summary [TESTED PATCH] Tooltips missing for Toolbar icons (Preview Quality & Visual Appearance) => [TESTED-PATCH] Statustip missing for Preview Quality & Visual Appearance
2014-09-29 12:20 FirasH Description Updated
2014-09-29 12:20 FirasH Steps to Reproduce Updated
2014-10-05 23:06 Kunda Note Added: 0033907
2014-10-07 20:40 cbradney Status confirmed => resolved
2014-10-07 23:16 Kunda Note Added: 0033924
2014-10-07 23:16 Kunda Status resolved => closed
2014-10-07 23:23 Kunda Tag Detached: tooltips