View Issue Details

IDProjectCategoryView StatusLast Update
0012767ScribusPDFpublic2014-10-14 20:07
Reporterwilliam Assigned Tojghali  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
PlatformIntel 64 bitOSFedora LinuxOS Version20
Product Version1.5.0svn 
Fixed in Version1.4.5.svn 
Summary0012767: [patches for 1.4 and 1.5] Fix wrong word in python error string
DescriptionThis patch from Juraj fixes an error message when you set an invalid resolution.
The error message says that 'compress' value is out of range, but it should say that the 'resolution' value is out of range.

TagsNo tags attached.
Patch

Activities

william

2014-10-11 16:49

updater  

0001-Fix-wrong-word-in-python-error-string-v144.patch (971 bytes)   
From 19473ee956ae36703f91970cfc156aa9deb4dcfd Mon Sep 17 00:00:00 2001
From: Juraj Fedel <wtxnh-scribus@yahoo.com.au>
Date: Sat, 11 Oct 2014 08:31:56 +0200
Subject: [PATCH 1/2] Fix wrong word in python error string

---
 scribus/plugins/scriptplugin/objpdffile.cpp |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/scribus/plugins/scriptplugin/objpdffile.cpp b/scribus/plugins/scriptplugin/objpdffile.cpp
index 494f538..29d56eb 100644
--- a/scribus/plugins/scriptplugin/objpdffile.cpp
+++ b/scribus/plugins/scriptplugin/objpdffile.cpp
@@ -657,7 +657,7 @@ static int PDFfile_setresolution(PDFfile *self, PyObject *value, void * /*closur
 	}
 	int n = PyInt_AsLong(value);
 	if (n<35 || n>4000) {
-		PyErr_SetString(PyExc_ValueError, "'compress' value must be in interval from 35 to 4000");
+		PyErr_SetString(PyExc_ValueError, "'resolution' value must be in interval from 35 to 4000");
 		return -1;
 	}
 	Py_DECREF(self->resolution);
-- 
1.7.2.3

william

2014-10-11 16:50

updater  

0001-Fix-wrong-word-in-python-error-string-v150.patch (971 bytes)   
From 2b956439d9a4d409a4ceca2e2d5dd4fab277ba46 Mon Sep 17 00:00:00 2001
From: Juraj Fedel <wtxnh-scribus@yahoo.com.au>
Date: Sat, 11 Oct 2014 08:31:56 +0200
Subject: [PATCH 1/2] Fix wrong word in python error string

---
 scribus/plugins/scriptplugin/objpdffile.cpp |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/scribus/plugins/scriptplugin/objpdffile.cpp b/scribus/plugins/scriptplugin/objpdffile.cpp
index 090413b..4aea73d 100644
--- a/scribus/plugins/scriptplugin/objpdffile.cpp
+++ b/scribus/plugins/scriptplugin/objpdffile.cpp
@@ -700,7 +700,7 @@ static int PDFfile_setresolution(PDFfile *self, PyObject *value, void * /*closur
 	}
 	int n = PyInt_AsLong(value);
 	if (n<35 || n>4000) {
-		PyErr_SetString(PyExc_ValueError, "'compress' value must be in interval from 35 to 4000");
+		PyErr_SetString(PyExc_ValueError, "'resolution' value must be in interval from 35 to 4000");
 		return -1;
 	}
 	Py_DECREF(self->resolution);
-- 
1.7.2.3

jghali

2014-10-11 20:11

administrator   ~0033984

Committed, thanks!

Issue History

Date Modified Username Field Change
2014-10-11 16:49 william New Issue
2014-10-11 16:49 william File Added: 0001-Fix-wrong-word-in-python-error-string-v144.patch
2014-10-11 16:50 william File Added: 0001-Fix-wrong-word-in-python-error-string-v150.patch
2014-10-11 20:11 jghali Note Added: 0033984
2014-10-11 20:11 jghali Status new => resolved
2014-10-11 20:11 jghali Fixed in Version => 1.4.5.svn
2014-10-11 20:11 jghali Resolution open => fixed
2014-10-11 20:11 jghali Assigned To => jghali
2014-10-14 20:07 cbradney Status resolved => closed