View Issue Details

IDProjectCategoryView StatusLast Update
0012803ScribusImport / Exportpublic2014-12-07 10:12
ReporterStephen Leibowitz Assigned Tojghali  
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Version1.5.0svn 
Fixed in Version1.5.0svn 
Summary0012803: Pct (Mac Pict) importer plugin
DescriptionDescription:
In scribus\plugins\import\pct\importpct.cpp is the following code segment (lines 1321 and 1322):
    if ((patternMode) && ((opCode != 0x0030) || (opCode != 0x0040) || (opCode != 0x0050)))
        setFillPattern(ite);

The second part of the if condition (the opCode part) always evaluates to true. The code is unclear to me, but I think it should be changed to:
    if ((patternMode) && ((opCode != 0x0030) && (opCode != 0x0040) && (opCode != 0x0050)))
        setFillPattern(ite);

Similarly (lines 1406 and 1407):
    if ((patternMode) && ((opCode != 0x0038) || (opCode != 0x0048) || (opCode != 0x0058)))
        setFillPattern(ite);
Should be changed to:
    if ((patternMode) && ((opCode != 0x0038) && (opCode != 0x0048) && (opCode != 0x0058)))
        setFillPattern(ite);
Additional InformationThe author of the code appears to be Franz Schmid.
TagsNo tags attached.
PatchNo

Activities

FirasH

2014-12-06 22:44

developer   ~0034282

jghali, I think there is a typo in Revision 19628, diff attached.

FirasH

2014-12-06 22:44

developer  

12803-Typo.diff (522 bytes)   
Index: scribus/plugins/import/pct/importpct.cpp
===================================================================
--- scribus/plugins/import/pct/importpct.cpp	(revisione 19657)
+++ scribus/plugins/import/pct/importpct.cpp	(copia locale)
@@ -1318,7 +1318,7 @@
	if (opCode > 0x0044)
		currRectType = 1;
	finishItem(ite);
-	if ((patternMode) && (opCode && 0x0030) && (opCode != 0x0040) && (opCode != 0x0050))
+	if ((patternMode) && (opCode != 0x0030) && (opCode != 0x0040) && (opCode != 0x0050))
		setFillPattern(ite);
 }

12803-Typo.diff (522 bytes)   

jghali

2014-12-06 23:23

administrator   ~0034283

Thanks, I fixed the fix!

FirasH

2014-12-07 10:12

developer   ~0034284

Perfect! Thanks!

Issue History

Date Modified Username Field Change
2014-11-03 22:56 Stephen Leibowitz New Issue
2014-11-17 08:00 jghali Status new => resolved
2014-11-17 08:00 jghali Fixed in Version => 1.5.0svn
2014-11-17 08:00 jghali Resolution open => fixed
2014-11-17 08:00 jghali Assigned To => jghali
2014-12-06 22:44 FirasH Note Added: 0034282
2014-12-06 22:44 FirasH File Added: 12803-Typo.diff
2014-12-06 23:23 jghali Note Added: 0034283
2014-12-07 10:12 FirasH Note Added: 0034284
2014-12-07 10:12 FirasH Status resolved => closed