View Issue Details

IDProjectCategoryView StatusLast Update
0012812ScribusPlug-inspublic2014-12-06 22:35
Reporterdcb Assigned Tojghali  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
PlatformallOSallOS Versionall
Product Version1.4.4 
Fixed in Version1.4.5.svn 
Summary0012812: import/pct/importpct.cpp: 2 * bad if test ?
Descriptionscribus-1.4.4/scribus/plugins/import/pct/importpct.cpp:1253:43: warning: logical 'or' of collectively exhaustive tests is always true [-Wlogical-op]

   if ((patternMode) && ((opCode != 0x0030) || (opCode != 0x0040) || (opCode != 0x0050)))

Suggest replace || with &&

scribus-1.4.4/scribus/plugins/import/pct/importpct.cpp:1338:43: warning: logical 'or' of collectively exhaustive tests is always true [-Wlogical-op]

Duplicate.
Steps To ReproduceTry compiling with a recent version of gcc or (better) clang.
TagsNo tags attached.
PatchNo

Activities

FirasH

2014-12-06 22:35

developer   ~0034281

Fixed in Revision 19629.

Issue History

Date Modified Username Field Change
2014-11-15 12:46 dcb New Issue
2014-11-17 08:00 jghali Status new => resolved
2014-11-17 08:00 jghali Fixed in Version => 1.4.5.svn
2014-11-17 08:00 jghali Resolution open => fixed
2014-11-17 08:00 jghali Assigned To => jghali
2014-12-06 22:35 FirasH Note Added: 0034281
2014-12-06 22:35 FirasH Status resolved => closed