View Issue Details

IDProjectCategoryView StatusLast Update
0013219ScribusGeneralpublic2015-08-17 07:34
ReporterFirasH Assigned Tocbradney  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version1.4.6.svn 
Fixed in Version1.4.6.svn 
Summary0013219: Backport 0012193 (Style Manager styles sorting) to 1.4.6.svn
DescriptionBackport 0012193 (Style Manager styles sorting) to 1.4.6.svn.
The attached patch is tested.
Additional Information1.4.6.svn (20239)
TagsNo tags attached.
PatchYes

Relationships

related to 0012193 closedcbradney Menu entries order in Paragraph Style interface 

Activities

FirasH

2015-07-09 15:53

developer  

13219-Patch.diff (1,257 bytes)   

diff --git a/scribus/scribus.cpp b/scribus/scribus.cpp
--- a/scribus/scribus.cpp
+++ b/scribus/scribus.cpp
@@ -518,10 +518,10 @@
 
 	// initializing style manager here too even it's not strictly a palette
 	styleManager = new StyleManager(this, "styleManager");
-	styleManager->addStyle(new SMLineStyle());
 	SMCharacterStyle *tmpCS = new SMCharacterStyle();
 	styleManager->addStyle(new SMParagraphStyle(tmpCS->tmpStyles()));
 	styleManager->addStyle(tmpCS);
+	styleManager->addStyle(new SMLineStyle());
 	connect( scrActions["editStyles"], SIGNAL(toggled(bool)), styleManager, SLOT(setPaletteShown(bool)) );
 	connect( styleManager, SIGNAL(paletteShown(bool)), scrActions["editStyles"], SLOT(setChecked(bool)));
 	styleManager->installEventFilter(this);
diff --git a/scribus/stylemanager.cpp b/scribus/stylemanager.cpp
--- a/scribus/stylemanager.cpp
+++ b/scribus/stylemanager.cpp
@@ -147,7 +147,8 @@
 		m_styleClassesPS[m_items.at(i)->typeNamePlural()] = m_items.at(i)->typeNameSingular();
 		m_styleClassesSP[m_items.at(i)->typeNameSingular()] = m_items.at(i)->typeNamePlural();
 	}
-	popupStrings.sort();
+	//13219, 12193 backport
+	//popupStrings.sort();
 	for (int i = 0; i < popupStrings.count(); ++i)
 		m_newPopup->addAction(popupStrings[i]);
 
13219-Patch.diff (1,257 bytes)   

FirasH

2015-07-27 21:36

developer   ~0035917

Thanks cbradney!
Committed in 1.4.6.svn (20283).

Issue History

Date Modified Username Field Change
2015-07-09 15:53 FirasH New Issue
2015-07-09 15:53 FirasH Relationship added related to 0012193
2015-07-09 15:53 FirasH File Added: 13219-Patch.diff
2015-07-22 16:37 Kunda Summary Backport 0012193 (Style Manager styles sorting) to 1.4.6.svn => [Patch] Backport 0012193 (Style Manager styles sorting) to 1.4.6.svn
2015-07-27 20:35 cbradney Status new => resolved
2015-07-27 20:35 cbradney Fixed in Version => 1.4.6.svn
2015-07-27 20:35 cbradney Resolution open => fixed
2015-07-27 20:35 cbradney Assigned To => cbradney
2015-07-27 21:36 FirasH Note Added: 0035917
2015-07-27 21:36 FirasH Status resolved => closed
2015-08-17 07:34 jghali Summary [Patch] Backport 0012193 (Style Manager styles sorting) to 1.4.6.svn => Backport 0012193 (Style Manager styles sorting) to 1.4.6.svn