View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0013243 | Scribus | Story Editor / Text Frames | public | 2015-07-18 12:48 | 2015-11-22 13:55 |
Reporter | ire | Assigned To | jghali | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Platform | intel | OS | windows | OS Version | windows7 |
Product Version | 1.5.0 | ||||
Fixed in Version | 1.5.1svn | ||||
Summary | 0013243: Attach text to path action is not enabled correctly | ||||
Description | in version 1.5.1 svn I can`t find the option to aach text to a path | ||||
Steps To Reproduce | create a text Frame write some text create a bezier highlight both try to attach text to path How can I do this? | ||||
Tags | No tags attached. | ||||
Patch | Yes | ||||
|
Select path and Text Frame, then Item > Path Tools > Attach Text to Path. |
|
I use version 1.5.0 svn 64 bit!!! Hy, thanks for your answer. So I tried. But when choosing Item > Path Tools the option Attach Text to Path is greyed out. Then I installed Version 1.5.0 32-bit and tried: when using version 1.5.0 svn 32-bit and selecting text frame first, then bezier, I can attach text to path Then I reinstalled Version 1.5.0 64 bit and tried: it didn`t work the first time, then all the following times when choosing the text frame first |
|
ire you're right. If you select a Text Frame then a Path the option is enabled. If you select a Path then a Text Frame the option is disabled. |
|
Attached a patch which fixes selection order issue. Tested and works. |
|
13243-Patch.diff (825 bytes)
diff --git a/scribus/appmodehelper.cpp b/scribus/appmodehelper.cpp --- a/scribus/appmodehelper.cpp +++ b/scribus/appmodehelper.cpp @@ -854,7 +854,8 @@ PageItem* it=doc->m_Selection->itemAt(1); if (currItem==it) it=doc->m_Selection->itemAt(0); - if ((currItem->asTextFrame() || it->asTextFrame()) && (it->asPolygon() || it->asPolyLine())) + //13243: First Text Frame is selected then Path or vice-versa + if (((currItem->asTextFrame()) && (it->asPolygon() || it->asPolyLine())) || ((it->asTextFrame()) && (currItem->asPolygon() || currItem->asPolyLine()))) { if ((currItem->nextInChain() == 0) && (currItem->prevInChain() == 0) && (it->nextInChain() == 0) && (it->prevInChain() == 0) && (!currItem->isGroup()) && (!it->isGroup())) (*a_scrActions)["itemAttachTextToPath"]->setEnabled(true); |
|
Thanks FirasH. I took however the liberty to rewrite corresponding code to make it more readable. |
|
Fixed by FirasH and jghali in r20276 Thanks! Closing |
Date Modified | Username | Field | Change |
---|---|---|---|
2015-07-18 12:48 | ire | New Issue | |
2015-07-18 13:17 | FirasH | Note Added: 0035827 | |
2015-07-18 13:17 | FirasH | Status | new => resolved |
2015-07-18 13:17 | FirasH | Resolution | open => no change required |
2015-07-18 13:17 | FirasH | Assigned To | => FirasH |
2015-07-18 13:17 | FirasH | Assigned To | FirasH => |
2015-07-18 18:29 | ire | Note Added: 0035838 | |
2015-07-18 18:58 | ire | Note Edited: 0035838 | |
2015-07-18 19:05 | ire | Note Edited: 0035838 | |
2015-07-18 19:13 | FirasH | Note Added: 0035841 | |
2015-07-18 19:13 | FirasH | Status | resolved => confirmed |
2015-07-18 19:13 | FirasH | Resolution | no change required => open |
2015-07-18 21:17 | FirasH | Note Added: 0035842 | |
2015-07-18 21:17 | FirasH | Patch | No => Yes |
2015-07-18 21:18 | FirasH | File Added: 13243-Patch.diff | |
2015-07-20 18:03 | Kunda | Summary | attach text to path => [Patch] attach text to path |
2015-07-25 20:42 | jghali | Summary | [Patch] attach text to path => [Patch] Attach text to path action is not enabled correctly |
2015-07-25 20:45 | jghali | Note Added: 0035897 | |
2015-07-25 20:45 | jghali | Status | confirmed => resolved |
2015-07-25 20:45 | jghali | Fixed in Version | => 1.5.1svn |
2015-07-25 20:45 | jghali | Resolution | open => fixed |
2015-07-25 20:45 | jghali | Assigned To | => jghali |
2015-07-26 05:29 | Kunda | Note Added: 0035899 | |
2015-07-26 05:29 | Kunda | Status | resolved => closed |
2015-09-17 20:08 | Kunda | Category | Story Editor / Text Frames => Story Ed/Txt Frames |
2015-09-17 20:12 | Kunda | Category | Story Ed/Txt Frames => Story Editor / Text Frames |
2015-11-22 13:55 | jghali | Summary | [Patch] Attach text to path action is not enabled correctly => Attach text to path action is not enabled correctly |