View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0013570 | Scribus | General | public | 2015-11-26 19:28 | 2015-11-27 17:08 |
Reporter | FirasH | Assigned To | jghali | ||
Priority | normal | Severity | minor | Reproducibility | N/A |
Status | closed | Resolution | fixed | ||
Product Version | 1.5.1svn | ||||
Fixed in Version | 1.5.1svn | ||||
Summary | 0013570: Some naming cleaning in prefs_documentsetupbase.ui | ||||
Description | Just some order in Objects names in the.ui file. | ||||
Additional Information | 1.5.1.svn (20584) | ||||
Tags | No tags attached. | ||||
Patch | Yes | ||||
|
13570-Patch.diff (3,893 bytes)
diff --git a/scribus/ui/prefs_documentsetupbase.ui b/scribus/ui/prefs_documentsetupbase.ui --- a/scribus/ui/prefs_documentsetupbase.ui +++ b/scribus/ui/prefs_documentsetupbase.ui @@ -40,13 +40,13 @@ <property name="currentIndex"> <number>0</number> </property> - <widget class="QWidget" name="tab"> + <widget class="QWidget" name="sizeTab"> <attribute name="title"> <string>Size</string> </attribute> <layout class="QVBoxLayout" name="verticalLayout_4"> <item> - <widget class="QLabel" name="label_2"> + <widget class="QLabel" name="pageSizeTitleLabel"> <property name="font"> <font> <pointsize>13</pointsize> @@ -79,7 +79,7 @@ </widget> </item> <item row="0" column="1"> - <layout class="QHBoxLayout" name="horizontalLayout_3"> + <layout class="QHBoxLayout" name="pageSizeLayout"> <item> <widget class="QComboBox" name="pageSizeComboBox"/> </item> @@ -178,13 +178,13 @@ </item> </layout> </widget> - <widget class="QWidget" name="tab_4"> + <widget class="QWidget" name="layoutTab"> <attribute name="title"> <string>Layout</string> </attribute> <layout class="QVBoxLayout" name="verticalLayout_6"> <item> - <widget class="QLabel" name="label_7"> + <widget class="QLabel" name="pageLayoutTitleLabel"> <property name="font"> <font> <pointsize>13</pointsize> @@ -205,7 +205,7 @@ </widget> </item> <item> - <layout class="QFormLayout" name="formLayout_2"> + <layout class="QFormLayout" name="pageLayoutLayout"> <item row="4" column="0"> <widget class="QLabel" name="layoutFirstPageIsLabel"> <property name="text"> @@ -283,7 +283,7 @@ </item> </layout> </widget> - <widget class="QWidget" name="tab_2"> + <widget class="QWidget" name="marginsTab"> <attribute name="title"> <string>Margins && Bleeds</string> </attribute> @@ -316,7 +316,7 @@ <number>0</number> </property> <item> - <widget class="QLabel" name="label_8"> + <widget class="QLabel" name="marginsTitleLabel"> <property name="font"> <font> <pointsize>13</pointsize> @@ -390,7 +390,7 @@ </spacer> </item> <item> - <widget class="QLabel" name="label_10"> + <widget class="QLabel" name="bleedsTitleLabel"> <property name="font"> <font> <pointsize>13</pointsize> @@ -452,7 +452,7 @@ </item> </layout> </widget> - <widget class="QWidget" name="tab_3"> + <widget class="QWidget" name="saveTab"> <attribute name="title"> <string>Saving && Undo</string> </attribute> @@ -481,7 +481,7 @@ </spacer> </item> <item> - <widget class="QLabel" name="label_4"> + <widget class="QLabel" name="autosaveTitleLable"> <property name="font"> <font> <pointsize>13</pointsize> @@ -556,7 +556,7 @@ </spacer> </item> <item> - <widget class="QLabel" name="label_5"> + <widget class="QLabel" name="undoRedoTitleLabel"> <property name="font"> <font> <pointsize>13</pointsize> @@ -586,7 +586,7 @@ <item> <layout class="QHBoxLayout" name="horizontalLayout_2"> <item> - <widget class="QLabel" name="label_3"> + <widget class="QLabel" name="undoLengthLabel"> <property name="text"> <string>Action History Length:</string> </property> |
|
There is no real need naming widgets which are not used explicitly in user code. |
|
I committed your patch. Thanks, however as said such cleanup is not necessary unless the widgets names are explicitly used in scribus code. |
|
jghali, question: isn't code readability a good thing ? Those labels are mentioning what part of the UI they are related to, right? |
|
Kunda, those labels do not affect directly core source code and practically do not improve any side of Scribus. Just trying to guess the basics behind Scribus .ui files. Only some cleanup in the process, nothing more. btw thanks jghali! |
|
Firash, I get it AND your guesses help others want to understand the basics behind Scribus .ui files as well. code committed in r20589 Closing |
Date Modified | Username | Field | Change |
---|---|---|---|
2015-11-26 19:28 | FirasH | New Issue | |
2015-11-26 19:29 | FirasH | File Added: 13570-Patch.diff | |
2015-11-26 19:39 | jghali | Note Added: 0037696 | |
2015-11-26 23:13 | jghali | Note Added: 0037697 | |
2015-11-26 23:13 | jghali | Status | new => resolved |
2015-11-26 23:13 | jghali | Fixed in Version | => 1.5.1svn |
2015-11-26 23:13 | jghali | Resolution | open => fixed |
2015-11-26 23:13 | jghali | Assigned To | => jghali |
2015-11-27 14:19 | Kunda | Note Added: 0037703 | |
2015-11-27 14:38 | FirasH | Note Added: 0037706 | |
2015-11-27 17:08 | Kunda | Note Added: 0037707 | |
2015-11-27 17:08 | Kunda | Status | resolved => closed |