View Issue Details

IDProjectCategoryView StatusLast Update
0016493ScribusUser Interfacepublic2021-03-21 14:51
Reporterbubu Assigned Tojghali  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version1.5.7.svn 
Fixed in Version1.5.7.svn 
Summary0016493: Unify margins and spacing for properties palette, set 2
DescriptionI propose second set of trivial margin/spacing adjustment for properties palette:
- Image
- Group (no visual changes)
- Table

Please review it. Thanks.
TagsNo tags attached.
PatchNo

Relationships

child of 0013906 acknowledged Metabug: UI enhancement proposals (1.5.x.svn) 

Activities

bubu

2021-02-26 21:53

reporter  

0001-Unify-margins-and-spacing-for-properties-palette-set.patch (10,313 bytes)   
From bdc3d70ec85ee7d0a9320898c99bb937e425190f Mon Sep 17 00:00:00 2001
Message-Id: <bdc3d70ec85ee7d0a9320898c99bb937e425190f.1614376047.git.bubu@ujevangelizacio.hu>
From: =?UTF-8?q?Gyuris=20Gell=C3=A9rt?= <bubu@ujevangelizacio.hu>
Date: Fri, 26 Feb 2021 22:47:18 +0100
Subject: [PATCH] Unify margins and spacing for properties palette, set 2

---
 scribus/ui/propertiespalette_groupbase.ui |  2 +-
 scribus/ui/propertiespalette_imagebase.ui | 63 +++++++++++++--
 scribus/ui/propertiespalette_tablebase.ui | 98 ++++++++++++++++++++++-
 3 files changed, 155 insertions(+), 8 deletions(-)

diff --git a/scribus/ui/propertiespalette_groupbase.ui b/scribus/ui/propertiespalette_groupbase.ui
index b025967a3..60d919f1a 100644
--- a/scribus/ui/propertiespalette_groupbase.ui
+++ b/scribus/ui/propertiespalette_groupbase.ui
@@ -47,7 +47,7 @@
      <property name="sizeHint" stdset="0">
       <size>
        <width>20</width>
-       <height>40</height>
+       <height>0</height>
       </size>
      </property>
     </spacer>
diff --git a/scribus/ui/propertiespalette_imagebase.ui b/scribus/ui/propertiespalette_imagebase.ui
index c26539017..74d14f733 100644
--- a/scribus/ui/propertiespalette_imagebase.ui
+++ b/scribus/ui/propertiespalette_imagebase.ui
@@ -15,22 +15,25 @@
   </property>
   <layout class="QVBoxLayout" name="verticalLayout">
    <property name="spacing">
-    <number>2</number>
+    <number>3</number>
    </property>
    <property name="leftMargin">
-    <number>2</number>
+    <number>3</number>
    </property>
    <property name="topMargin">
-    <number>2</number>
+    <number>3</number>
    </property>
    <property name="rightMargin">
-    <number>2</number>
+    <number>3</number>
    </property>
    <property name="bottomMargin">
-    <number>2</number>
+    <number>3</number>
    </property>
    <item>
     <layout class="QGridLayout" name="gridLayout">
+     <property name="spacing">
+      <number>3</number>
+     </property>
      <item row="2" column="0">
       <widget class="QLabel" name="xposImgLabel">
        <property name="text">
@@ -116,6 +119,21 @@
       <string>Scaling</string>
      </property>
      <layout class="QGridLayout" name="gridLayout_2">
+      <property name="leftMargin">
+       <number>6</number>
+      </property>
+      <property name="topMargin">
+       <number>6</number>
+      </property>
+      <property name="rightMargin">
+       <number>6</number>
+      </property>
+      <property name="bottomMargin">
+       <number>6</number>
+      </property>
+      <property name="spacing">
+       <number>3</number>
+      </property>
       <item row="2" column="2" rowspan="2">
        <widget class="LinkButton" name="keepImageWHRatioButton">
         <property name="maximumSize">
@@ -282,6 +300,21 @@
       <string>Color Management</string>
      </property>
      <layout class="QGridLayout" name="gridLayout_4">
+      <property name="leftMargin">
+       <number>6</number>
+      </property>
+      <property name="topMargin">
+       <number>6</number>
+      </property>
+      <property name="rightMargin">
+       <number>6</number>
+      </property>
+      <property name="bottomMargin">
+       <number>6</number>
+      </property>
+      <property name="spacing">
+       <number>3</number>
+      </property>
       <item row="0" column="0">
        <widget class="QLabel" name="inputProfLabel">
         <property name="text">
@@ -331,6 +364,21 @@
       <string>PDF Compression</string>
      </property>
      <layout class="QGridLayout" name="gridLayout_3">
+      <property name="leftMargin">
+       <number>6</number>
+      </property>
+      <property name="topMargin">
+       <number>6</number>
+      </property>
+      <property name="rightMargin">
+       <number>6</number>
+      </property>
+      <property name="bottomMargin">
+       <number>6</number>
+      </property>
+      <property name="spacing">
+       <number>3</number>
+      </property>
       <item row="0" column="0">
        <widget class="QLabel" name="compressionMethodLabel">
         <property name="text">
@@ -376,6 +424,9 @@
    </item>
    <item>
     <layout class="QHBoxLayout" name="horizontalLayout">
+     <property name="spacing">
+      <number>3</number>
+     </property>
      <item>
       <widget class="QToolButton" name="imgEffectsButton">
        <property name="sizePolicy">
@@ -412,7 +463,7 @@
      <property name="sizeHint" stdset="0">
       <size>
        <width>20</width>
-       <height>40</height>
+       <height>0</height>
       </size>
      </property>
     </spacer>
diff --git a/scribus/ui/propertiespalette_tablebase.ui b/scribus/ui/propertiespalette_tablebase.ui
index 7d4366487..48d96dc0b 100644
--- a/scribus/ui/propertiespalette_tablebase.ui
+++ b/scribus/ui/propertiespalette_tablebase.ui
@@ -14,12 +14,42 @@
    <string notr="true">Form</string>
   </property>
   <layout class="QVBoxLayout" name="verticalLayout_2">
+   <property name="spacing">
+    <number>3</number>
+   </property>
+   <property name="leftMargin">
+    <number>3</number>
+   </property>
+   <property name="topMargin">
+    <number>3</number>
+   </property>
+   <property name="rightMargin">
+    <number>3</number>
+   </property>
+   <property name="bottomMargin">
+    <number>3</number>
+   </property>
    <item>
     <widget class="QGroupBox" name="groupBox">
      <property name="title">
       <string>Styles</string>
      </property>
      <layout class="QGridLayout" name="gridLayout">
+      <property name="leftMargin">
+       <number>6</number>
+      </property>
+      <property name="topMargin">
+       <number>6</number>
+      </property>
+      <property name="rightMargin">
+       <number>6</number>
+      </property>
+      <property name="bottomMargin">
+       <number>6</number>
+      </property>
+      <property name="spacing">
+       <number>3</number>
+      </property>
       <item row="0" column="0">
        <widget class="QLabel" name="labelTable">
         <property name="text">
@@ -101,10 +131,34 @@
       <string>Fill</string>
      </property>
      <layout class="QVBoxLayout" name="verticalLayout_3">
+      <property name="spacing">
+       <number>3</number>
+      </property>
+      <property name="leftMargin">
+       <number>6</number>
+      </property>
+      <property name="topMargin">
+       <number>6</number>
+      </property>
+      <property name="rightMargin">
+       <number>6</number>
+      </property>
+      <property name="bottomMargin">
+       <number>6</number>
+      </property>
       <item>
        <layout class="QHBoxLayout" name="fillLayout1" stretch="0,0">
+        <property name="spacing">
+         <number>3</number>
+        </property>
         <item>
          <layout class="QFormLayout" name="fillLayout1_1">
+          <property name="horizontalSpacing">
+           <number>3</number>
+          </property>
+          <property name="verticalSpacing">
+           <number>3</number>
+          </property>
           <item row="0" column="0">
            <widget class="QLabel" name="fillColorLabel">
             <property name="enabled">
@@ -138,6 +192,12 @@
         </item>
         <item>
          <layout class="QFormLayout" name="fillLayout1_2">
+          <property name="horizontalSpacing">
+           <number>3</number>
+          </property>
+          <property name="verticalSpacing">
+           <number>3</number>
+          </property>
           <item row="0" column="0">
            <widget class="QLabel" name="fillShadeLabel">
             <property name="enabled">
@@ -192,10 +252,31 @@
       <string>Borders</string>
      </property>
      <layout class="QVBoxLayout" name="verticalLayout">
+      <property name="spacing">
+       <number>3</number>
+      </property>
+      <property name="leftMargin">
+       <number>6</number>
+      </property>
+      <property name="topMargin">
+       <number>6</number>
+      </property>
+      <property name="rightMargin">
+       <number>6</number>
+      </property>
+      <property name="bottomMargin">
+       <number>6</number>
+      </property>
       <item>
        <layout class="QHBoxLayout" name="bordesLayout1">
+        <property name="spacing">
+         <number>3</number>
+        </property>
         <item>
          <layout class="QVBoxLayout" name="bordersLayout1_1">
+          <property name="spacing">
+           <number>3</number>
+          </property>
           <item alignment="Qt::AlignTop">
            <widget class="QPushButton" name="addBorderLineButton">
             <property name="enabled">
@@ -315,11 +396,20 @@
       </item>
       <item>
        <layout class="QHBoxLayout" name="bordersLayout2" stretch="0,0">
+        <property name="spacing">
+         <number>3</number>
+        </property>
         <item>
          <layout class="QFormLayout" name="bordersLayout2_1">
           <property name="fieldGrowthPolicy">
            <enum>QFormLayout::ExpandingFieldsGrow</enum>
           </property>
+          <property name="horizontalSpacing">
+           <number>3</number>
+          </property>
+          <property name="verticalSpacing">
+           <number>3</number>
+          </property>
           <item row="0" column="0">
            <widget class="QLabel" name="borderLineWidthLabel">
             <property name="enabled">
@@ -388,6 +478,12 @@
         </item>
         <item>
          <layout class="QFormLayout" name="bordersLayout2_2">
+          <property name="horizontalSpacing">
+           <number>3</number>
+          </property>
+          <property name="verticalSpacing">
+           <number>3</number>
+          </property>
           <item row="0" column="0">
            <widget class="QLabel" name="borderLineStyleLabel">
             <property name="enabled">
@@ -479,7 +575,7 @@
      <property name="sizeHint" stdset="0">
       <size>
        <width>20</width>
-       <height>40</height>
+       <height>0</height>
       </size>
      </property>
     </spacer>
-- 
2.27.0

table_group_image.gif (89,581 bytes)   
table_group_image.gif (89,581 bytes)   

jghali

2021-02-27 21:48

administrator   ~0048881

Applied, thanks!

FirasH

2021-03-21 14:51

developer   ~0048977

Thanks!
Fixed in 1.5.7.svn (24532)

Issue History

Date Modified Username Field Change
2021-02-26 21:53 bubu New Issue
2021-02-26 21:53 bubu File Added: 0001-Unify-margins-and-spacing-for-properties-palette-set.patch
2021-02-26 21:53 bubu File Added: table_group_image.gif
2021-02-27 21:48 jghali Note Added: 0048881
2021-02-27 21:48 jghali Assigned To => jghali
2021-02-27 21:48 jghali Status new => resolved
2021-02-27 21:48 jghali Resolution open => fixed
2021-02-27 21:48 jghali Fixed in Version => 1.5.7.svn
2021-03-01 13:55 PeterBenedek Relationship added child of 0013906
2021-03-21 14:51 FirasH Status resolved => closed
2021-03-21 14:51 FirasH Note Added: 0048977