View Issue Details

IDProjectCategoryView StatusLast Update
0002864ScribusIntegrationpublic2005-11-28 17:45
ReporterStanislav Brabec Assigned Toplinnell 
PrioritynormalSeverityfeatureReproducibilityN/A
Status closedResolutionfixed 
Product Version1.2.3 
Fixed in Version1.2.4cvs 
Summary0002864: Patch to read /usr/local/share/color/icc
DescriptionAttached patch adds /usr/local/share/color/icc to ICC profile search path. For more see http://bugs.freestandards.org/show_bug.cgi?id=77

Maybe scribus should accept symlinked profiles, but it is not a part of this patch.
TagsNo tags attached.
Patch

Activities

2005-11-25 11:41

 

scribus-openicc-local.patch (1,234 bytes)   
See http://bugs.freestandards.org/show_bug.cgi?id=77 for further discussion.

--- README
+++ README
@@ -23,9 +23,10 @@
 under color management. Grey scale icc profiles in images are not supported in this release.
 
 Scribus 1.2.3 also supports the proposed OpenIcc standard icc profile 
-locations: $home/.color/icc and /usr/share/color/icc/ under linux. Scribus
-will automatically detect them in these locations. Some distro neutral rpms
-for installing profiles are available on www.scribus.net.
+locations: $home/.color/icc, /usr/local/share/color/icc/ and
+/usr/share/color/icc/ under linux. Scribus will automatically detect
+them in these locations. Some distro neutral rpms for installing
+profiles are available on www.scribus.net.
 
 When you now open old documents Scribus will convert all Font Names
 automatically.
--- scribus/util.cpp
+++ scribus/util.cpp
@@ -2387,6 +2387,7 @@
 #elif defined(Q_WS_X11)
 	iccProfDirs.append(QDir::homeDirPath()+"/color/icc/");
 	iccProfDirs.append(QDir::homeDirPath()+"/.color/icc/");
+	iccProfDirs.append("/usr/local/share/color/icc/");
 	iccProfDirs.append("/usr/share/color/icc/");
 #elif defined(_WIN32)
 	// On Windows it's more complicated, profiles location depends on OS version
scribus-openicc-local.patch (1,234 bytes)   

plinnell

2005-11-26 23:21

viewer   ~0007542

Following a long thread on openicc list on freedesktop, we are adding /usr/local to the search path. It's a good idea and its friendly to BSD too.

Symlinks are another matter. After wrestling with defoma on debian, fonts symlinked and symlinked paths - I will take a pass on that :-)

Thanks for the patch and taking the time to file the bug.

plinnell

2005-11-26 23:22

viewer   ~0007543

Applied to both branches.

Issue History

Date Modified Username Field Change
2005-11-25 11:41 Stanislav Brabec New Issue
2005-11-25 11:41 Stanislav Brabec File Added: scribus-openicc-local.patch
2005-11-25 14:04 plinnell Status new => assigned
2005-11-25 14:04 plinnell Assigned To => plinnell
2005-11-26 23:21 plinnell Note Added: 0007542
2005-11-26 23:22 plinnell Status assigned => resolved
2005-11-26 23:22 plinnell Fixed in Version => 1.2.4cvs
2005-11-26 23:22 plinnell Resolution open => fixed
2005-11-26 23:22 plinnell Note Added: 0007543
2005-11-28 17:45 plinnell Status resolved => closed