View Issue Details

IDProjectCategoryView StatusLast Update
0003102ScribusUser Interfacepublic2007-12-16 15:43
Reportercananian Assigned Toavox  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Platformi386OSDebian LinuxOS Versionsid
Product Version1.3.4cvs 
Fixed in Version1.3.5svn 
Summary0003102: Deleting colors does not always update paragraph/line styles.
Description1. In the "edit colors" dialog, there's the option to reassign a deleted color -- which is a very nice feature! -- but it doesn't always work correctly. For example, the color reassignment isn't applied to paragraph styles, and only "sometimes" seems to be applied to line styles. Further, when you then go to the "Edit Styles" dialog to update the colors in the paragraph styles, the new styles don't immediately apply to the text frames; you often have to go and manually reselect the style for the text frame in order to make the new style apply properly.

2. Also, there seems to be a suble renaming bug: if I've got a colors named 'Foreground' and 'Background', I might want to swap them as follows: duplicate 'Background' and Foreground to get 'copy of background' and 'copy of foreground'. Then delete 'Foreground', reassigning its color to 'copy of Background'. Then delete 'Background', reassigning its color to 'copy of foreground'. Now rename 'copy of foreground' to 'Foreground' and 'copy of background' to 'Background' (whoops -- renaming doesn't work, either: it creates a new color with the new name, without deleting the old name. Oh, well, delete 'copy of background' now and assign it to 'Background', etc).

The problem is: this doesn't work! It seems that Scribus tries to combine all the operations into one "action" which is applied when you hit "ok" -- but the summary Scribus uses for this case is "rename Background to Background, and Foreground to Foreground" -- ie, the colors are not swapped as we'd wanted. Also, all the paragraph and line styles (which we noted above were not properly updated) still point to the text strings 'Foreground' and 'Background' -- so they won't be swapped either.
TagsNo tags attached.
Patch

Relationships

has duplicate 0005459 closedjghali After removing colours and replacing with a new one, colours from linestyles are not replaced with the new colour 

Activities

mhanski

2006-05-02 21:03

developer   ~0010807

tested with 1.2.4.99cvs from April 3 on kubuntu:

1. Works fine for paragraph and line styles


2. will be tested as soon as I find enough time to try to understand what you mean:)

cananian

2006-05-07 02:23

reporter   ~0011040

For scribus 1.3.3.1 (probably still a bug in 1.2.x as well)
1. Create a new color "MyRedColor"
2. Create a line style "MyRedLine" with color "MyRedColor"
3. Create a paragraph style "MyRedText" with color "MyRedColor"
4. create box, style the line as "MyRedLine"; create some text, styled as "MyRedText".
5. Create a new color "MyBlueColor"
6. In the Edit Colors dialog, delete "MyRedColor". It will ask if you'd like to replace the color; select "MyBlueColor".
7. Look at your document: the text is blue (good), but the line has disappeared.
8. But open the Paragraph Styles property, and look at "MyRedText" -- the color there is still listed as "MyRedColor" (which was supposed to be deleted!)
9. If you open up "MyRedLine" in the Line Styles property, you'll find it is still trying to use "MyRedColor" as well.

continuing to my second point:
10. Workaround the first bug by manually re-selecting "MyBlueColor" for both "MyRedLine" and "MyRedText".
11. Create a new "MyRedColor" color. Now we're going to try to make our blue stuff red again by switching the colors assigned to "MyBlueColor" and "MyRedColor":
12. Duplicate both "MyBlueColor" (creating "Copy of MyBlueColor") and "MyRedColor" (creating "Copy of MyRedColor")
13. Delete "MyRedColor", reassigning color to "Copy of MyBlueColor"
14. Delete "MyBlueColor", reassigning color to "Copy of MyRedColor"
15. Rename "Copy of MyBlueColor" to "MyBlueColor" by clicking "Edit" and deleting the first 8 characters of the color name.
16. Rename "Copy of MyRedColor" to "MyRedColor" by clicking "Edit" and deleting the first 8 characters of the color name.
17. What we expect: the blue stuff is now "MyRedColor". Actual result: all the colors disappear (bug 1) -- and the color in the paragraph/line styles is still "MyBlueColor" (bug 2)

jo-hannes

2006-12-21 11:07

developer   ~0014140

seems to be fixed.

cbradney

2006-12-25 23:38

administrator   ~0014227

Certainly still exists in 1.3.4. The line style is not updated.

avox

2007-04-02 00:52

administrator   ~0015702

Works now for text styles

avox

2007-04-02 00:55

administrator   ~0015703

I'll postpone the remaining linestyle fix to after 1.3.4, if noone cries out.

cbradney

2007-04-02 15:35

administrator   ~0015708

Tested ok for para & char styles

christoph_s

2007-12-16 15:43

administrator   ~0018319

Tested, fixed. Thanks.

Issue History

Date Modified Username Field Change
2006-01-25 19:13 cananian New Issue
2006-04-15 16:52 mhanski Category Styles => User Interface
2006-04-28 15:47 mhanski Description Updated
2006-05-02 21:03 mhanski Note Added: 0010807
2006-05-02 21:03 mhanski Status new => feedback
2006-05-07 02:23 cananian Note Added: 0011040
2006-12-21 11:07 jo-hannes Note Added: 0014140
2006-12-21 11:07 jo-hannes Status feedback => resolved
2006-12-21 11:07 jo-hannes Resolution open => fixed
2006-12-21 11:07 jo-hannes Product Version 1.2.4.1 => 1.3.4cvs
2006-12-25 23:38 cbradney Status resolved => feedback
2006-12-25 23:38 cbradney Resolution fixed => reopened
2006-12-25 23:38 cbradney Note Added: 0014227
2006-12-25 23:43 cbradney Relationship added child of 0003964
2007-03-04 23:48 cbradney Status feedback => assigned
2007-03-04 23:48 cbradney Assigned To => avox
2007-03-04 23:49 cbradney Assigned To avox =>
2007-03-05 00:15 cbradney Assigned To => avox
2007-03-16 13:36 jghali Relationship added has duplicate 0005459
2007-04-02 00:52 avox Note Added: 0015702
2007-04-02 00:55 avox Note Added: 0015703
2007-04-02 00:56 avox Relationship deleted child of 0003964
2007-04-02 15:35 cbradney Note Added: 0015708
2007-12-14 23:25 cbradney Status assigned => resolved
2007-12-14 23:25 cbradney Fixed in Version => 1.3.5svn
2007-12-14 23:25 cbradney Resolution reopened => fixed
2007-12-16 15:43 christoph_s Status resolved => closed
2007-12-16 15:43 christoph_s Note Added: 0018319