View Issue Details

IDProjectCategoryView StatusLast Update
0003651ScribusInternalpublic2006-11-07 14:30
Reportermkoren Assigned Tocbradney  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Platformx86OSDebian LinuxOS VersionStable/Testing
Product Version1.3.3.1 
Fixed in Version1.3.3.5cvs 
Summary0003651: default text colors for new paragraph style drawn from wrong place
Description...taken from shape drawing rather than text preferences.
TagsNo tags attached.
Patch

Activities

mhanski

2006-04-28 16:00

developer   ~0010584

confirmed with 1.3.3.1 on kubuntu

-- change the default colours of text and shapes in File/Preferences/Tools
-- Edit/Edit Styles/New: the colours match the default shape colours

mkoren

2006-11-02 22:22

reporter   ~0013250

...which in turn had a wrong name in the colors list until it was just fixed in 0003650 (leading to all my new parastyles having a default color of "fill shape" :). Maybe the two regressions were introduced together?

mkoren

2006-11-06 20:34

reporter   ~0013301

Last edited: 2006-11-06 20:37

Ok, here's my first attempt at a "patch."

In the definition of "void StilFormate::neuesFormat()" in editformats.cpp, the following lines

        sty.FColor = Docu->toolSettings.dBrush;
        sty.FShade = Docu->toolSettings.dShade;
        sty.SColor = Docu->toolSettings.dPen;
        sty.SShade = Docu->toolSettings.dShade2;

draw on properties for shapes, not text. My guess is it should be using

        dPenText,
        dTextPenShade,
        dStrokeText,
        dTextStrokeShade

(from toolPrefs in prefsstructs.h) instead, though I'm not quite sure in which order. (I'm not sure when it changed; I didn't think this used to be wrong.)

I can't compile this here yet to test it, as I have yet to install all the devel stuff, but maybe someone can see if this looks right.

cbradney

2006-11-06 20:57

administrator   ~0013302

Its been like that forever, its in 1.2.x like that.

Issue History

Date Modified Username Field Change
2006-04-13 22:59 mkoren New Issue
2006-04-28 16:00 mhanski Note Added: 0010584
2006-04-28 16:00 mhanski Status new => confirmed
2006-11-02 22:22 mkoren Note Added: 0013250
2006-11-06 20:34 mkoren Note Added: 0013301
2006-11-06 20:37 mkoren Note Edited: 0013301
2006-11-06 20:45 cbradney Status confirmed => resolved
2006-11-06 20:45 cbradney Fixed in Version => 1.3.3.5cvs
2006-11-06 20:45 cbradney Resolution open => fixed
2006-11-06 20:45 cbradney Assigned To => cbradney
2006-11-06 20:57 cbradney Note Added: 0013302
2006-11-07 14:29 cbradney Status resolved => closed