View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0005211 | Scribus | Internal | public | 2007-01-21 12:55 | 2011-02-06 21:20 |
Reporter | cbradney | Assigned To | fschmid | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Product Version | 1.3.3.8cvs | ||||
Fixed in Version | 1.4.0svn | ||||
Summary | 0005211: Issues with dereferencing type-punned pointer | ||||
Description | http://bugs.gentoo.org/show_bug.cgi?id=162441 | ||||
Tags | No tags attached. | ||||
Patch | |||||
|
Reminder sent to: fschmid, jghali Either of you can fix this. I note that blur in 1.3.4 is completely different to 1.3.3.x, can this be backported? We still have liberateMemory used in 1.3.4 in sharpen(). |
|
Assigning to Franz, as he imported the code or wrote the code. |
|
When this one is fixed, please do not close, there are more warnings to be fixed after scimage |
|
The liberateMemory() function is nothing else as a somewhat more error checking free() call, so i think we can simply replace that with free. Btw: i've never seen that warning here, is this a new warning from gcc-4.x ? |
|
Have removed that liberateMemory() function in scimage.cpp now. Replaces all calls to it with free(). Please test if that is ok. |
|
Thanks, however this bug is for 1.3.3.8cvs. 5212 is for 1.3.4cvs. You need to turn on -fstrict-aliasing and yes, it may only exist in gcc 4.x, unsure there, check your man gcc. |
|
Seems ok here now for scimage. the python code needs work though, unsure if those ones can be fixed |
|
Have fixed now the last ones in 1.3.5svn. |
|
/home/craig/scribus/PostTrunk/trunk/Scribus/scribus/plugins/scriptplugin/scriptplugin.cpp: In function 'void initscribus(ScribusMainWindow*)': /home/craig/scribus/PostTrunk/trunk/Scribus/scribus/plugins/scriptplugin/scriptplugin.cpp:503: warning: dereferencing type-punned pointer will break strict-aliasing rules /home/craig/scribus/PostTrunk/trunk/Scribus/scribus/plugins/scriptplugin/scriptplugin.cpp:505: warning: dereferencing type-punned pointer will break strict-aliasing rules /home/craig/scribus/PostTrunk/trunk/Scribus/scribus/plugins/scriptplugin/scriptplugin.cpp:507: warning: dereferencing type-punned pointer will break strict-aliasing rules /home/craig/scribus/PostTrunk/builddir/scribus/plugins/scriptplugin/../../../../trunk/Scribus/scribus/plugins/scriptplugin/scriptplugin.h:47: warning: 'PyObject* scribus_retval(PyObject*, PyObject*)' declared 'static' but never defined /home/craig/scribus/PostTrunk/builddir/scribus/plugins/scriptplugin/../../../../trunk/Scribus/scribus/plugins/scriptplugin/scriptplugin.h:48: warning: 'PyObject* scribus_getval(PyObject*)' declared 'static' but never defined |
|
not quite all |
Date Modified | Username | Field | Change |
---|---|---|---|
2007-01-21 12:55 | cbradney | New Issue | |
2007-01-21 13:47 | cbradney | Note Added: 0014909 | |
2007-01-21 13:51 | cbradney | Status | new => assigned |
2007-01-21 13:51 | cbradney | Assigned To | => fschmid |
2007-01-21 13:51 | cbradney | Note Added: 0014910 | |
2007-01-21 14:02 | cbradney | Relationship added | related to 0005212 |
2007-01-21 14:20 | cbradney | Note Added: 0014911 | |
2007-01-21 15:45 | fschmid | Note Added: 0014913 | |
2007-01-21 16:13 | fschmid | Note Added: 0014915 | |
2007-01-21 20:27 | cbradney | Note Added: 0014923 | |
2007-01-23 20:08 | cbradney | Note Added: 0014968 | |
2007-12-29 10:46 | fschmid | Note Added: 0018434 | |
2007-12-29 21:58 | cbradney | Note Added: 0018435 | |
2007-12-29 21:58 | cbradney | Note Added: 0018436 | |
2011-02-06 21:20 | cbradney | Status | assigned => closed |
2011-02-06 21:20 | cbradney | Resolution | open => fixed |
2011-02-06 21:20 | cbradney | Fixed in Version | => 1.4.0svn |