View Issue Details

IDProjectCategoryView StatusLast Update
0007805ScribusScripterpublic2009-02-19 22:13
ReporterOssiLehtinen Assigned Tojghali  
PrioritynormalSeveritymajorReproducibilityalways
Status closedResolutionfixed 
PlatformLinuxOSUbuntuOS Version8.10
Product Version1.3.5svn 
Fixed in Version1.3.5svn 
Summary0007805: setLineSpacing in scripter does nothing
DescriptionThe scripter function setLineSpacing doesn't seem to do anything.

Looking at the code the final action on the linespacing is commented out, and also doesn't work if uncommented.

The attached patch makes things happen.
TagsNo tags attached.
Patch

Activities

2009-02-19 00:39

 

setLineSpacing.diff (942 bytes)   
Index: Scribus/scribus/plugins/scriptplugin/cmdtext.cpp
===================================================================
--- Scribus/scribus/plugins/scriptplugin/cmdtext.cpp	(revision 13197)
+++ Scribus/scribus/plugins/scriptplugin/cmdtext.cpp	(working copy)
@@ -443,6 +443,16 @@
 		PyErr_SetString(WrongFrameTypeError, QObject::tr("Cannot set line spacing on a non-text frame.","python error").toLocal8Bit().constData());
 		return NULL;
 	}
+	
+	int Apm = ScCore->primaryMainWindow()->doc->appMode;
+	ScCore->primaryMainWindow()->doc->m_Selection->clear();
+	ScCore->primaryMainWindow()->doc->m_Selection->addItem(i);
+	if (i->HasSel)
+		ScCore->primaryMainWindow()->doc->appMode = modeEdit;
+	ScCore->primaryMainWindow()->doc->itemSelection_SetLineSpacing(w);
+	ScCore->primaryMainWindow()->doc->appMode = Apm;
+	ScCore->primaryMainWindow()->view->Deselect();
+		
 //	i->setLineSpacing(w);
 //	Py_INCREF(Py_None);
 //	return Py_None;
 
setLineSpacing.diff (942 bytes)   

jghali

2009-02-19 22:10

administrator   ~0021169

Committed, thanks for the patch!

Issue History

Date Modified Username Field Change
2009-02-19 00:39 OssiLehtinen New Issue
2009-02-19 00:39 OssiLehtinen File Added: setLineSpacing.diff
2009-02-19 22:10 jghali Note Added: 0021169
2009-02-19 22:10 jghali Status new => resolved
2009-02-19 22:10 jghali Fixed in Version => 1.3.5svn
2009-02-19 22:10 jghali Resolution open => fixed
2009-02-19 22:10 jghali Assigned To => jghali
2009-02-19 22:13 cbradney Status resolved => closed