View Issue Details

IDProjectCategoryView StatusLast Update
0011400ScribusShape Drawingpublic2014-10-23 16:27
ReporterFirasH Assigned Tocbradney  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version1.5.0svn 
Fixed in Version1.5.0svn 
Summary0011400: [TESTED-PATCH] "Open a Polygon or Cuts a Bezier Curve" remains selected even if not active
Description"Open a Polygon or Cuts a Bezier Curve" remains selected even if not active.
Steps To Reproduce0) Create a new document
1) Insert a Shape
2) Double-click on the Shape so that "Nodes" window appears
3) Click on "Open a Polygon or Cuts a Bezier Curve"
4) Click on "Mode Nodes", "Add Nodes", "Delete Nodes", "Move Control Points", "Move Control Points Independently", "Move Control Points Symmetrical"

"Open a Polygon or Cuts a Bezier Curve" remains clicked even if not active.
The attached patch fixes the issue in 1.5.0.svn.
Additional InformationIssue present on:
1.4.5.svn
1.5.0.svn
TagsNo tags attached.
Patch

Relationships

related to 0012607 new Useless button makes UI complex 
related to 0012615 closedjghali [PATCH] Fix some untranslatable UI strings (3) 

Activities

Kunda

2014-07-25 02:29

updater   ~0032975

JLuc, are you talking about the 'Nodes' palette menu?

JLuc

2014-07-25 08:31

developer   ~0032987

Last edited: 2014-07-25 08:37

I think so.
It keeps looking pressed + having a semi transparent pink layer on top of it.

When the focus is given to some other window (not the "nodes" dialog anymore), the pink layer disappear but the 1st button keeps looking pressed.

I upload screenshot.

JLuc

2014-07-25 12:17

developer   ~0032992

That's mostly 'cosmetic'.

Kunda

2014-07-25 12:46

updater   ~0032993

FYI, spelling and grammar issue in
"Open a Polygon or Cuts a bezier curve"

FirasH

2014-08-14 16:00

reporter   ~0033251

"Move Nodes" needs to be enabled to use the 3 buttons next to it.
"Move Control Points" need to be enabled for the same reason.

It's not a bug in my opinion, maybe the button does not look very nice when selected, but seems something with Ubuntu UI style.
Never seen that on XFCE (screenshot attached) or KDE.

FirasH

2014-08-14 17:06

reporter   ~0033252

The problem is when you click "Open a Polygon or Cuts a Bezier Curve" and click again on "Move Nodes". "Open a Polygon or Cuts a Bezier Curve" in that case should be deselected.

FirasH

2014-08-14 20:37

reporter   ~0033253

Added a .patch to fix the problem that kept "Open a Polygon or Cuts a Bezier Curve" selected even if not active. Tested here and works correctly.

FirasH

2014-08-15 17:14

reporter   ~0033263

Updated the report.

FirasH

2014-08-31 18:28

reporter  

11400.diff (2,887 bytes)   
Index: scribus/ui/nodeeditpalette.cpp
===================================================================
--- scribus/ui/nodeeditpalette.cpp	(revisione 19425)
+++ scribus/ui/nodeeditpalette.cpp	(copia locale)
@@ -100,8 +100,8 @@
	gridLayout->addWidget(Res1Node, 1, 3, 1, 1);

	PolySplit = new QToolButton(this);
-	PolySplit->setEnabled( false );
-	PolySplit->setCheckable( true );
+	PolySplit->setEnabled(false);
+	PolySplit->setCheckable(true);
	PolySplit->setIcon(QIcon(loadIcon("PolyCut.png")));
	PolySplit->setIconSize(iconSize);
	PolySplit->setContentsMargins(0, 0, 0, 0);
@@ -109,7 +109,7 @@
	gridLayout->addWidget(PolySplit, 2, 0, 1, 1);

	BezierClose = new QToolButton(this);
-	BezierClose->setEnabled( false );
+	BezierClose->setEnabled(false);
	BezierClose->setIcon(QIcon(loadIcon("BezierClose.png")));
	BezierClose->setIconSize(iconSize);
	BezierClose->setContentsMargins(0, 0, 0, 0);
@@ -617,6 +617,7 @@
		m_doc->nodeEdit.MoveSym = true;
	SymMove->setChecked(true);
	AsymMove->setChecked(false);
+	PolySplit->setChecked(false);
 }

 void NodePalette::SetAsym()
@@ -625,6 +626,7 @@
		m_doc->nodeEdit.MoveSym = false;
	SymMove->setChecked(false);
	AsymMove->setChecked(true);
+	PolySplit->setChecked(false);
 }

 void NodePalette::SetXY(double x, double y)
@@ -819,6 +821,7 @@
	MoveControl->setChecked(true);
	DeleteNode->setChecked(false);
	AddNode->setChecked(false);
+	PolySplit->setChecked(false);
 }

 void NodePalette::MoveN()
@@ -843,6 +846,7 @@
	MoveControl->setChecked(false);
	DeleteNode->setChecked(false);
	AddNode->setChecked(false);
+	PolySplit->setChecked(false);
 }

 void NodePalette::AddN()
@@ -857,6 +861,7 @@
	Res1Node->setEnabled(false);
	AddNode->setChecked(true);
	DeleteNode->setChecked(false);
+	PolySplit->setChecked(false);
 }

 void NodePalette::DelN()
@@ -871,6 +876,7 @@
	Res1Node->setEnabled(false);
	AddNode->setChecked(false);
	DeleteNode->setChecked(true);
+	PolySplit->setChecked(false);
 }

 void NodePalette::closeEvent(QCloseEvent *ce)
@@ -887,8 +893,8 @@
		if (currItem->itemType() == PageItem::PathText)
			currItem->updatePolyClip();
	}
-	PolySplit->setEnabled( false );
-	BezierClose->setEnabled( false );
+	PolySplit->setEnabled(false);
+	BezierClose->setEnabled(false);
	emit paletteClosed();
	ScrPaletteBase::closeEvent(ce);
 }
@@ -909,8 +915,8 @@
		if (currItem && currItem->itemType() == PageItem::PathText)
			currItem->updatePolyClip();
	}
-	PolySplit->setEnabled( false );
-	BezierClose->setEnabled( false );
+	PolySplit->setEnabled(false);
+	BezierClose->setEnabled(false);
	EditCont->setChecked(false);
	emit paletteClosed();
 }
@@ -935,8 +941,8 @@
		if (currItem->itemType() == PageItem::PathText)
			currItem->updatePolyClip();
	}
-	PolySplit->setEnabled( false );
-	BezierClose->setEnabled( false );
+	PolySplit->setEnabled(false);
+	BezierClose->setEnabled(false);
	EditCont->setChecked(false);
	emit paletteClosed();
 }
11400.diff (2,887 bytes)   

FirasH

2014-08-31 18:30

reporter   ~0033412

I've used it for a few days and works correctly.
It would be very nice if after applying the patch to 1.5.0.svn could also be backported to 1.4.5.svn, it's a very simple patch.

FirasH

2014-09-10 16:52

reporter  

11400.gif (487,903 bytes)   
11400.gif (487,903 bytes)   

Kunda

2014-09-12 22:28

updater   ~0033659

bumping patch to top of Mantis list

FirasH

2014-10-23 16:27

reporter   ~0034125

Thanks cbradney!

Issue History

Date Modified Username Field Change
2013-01-25 17:00 JLuc New Issue
2013-01-25 19:15 jghali Summary "Move point" button allways keeps pressed => "Move point" button always keeps pressed
2014-07-25 02:29 Kunda Note Added: 0032975
2014-07-25 08:31 JLuc Note Added: 0032987
2014-07-25 08:37 JLuc Note Edited: 0032987
2014-07-25 08:37 JLuc File Added: nodes dialog.png
2014-07-25 12:17 JLuc Note Added: 0032992
2014-07-25 12:24 Kunda Summary "Move point" button always keeps pressed => Nodes dialog "Move point" button stays in 'on' mode
2014-07-25 12:24 Kunda Description Updated
2014-07-25 12:46 Kunda Note Added: 0032993
2014-07-25 12:46 Kunda Summary Nodes dialog "Move point" button stays in 'on' mode => Nodes dialog "Move Node", "Move Control Point" or "Open a Polygon" button stay in 'on' mode
2014-08-14 16:00 FirasH Note Added: 0033251
2014-08-14 16:00 FirasH File Added: 11400.png
2014-08-14 17:06 FirasH Note Added: 0033252
2014-08-14 20:36 FirasH File Added: nodeeditpalette.cpp.patch.zip
2014-08-14 20:37 FirasH Note Added: 0033253
2014-08-14 20:38 FirasH Status new => confirmed
2014-08-14 20:38 FirasH Category General => Shape Drawing
2014-08-14 20:38 FirasH Summary Nodes dialog "Move Node", "Move Control Point" or "Open a Polygon" button stay in 'on' mode => [PATCH] "Open a Polygon or Cuts a Bezier Curve" remains selected even if not active
2014-08-14 22:15 JLuc Relationship added related to 0012607
2014-08-15 13:16 FirasH File Deleted: nodeeditpalette.cpp.patch.zip
2014-08-15 13:29 FirasH File Added: 11400
2014-08-15 13:32 FirasH File Deleted: 11400
2014-08-15 13:33 FirasH File Added: 11400
2014-08-15 17:14 FirasH Note Added: 0033263
2014-08-15 17:14 FirasH Reporter JLuc => FirasH
2014-08-15 17:14 FirasH Reproducibility have not tried => always
2014-08-15 17:14 FirasH Description Updated
2014-08-15 17:14 FirasH Steps to Reproduce Updated
2014-08-15 17:14 FirasH Additional Information Updated
2014-08-15 17:14 FirasH File Deleted: 11400.png
2014-08-17 22:37 FirasH Relationship added related to 0012615
2014-08-31 18:28 FirasH File Deleted: 11400
2014-08-31 18:28 FirasH File Added: 11400.diff
2014-08-31 18:30 FirasH Note Added: 0033412
2014-08-31 18:30 FirasH Summary [PATCH] "Open a Polygon or Cuts a Bezier Curve" remains selected even if not active => [TESTED-PATCH] "Open a Polygon or Cuts a Bezier Curve" remains selected even if not active
2014-09-04 22:02 FirasH Additional Information Updated
2014-09-10 16:52 FirasH File Added: 11400.gif
2014-09-12 22:28 Kunda Note Added: 0033659
2014-09-24 17:46 FirasH File Deleted: nodes dialog.png
2014-10-22 18:25 cbradney Status confirmed => resolved
2014-10-22 18:25 cbradney Fixed in Version => 1.5.0svn
2014-10-22 18:25 cbradney Resolution open => fixed
2014-10-22 18:25 cbradney Assigned To => cbradney
2014-10-23 16:27 FirasH Note Added: 0034125
2014-10-23 16:27 FirasH Status resolved => closed