View Issue Details

IDProjectCategoryView StatusLast Update
0012571ScribusCanvaspublic2014-07-29 16:45
Reporterale Assigned Toale  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionduplicate 
Product Version1.5.0svn 
Summary0012571: [PATCH] drag and drop from a file manager does not work anymore
Descriptionunder unknown circumstances, it's not possible anymore to drag and drop images to the canvas.

i had a looked at

void ScribusView::contentsDropEvent(QDropEvent *e)

and found out that mimedata->hasText() returns true also images.

i tried to fix the thing by checking the text as the last item, but some of the "else if" do funky things that i don't want to understand and moving the hasText() condition to the end, but that leads to a crash.

attached a simple hack that seams to solve the problem... even if i would wish that the whole condition sequence would be documented and correctly fixed...
(i mean: text=text(); url=QUrl(text) ... this is not something i would expect in source code without a comment...)
Tagspatch
Patch

Relationships

duplicate of 0012564 closed [PATCH] cannot drag and drop images to the canvas 

Activities

ale

2014-07-29 15:42

manager  

scribusview.diff (397 bytes)   
Index: scribus/scribusview.cpp
===================================================================
--- scribus/scribusview.cpp	(revision 19357)
+++ scribus/scribusview.cpp	(working copy)
@@ -676,7 +676,7 @@
 		url  = QUrl(text);
 	}
 	else*/
-	if (e->mimeData()->hasText())
+	if (e->mimeData()->hasText() && (e->mimeData()->text() != ""))
 	{
 		text = e->mimeData()->text();
 		url = QUrl(text);
scribusview.diff (397 bytes)   

Issue History

Date Modified Username Field Change
2014-07-29 15:42 ale New Issue
2014-07-29 15:42 ale File Added: scribusview.diff
2014-07-29 15:42 ale Summary drag and drop from a file manager does not work anymore => [PATCH] drag and drop from a file manager does not work anymore
2014-07-29 15:42 ale Tag Attached: patch
2014-07-29 16:44 ale Relationship added duplicate of 0012564
2014-07-29 16:45 ale Status new => closed
2014-07-29 16:45 ale Assigned To => ale
2014-07-29 16:45 ale Resolution open => duplicate