View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0012564ScribusCanvaspublic2014-07-27 16:442014-08-11 18:26
Reporterale Assigned To 
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version1.5.0 
Fixed in Version1.5.0svn 
Summary0012564: [PATCH] cannot drag and drop images to the canvas
Descriptionin 1.4svn i can drag and drop bitmap and vector graphics to the canvas.

in 1.5svn it does not work.

no message in the terminal.

if you give me a hint where the relevant code is, i can make some tests...
Tagspatch
Patch

Relationships

has duplicate 0012571 closedale [PATCH] drag and drop from a file manager does not work anymore 
related to 0012597 assignedfschmid Cannot drag and drop images to the Scribus canvas (Nautilus, gThumb and Shotwell, and also in Gnome 3.12) 

Activities

Kunda

2014-07-27 20:23

updater   ~0033045

Not reproducible on OSX 10.8.5 1.5svn r19374 (Qt5.3.1)

owencook

2014-07-28 04:14

reporter   ~0033051

It seems OS dependant.

Drag and Drop does not work on my Arch and Linux Mint(debian)

Drag and Drop works on SUSE, however I get other bizarre effects/results in 1.5.0 with svgs. However I know there are some shortfalls with svgs, so I am not too fussed.>

ale

2014-07-28 08:52

manager   ~0033052

of course it's OS dependant!

still, it should be fixed.

owencook

2014-07-28 09:35

reporter   ~0033053

Installed KDE on arch and drag and drop worked on both 1.4.5 and 1.5.0

Kunda

2014-07-28 16:45

updater   ~0033057

ale, remind us which distros this happened to you on ?

jghali

2014-07-28 20:32

administrator   ~0033060

Drag and drop works also on Windows.

ale

2014-07-29 16:43

manager   ~0033075

i had a looked at

void ScribusView::contentsDropEvent(QDropEvent *e)

and found out that mimedata->hasText() returns true also for images.

i tried to fix the thing by moving the check for text to the end, but some of the "else if" do funky things that i don't want to understand and the new code leads to a crash.

attached a simple hack that seams to solve the problem...

even if i would wish that the whole condition sequence would be documented and correctly fixed...
(i mean: text=text(); url=QUrl(text) ... this is not something i would expect in source code without a comment...)

ale

2014-07-29 16:44

manager  

scribusview (1).diff (397 bytes)    
Index: scribus/scribusview.cpp
===================================================================
--- scribus/scribusview.cpp	(revision 19357)
+++ scribus/scribusview.cpp	(working copy)
@@ -676,7 +676,7 @@
 		url  = QUrl(text);
 	}
 	else*/
-	if (e->mimeData()->hasText())
+	if (e->mimeData()->hasText() && (e->mimeData()->text() != ""))
 	{
 		text = e->mimeData()->text();
 		url = QUrl(text);
scribusview (1).diff (397 bytes)   

Kunda

2014-07-30 15:51

updater   ~0033084

Hey ale, did r19383 fix this ?

Kunda

2014-08-02 13:27

updater   ~0033150

Any Linux: Arch, Mint or 'Debian Testing' folks able to test this ? (*without* KDE installed)

mmstick

2014-08-09 06:44

reporter   ~0033214

Arch Linux user here. This bug still occurs with the latest svn under GNOME 3.12.

owencook

2014-08-09 09:25

reporter   ~0033215

I no longer have Arch, but drag and drop only works on SUSE with KDE

Have also tried on the latest Ubuntu and various debian based distros.

Another thread on gimp user mailing list is about "lost drag and drop".

It is my guess that this ability has nothing to do with Scribus.

mmstick

2014-08-09 09:36

reporter   ~0033216

Drag and drop works fine in GIMP on my GNOME 3.12 systems, as well as in all other programs, so the problem very much has everything to do with Scribus.

Kunda

2014-08-09 12:47

updater   ~0033217

Last edited: 2014-08-09 12:47

 Thanks mmstick for the feedback
Re-assigning issue since bug still persists on Arch Linux.

ale

2014-08-11 13:27

manager   ~0033228

not sure... the ticket is about getting it to work for 1.5 in cases where it already works for 1.4 (avoiding a regression).

@mmstick: can you drag and drop images in scribus 1.4?

if it does not, i suggest that this ticket gets closed and, eventually, a new one is opened for that specific issue.

not all setups are compatible with scribus'/qt's drag and drop...

mmstick

2014-08-11 14:01

reporter   ~0033229

I can't drag and drop images into scribus 1.4 either in GNOME 3.12.

ale

2014-08-11 15:04

manager   ~0033230

@kunda, then i suggest that this ticket gets closed and, eventually, one can be opened for getting the drag and drop to work in GNOME 3.12...

... or, better, we could have a ticket collecting configurations where drag and drop does not work... but i fear that it won't be of much use, without the affected users being able to prepare a patch. (or the devs having access to such a configuration).

Kunda

2014-08-11 18:26

updater   ~0033234

Closed this issue as per a-l-e's advice (above)
Opened 0012597 to continue tracking drag/drop issues with other distro/s

Issue History

Date Modified Username Field Change
2014-07-27 16:44 ale New Issue
2014-07-27 20:23 Kunda Note Added: 0033045
2014-07-27 20:23 Kunda Status new => feedback
2014-07-28 04:14 owencook Note Added: 0033051
2014-07-28 08:52 ale Note Added: 0033052
2014-07-28 08:52 ale Status feedback => new
2014-07-28 08:52 ale Status new => acknowledged
2014-07-28 09:35 owencook Note Added: 0033053
2014-07-28 16:45 Kunda Note Added: 0033057
2014-07-28 20:32 jghali Note Added: 0033060
2014-07-29 16:43 ale Note Added: 0033075
2014-07-29 16:44 ale File Added: scribusview (1).diff
2014-07-29 16:44 ale Relationship added has duplicate 0012571
2014-07-29 16:45 ale Summary cannot drag and drop images to the canvas => [PATCH] cannot drag and drop images to the canvas
2014-07-29 16:45 ale Tag Attached: patch
2014-07-29 19:01 cbradney Status acknowledged => resolved
2014-07-29 19:01 cbradney Fixed in Version => 1.5.0svn
2014-07-29 19:01 cbradney Resolution open => fixed
2014-07-29 19:01 cbradney Assigned To => cbradney
2014-07-30 15:51 Kunda Note Added: 0033084
2014-08-02 13:27 Kunda Note Added: 0033150
2014-08-09 06:44 mmstick Note Added: 0033214
2014-08-09 09:25 owencook Note Added: 0033215
2014-08-09 09:36 mmstick Note Added: 0033216
2014-08-09 12:47 Kunda Note Added: 0033217
2014-08-09 12:47 Kunda Status resolved => assigned
2014-08-09 12:47 Kunda Note Edited: 0033217
2014-08-11 13:27 ale Note Added: 0033228
2014-08-11 14:01 mmstick Note Added: 0033229
2014-08-11 15:04 ale Note Added: 0033230
2014-08-11 18:23 Kunda Issue cloned: 0012597
2014-08-11 18:23 Kunda Relationship added related to 0012597
2014-08-11 18:26 Kunda Note Added: 0033234
2014-08-11 18:26 Kunda Status assigned => closed
2014-08-11 18:26 Kunda Assigned To cbradney =>