View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0012864 | Scribus | Undo/Redo | public | 2014-12-30 17:25 | 2014-12-30 22:22 |
| Reporter | FirasH | Assigned To | jghali | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Platform | x86_64 | OS | openSUSE | OS Version | 13.2 |
| Product Version | 1.5.0svn | ||||
| Fixed in Version | 1.5.0svn | ||||
| Summary | 0012864: Undo/Redo rounds Text Distances values | ||||
| Description | Undo/Redo rounds Text Distances values. | ||||
| Steps To Reproduce | 0) Create a new document 1) Insert a Text Frame 2) Go to: Properties > Text > Columns & Text Distances and change Top/Bottom/Left/Right value to something like (5,35 unit) 3) Undo changes applied in step 2 4) Redo Values are rounded to x,0 of pt unit. If a user is using cm as unit this behaviour looks very odd. (example: 1,5000 cm = 42,52 pt becomes 1,5169 cm = 43,00 pt). | ||||
| Additional Information | 1.5.0.svn (19685) | ||||
| Tags | No tags attached. | ||||
| Patch | No | ||||
| child of | 0012500 | acknowledged | Metabug: Undo/Redo (1.5.x.svn) |
|
|
jghali, your fix works perfectly! I would also apply another small change, .diff attached. Edit: btw the patch is already tested |
|
|
12864-Additional.diff (464 bytes)
Index: scribus/pageitem.cpp
===================================================================
--- scribus/pageitem.cpp (revisione 19702)
+++ scribus/pageitem.cpp (copia locale)
@@ -6700,9 +6700,9 @@
void PageItem::restoreColumnsGap(SimpleState *ss, bool isUndo)
{
if (isUndo)
- ColGap = ss->getInt("OLD_COLUMNS");
+ ColGap = ss->getDouble("OLD_COLUMNS");
else
- ColGap = ss->getInt("NEW_COLUMNS");
+ ColGap = ss->getDouble("NEW_COLUMNS");
update();
}
|
|
|
Applied, thanks! |
|
|
Perfect! Thanks jghali! |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2014-12-30 17:25 | FirasH | New Issue | |
| 2014-12-30 17:25 | FirasH | Relationship added | child of 0012500 |
| 2014-12-30 21:24 | jghali | Status | new => resolved |
| 2014-12-30 21:24 | jghali | Fixed in Version | => 1.5.0svn |
| 2014-12-30 21:24 | jghali | Resolution | open => fixed |
| 2014-12-30 21:24 | jghali | Assigned To | => jghali |
| 2014-12-30 21:50 | FirasH | Note Added: 0034333 | |
| 2014-12-30 21:51 | FirasH | File Added: 12864-Additional.diff | |
| 2014-12-30 21:53 | FirasH | Note Edited: 0034333 | |
| 2014-12-30 22:14 | jghali | Note Added: 0034334 | |
| 2014-12-30 22:22 | FirasH | Note Added: 0034335 | |
| 2014-12-30 22:22 | FirasH | Status | resolved => closed |
