|
Kunda
2015-07-01 20:27
updater
|
|
|
|
|
Posted to scribus-dev ML http://lists.scribus.net/pipermail/scribus-dev/2015-October/002599.html |
|
|
|
I have written a patch for this (for both version 1.4 and 1.5)
BTW for me http://wiki.scribus.net/canvas/Special:WebChat page is not
usable. For one thing when I zoom in (press CTRL and + in browser) to
enlarge the letters for better reading, provided IFrame is too small for
its content and scrolling is disabled. Captcha pictures are bigger than
size of IFrame. Please remove the javascript that sets the size of
IFrame onLoad, also allow scrolling.
And if I circumvent this problem there is one more problem. It is
impossible to connect with provided nickname, and it not possible to
supply your own nickname. I get this error when connecting:
$$$nick$$$ Erroneous Nickname
I would suggest to replace that IFrame with simple link to
http://webchat.freenode.net/?channels=scribus |
|
|
Kunda
2015-10-08 02:44
updater
|
0001-Add-Chat-on-IRC-scribus-in-help-menu_v14.patch (3,910 bytes)
From 3b23758554819345cd04d8743b229b4d2f69e160 Mon Sep 17 00:00:00 2001
From: Juraj Fedel <wtxnh-scribus@yahoo.com.au>
Date: Thu, 8 Oct 2015 02:49:52 +0200
Subject: [PATCH] Add Chat on IRC #scribus in help menu
---
scribus/actionmanager.cpp | 6 +++++-
scribus/scribus.cpp | 1 +
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/scribus/actionmanager.cpp b/scribus/actionmanager.cpp
index 2704394..1acbec5 100644
--- a/scribus/actionmanager.cpp
+++ b/scribus/actionmanager.cpp
@@ -841,6 +841,8 @@ void ActionManager::initHelpMenuActions()
scrActions->insert(name, new ScrAction(ScrAction::DataQString, QPixmap(), QPixmap(), "", defaultKey(name), mainWindow, 0, 0.0, "http://wiki.scribus.net"));
name="helpOnlineTutorial1";
scrActions->insert(name, new ScrAction(ScrAction::DataQString, QPixmap(), QPixmap(), "", defaultKey(name), mainWindow, 0, 0.0, ""));
+ name="helpOnlineWebChat";
+ scrActions->insert(name, new ScrAction(ScrAction::DataQString, QPixmap(), QPixmap(), "", defaultKey(name), mainWindow, 0, 0.0, "http://webchat.freenode.net/?channels=scribus"));
name="helpCheckUpdates";
scrActions->insert(name, new ScrAction("", defaultKey(name), mainWindow));
@@ -858,6 +860,7 @@ void ActionManager::initHelpMenuActions()
connect( (*scrActions)["helpOnlineDocs"], SIGNAL(triggeredData(QString)), ul, SLOT(launchUrlExt(const QString)) );
connect( (*scrActions)["helpOnlineWiki"], SIGNAL(triggeredData(QString)), ul, SLOT(launchUrlExt(const QString)) );
connect( (*scrActions)["helpOnlineTutorial1"], SIGNAL(triggeredData(QString)), ul, SLOT(launchUrlExt(const QString)) );
+ connect( (*scrActions)["helpOnlineWebChat"], SIGNAL(triggeredData(QString)), ul, SLOT(launchUrlExt(const QString)) );
}
void ActionManager::initUnicodeActions(QMap<QString, QPointer<ScrAction> > *actionMap, QWidget *actionParent, QStringList *actionNamesList)
@@ -1502,6 +1505,7 @@ void ActionManager::languageChange()
(*scrActions)["helpOnlineDocs"]->setTexts( tr("Scribus Online Documentation"));
(*scrActions)["helpOnlineWiki"]->setTexts( tr("Scribus Wiki"));
(*scrActions)["helpOnlineTutorial1"]->setTexts( tr("Getting Started with Scribus"));
+ (*scrActions)["helpOnlineWebChat"]->setTexts( tr("Chat on IRC #scribus"));
(*scrActions)["helpCheckUpdates"]->setTexts( tr("Check for Updates"));
//GUI and specials
@@ -1872,7 +1876,7 @@ void ActionManager::createDefaultMenus()
itmenu->second << "windowsCascade" << "windowsTile" << "toolsProperties" << "toolsOutline" << "toolsScrapbook" << "toolsLayers" << "toolsPages" << "toolsBookmarks" << "toolsMeasurements" << "toolsActionHistory" << "toolsPreflightVerifier" << "toolsAlignDistribute" << "toolsToolbarTools" << "toolsToolbarPDF";
//Help
++itmenu;
- itmenu->second << "helpAboutScribus" << "helpAboutPlugins" << "helpAboutQt" << "helpTooltips" << "helpManual" << "helpOnlineWWW" << "helpOnlineDocs" << "helpOnlineWiki" << "helpOnlineTutorial1" << "helpCheckUpdates";
+ itmenu->second << "helpAboutScribus" << "helpAboutPlugins" << "helpAboutQt" << "helpTooltips" << "helpManual" << "helpOnlineWWW" << "helpOnlineDocs" << "helpOnlineWiki" << "helpOnlineTutorial1" << "helpOnlineWebChat" << "helpCheckUpdates";
//Other
// ++itmenu;
// itmenu->second << "";
diff --git a/scribus/scribus.cpp b/scribus/scribus.cpp
index c5c6a53..496d5c4 100644
--- a/scribus/scribus.cpp
+++ b/scribus/scribus.cpp
@@ -962,6 +962,7 @@ void ScribusMainWindow::initMenuBar()
scrMenuMgr->addMenuItem(scrActions["helpOnlineWiki"], "Help");
scrMenuMgr->createMenu("HelpOnlineTutorials", tr("Online &Tutorials"), "Help");
scrMenuMgr->addMenuItem(scrActions["helpOnlineTutorial1"], "HelpOnlineTutorials");
+ scrMenuMgr->addMenuItem(scrActions["helpOnlineWebChat"], "Help");
scrMenuMgr->addMenuSeparator("Help");
scrMenuMgr->addMenuItem(scrActions["helpCheckUpdates"], "Help");
scrMenuMgr->addMenuSeparator("Help");
--
2.1.4
|
|
|
Kunda
2015-10-08 02:45
updater
|
0001-Add-Chat-on-IRC-scribus-in-help-menu_v15.patch (3,151 bytes)
From 265c24526291916131352ebd01c4320279dfe9eb Mon Sep 17 00:00:00 2001
From: Juraj Fedel <wtxnh-scribus@yahoo.com.au>
Date: Thu, 8 Oct 2015 02:50:20 +0200
Subject: [PATCH] Add Chat on IRC #scribus in help menu
---
scribus/actionmanager.cpp | 5 +++++
scribus/scribus.cpp | 1 +
2 files changed, 6 insertions(+)
diff --git a/scribus/actionmanager.cpp b/scribus/actionmanager.cpp
index 7f6c344..b8642ff 100644
--- a/scribus/actionmanager.cpp
+++ b/scribus/actionmanager.cpp
@@ -1001,6 +1001,8 @@ void ActionManager::initHelpMenuActions()
scrActions->insert(name, new ScrAction(ScrAction::DataQString, QPixmap(), QPixmap(), "", defaultKey(name), mainWindow, "http://wiki.scribus.net"));
name="helpOnlineTutorial1";
scrActions->insert(name, new ScrAction(ScrAction::DataQString, QPixmap(), QPixmap(), "", defaultKey(name), mainWindow, ""));
+ name="helpOnlineWebChat";
+ scrActions->insert(name, new ScrAction(ScrAction::DataQString, QPixmap(), QPixmap(), "", defaultKey(name), mainWindow, "http://webchat.freenode.net/?channels=scribus"));
name="helpCheckUpdates";
scrActions->insert(name, new ScrAction("", defaultKey(name), mainWindow));
@@ -1018,6 +1020,7 @@ void ActionManager::initHelpMenuActions()
connect( (*scrActions)["helpOnlineDocs"], SIGNAL(triggeredData(QString)), ul, SLOT(launchUrlExt(const QString)) );
connect( (*scrActions)["helpOnlineWiki"], SIGNAL(triggeredData(QString)), ul, SLOT(launchUrlExt(const QString)) );
connect( (*scrActions)["helpOnlineTutorial1"], SIGNAL(triggeredData(QString)), ul, SLOT(launchUrlExt(const QString)) );
+ connect( (*scrActions)["helpOnlineWebChat"], SIGNAL(triggeredData(QString)), ul, SLOT(launchUrlExt(const QString)) );
}
void ActionManager::initUnicodeActions(QMap<QString, QPointer<ScrAction> > *actionMap, QWidget *actionParent, QStringList *actionNamesList)
@@ -1743,6 +1746,7 @@ void ActionManager::languageChange()
(*scrActions)["helpOnlineDocs"]->setTexts( tr("Scribus Online Documentation"));
(*scrActions)["helpOnlineWiki"]->setTexts( tr("Scribus Wiki"));
(*scrActions)["helpOnlineTutorial1"]->setTexts( tr("Getting Started with Scribus"));
+ (*scrActions)["helpOnlineWebChat"]->setTexts( tr("Chat on IRC #scribus"));
(*scrActions)["helpCheckUpdates"]->setTexts( tr("Check for Updates"));
//GUI and specials
@@ -2360,6 +2364,7 @@ void ActionManager::createDefaultMenus()
<< "helpOnlineDocs"
<< "helpOnlineWiki"
<< "helpOnlineTutorial1"
+ << "helpOnlineWebChat"
<< "helpCheckUpdates";
//Other
// ++itmenu;
diff --git a/scribus/scribus.cpp b/scribus/scribus.cpp
index 0023619..b530123 100644
--- a/scribus/scribus.cpp
+++ b/scribus/scribus.cpp
@@ -1158,6 +1158,7 @@ void ScribusMainWindow::initMenuBar()
scrMenuMgr->addMenuItemString("helpOnlineWiki", "Help");
scrMenuMgr->addMenuItemString("HelpOnlineTutorials", "Help");
scrMenuMgr->addMenuItemString("helpOnlineTutorial1", "Help");
+ scrMenuMgr->addMenuItemString("helpOnlineWebChat", "Help");
scrMenuMgr->addMenuItemString("SEPARATOR", "Help");
scrMenuMgr->addMenuItemString("helpCheckUpdates", "Help");
scrMenuMgr->addMenuItemString("SEPARATOR", "Help");
--
2.1.4
|
|
|
|
Juraj, you're Awesome! Testing this now :)
Thanks for the heads up about the wiki.scribus.net special:webchat page. that thing is pretty dated. Good to know. |
|
|
|
Patch is not working for me on OSX 10.10.5 1.5.1 r20447
No errors are given.
I needed to remove the last line of the 1.5 patch
2.1.4
because it was throwing a warning. |
|
|
|
Juraj,
Cancel clear, the patch works! (I was testing the wrong scribus application)
I am encountering a separate issue 0013400 which won't open a new tab in firefox.
Thanks for the patch! |
|
|
|
Two issues I have:
1) Adding a feature to a relatively stable version (1.4.x)
2) but mainly, having it in the menu offers some kind of assurance that someone is there to help, which is no guarantee. In a menu there is no way to add a disclaimer, or a description of what webpage comes next etc. And.. how does an employer or parent know the Chat function doesn't send their employee or child off somewhere inappropriate. |
|
|
|
Valid concerns.
My thoughts:
1) I'm no expert but this feature is relatively straight forward. It calls the browser just like the other Help menus. It's not introducing anything new AFAICT, right?
2) It's not a guarantee that someone will be there, none of the other places I've seen IRC mentioned imply that. People learn eventually on IRC that people idle. As for employers/parents, most likely that calling a browser window will trigger mechanisms they have in place. This is not the early 2000s when folks didn't understand these things. my 2c |
|
|
|
I'm actually more concerned about the nobody being there thing.. people clicking "Chat" expect someone to answer their chat... IRC is not a 24x7 Helpdesk, there's no guarantee anyone is there. |
|
|
|
Yes, I see your point. How about the string be:
"Visit us on IRC (not a 24/7 Helpdesk!)" |
|
|
|
Worst case we add it and if it becomes an issue we decide what to do then. Right ? |
|
|
|
Another option is to point it to forums.scribus.net |
|
|
|
Juraj suggested to me that it should point to a wiki page with places people can go to get further help. That sounds like a fair compromise. right ? |
|
|
|
this ticket is for adding a chat.
adding a link to a "further help page" is an option, but it should imo go to a different ticket.
let's keep the discussion about the irc chat in here.
about the fear of providing a deceptive chat experience: i think that it would be better to add a script in mscribe that autoresponds if somebody comes from the web chat and does not get an answer in a few (2?) minutes.
i would not add a systematic auto-welcome (i hate it, being greated by a bot) but in this case it could help explain to new users how fast and at what times an answer can be expected... |
|
|
|
ale, brilliant. I like your idea of the bot greeting people coming from a certain url etc... |
|
|
|
emailed malex to see if he would potentially configure mrscribe to greet newcomers coming in via http://webchat.freenode.net/?channels=scribus |
|
|
|
The Herald plugin could cut it, but it uses hostmask to identify incoming users. What other identifying characteristics are going to be present for the users coming via the Help menu? |
|
|
|
Hey Malex,
Hostmask should do it, no problem.
An example of a hostmask 42444ee0@gateway/web/freenode/ip.61.62.77.223
The pattern we can look for is something like:
'alphanumeric string'@gateway/web/freenode/ip.'(ip address)' |
|
|
|
I suggest mrscribe greeting text could be:
"Hello $nick, welcome to the #scribus IRC channel. This is not an official support channel but you may be able to get some help if you stick around and ask politely. Feel free to hang out, we like the company." |
|
|
|
Craig has agreed to implement if malex programs mrscribe to greet new folks with a similiar message in 0013198:0036800 |
|
|
|
i would replace "not an official support channel" with "a community support channel"... somehow, positive is better than negative... |
|
|
|
Agreed, but how do we convey that the channel is not a 24/7 support channel. Meaning that it's volunteers that idle and answer if they're here, so people don't feel entitled or disappointed that there isn't someone immediately there for them |
|
|
|
Malex, according to #supybot the Herald plugin isn't sophisticated enough to handles this type of query. They recommend using the following plugins:
Trigger and Conditional.
Trigger gets triggered when someone joins the channel. Conditional is used to check the hostmask.
Tips:
"for trigger: just put the right command in plugins.Trigger.triggers.join"
For Conditional: http://progval.net:7410/plugindoc/Conditional/
ex.
(re <regexp> <text>) -- If <regexp> is of the form m/regexp/flags, returns the portion of <text> that matches the regexp. If <regexp> is of the form s/regexp/replacement/flags, returns the result of applying such a regexp to <text>.
(conditional match <item1> <item2>) -- Determines if <item1> is a substring of <item2>. Returns true if <item1> is contained in <item2>.
|
|
|
|
Committed by Craig in r20510 to 1.5.x (it was not backported)
Thanks Juraj and Craig. |
|
