View Issue Details

IDProjectCategoryView StatusLast Update
0013365ScribusUndo/Redopublic2015-09-23 19:10
ReporterFirasH Assigned ToFirasH  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version1.4.6.svn 
Fixed in Version1.4.6.svn 
Summary0013365: Rename action is wrongly recorded in Action History
DescriptionRename action is wrongly recorded in Action History.
Steps To Reproduce0) Create a new document and open Windows > Propertied/Action History
1) Insert an Item
2) Select the Item and Properties > X,Y,Z > change "Name"

In Action History a new action is added as follows:

"Old_Name" - Rename
From "New_Name"
to "New_Name"
Additional Information1.4.6.svn (20406)
1.5.1.svn (20414)
TagsNo tags attached.
PatchYes

Relationships

child of 0012500 acknowledged Metabug: Undo/Redo (1.5.x.svn) 

Activities

FirasH

2015-09-23 12:00

developer  

13365(1.5.1)-Patch.diff (484 bytes)   

diff --git a/scribus/pageitem.cpp b/scribus/pageitem.cpp
--- a/scribus/pageitem.cpp
+++ b/scribus/pageitem.cpp
@@ -2964,7 +2964,7 @@
 	AutoName=false;
 	if (UndoManager::undoEnabled())
 	{
-		SimpleState *ss = new SimpleState(Um::Rename, QString(Um::FromTo).arg(AnName).arg(newName));
+		SimpleState *ss = new SimpleState(Um::Rename, QString(Um::FromTo).arg(oldName).arg(newName));
 		ss->set("OLD_NAME", oldName);
 		ss->set("NEW_NAME", newName);
 		undoManager->action(this, ss);
13365(1.5.1)-Patch.diff (484 bytes)   

Kunda

2015-09-23 13:10

updater   ~0036339

Last edited: 2015-09-23 13:10

Confirmed bug on 1.5.1. Haven't tested patch yet.
Also changed bug title to reflect that it's a patch.
Thanks Firash!

FirasH

2015-09-23 19:10

developer   ~0036348

Thanks jghali!
Fixed in 1.4.6.svn (20415) and 1.5.1.svn (20416).

Issue History

Date Modified Username Field Change
2015-09-23 10:41 FirasH New Issue
2015-09-23 10:41 FirasH Steps to Reproduce Updated
2015-09-23 10:51 FirasH Relationship added child of 0012500
2015-09-23 12:00 FirasH Patch No => Yes
2015-09-23 12:00 FirasH File Added: 13365(1.5.1)-Patch.diff
2015-09-23 13:10 Kunda Note Added: 0036339
2015-09-23 13:10 Kunda Status new => confirmed
2015-09-23 13:10 Kunda Summary Rename action is wrongly recorded in Action History => [PATCH] Rename action is wrongly recorded in Action History
2015-09-23 13:10 Kunda Note Edited: 0036339
2015-09-23 18:39 jghali Summary [PATCH] Rename action is wrongly recorded in Action History => Rename action is wrongly recorded in Action History
2015-09-23 18:39 jghali Status confirmed => resolved
2015-09-23 18:39 jghali Fixed in Version => 1.4.6.svn
2015-09-23 18:39 jghali Resolution open => fixed
2015-09-23 18:39 jghali Assigned To => FirasH
2015-09-23 19:10 FirasH Note Added: 0036348
2015-09-23 19:10 FirasH Status resolved => closed