View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0013365 | Scribus | Undo/Redo | public | 2015-09-23 10:41 | 2015-09-23 19:10 |
| Reporter | FirasH | Assigned To | FirasH | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 1.4.6.svn | ||||
| Fixed in Version | 1.4.6.svn | ||||
| Summary | 0013365: Rename action is wrongly recorded in Action History | ||||
| Description | Rename action is wrongly recorded in Action History. | ||||
| Steps To Reproduce | 0) Create a new document and open Windows > Propertied/Action History 1) Insert an Item 2) Select the Item and Properties > X,Y,Z > change "Name" In Action History a new action is added as follows: "Old_Name" - Rename From "New_Name" to "New_Name" | ||||
| Additional Information | 1.4.6.svn (20406) 1.5.1.svn (20414) | ||||
| Tags | No tags attached. | ||||
| Patch | Yes | ||||
| child of | 0012500 | acknowledged | Metabug: Undo/Redo (1.5.x.svn) |
|
|
13365(1.5.1)-Patch.diff (484 bytes)
diff --git a/scribus/pageitem.cpp b/scribus/pageitem.cpp
--- a/scribus/pageitem.cpp
+++ b/scribus/pageitem.cpp
@@ -2964,7 +2964,7 @@
AutoName=false;
if (UndoManager::undoEnabled())
{
- SimpleState *ss = new SimpleState(Um::Rename, QString(Um::FromTo).arg(AnName).arg(newName));
+ SimpleState *ss = new SimpleState(Um::Rename, QString(Um::FromTo).arg(oldName).arg(newName));
ss->set("OLD_NAME", oldName);
ss->set("NEW_NAME", newName);
undoManager->action(this, ss);
|
|
|
Confirmed bug on 1.5.1. Haven't tested patch yet. Also changed bug title to reflect that it's a patch. Thanks Firash! |
|
|
Thanks jghali! Fixed in 1.4.6.svn (20415) and 1.5.1.svn (20416). |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2015-09-23 10:41 | FirasH | New Issue | |
| 2015-09-23 10:41 | FirasH | Steps to Reproduce Updated | |
| 2015-09-23 10:51 | FirasH | Relationship added | child of 0012500 |
| 2015-09-23 12:00 | FirasH | Patch | No => Yes |
| 2015-09-23 12:00 | FirasH | File Added: 13365(1.5.1)-Patch.diff | |
| 2015-09-23 13:10 | Kunda | Note Added: 0036339 | |
| 2015-09-23 13:10 | Kunda | Status | new => confirmed |
| 2015-09-23 13:10 | Kunda | Summary | Rename action is wrongly recorded in Action History => [PATCH] Rename action is wrongly recorded in Action History |
| 2015-09-23 13:10 | Kunda | Note Edited: 0036339 | |
| 2015-09-23 18:39 | jghali | Summary | [PATCH] Rename action is wrongly recorded in Action History => Rename action is wrongly recorded in Action History |
| 2015-09-23 18:39 | jghali | Status | confirmed => resolved |
| 2015-09-23 18:39 | jghali | Fixed in Version | => 1.4.6.svn |
| 2015-09-23 18:39 | jghali | Resolution | open => fixed |
| 2015-09-23 18:39 | jghali | Assigned To | => FirasH |
| 2015-09-23 19:10 | FirasH | Note Added: 0036348 | |
| 2015-09-23 19:10 | FirasH | Status | resolved => closed |
