View Issue Details

IDProjectCategoryView StatusLast Update
0013720ScribusUsabilitypublic2016-02-27 13:16
Reporterale Assigned Tocbradney  
PrioritynormalSeverityfeatureReproducibilityN/A
Status closedResolutionfixed 
Product Version1.5.0 
Target Version1.5.2Fixed in Version1.5.2.svn 
Summary0013720: [PATCH] select all items on all layers
Descriptionif i activate "select object on layer" for specific layers, then i can select by click and drag all the elements on the active layer and on those layers.

it would be nice if ctrl-a also would respect that setting and select all items
- on the current page
- on the current layer
- and on the layers with "select object on layer" active
TagsNo tags attached.
PatchYes

Relationships

child of 0003838 acknowledged Metabug: Scribus layers 

Activities

ale

2016-02-12 16:45

manager  

select-all.diff (602 bytes)   
diff --git a/scribus/scribus.cpp b/scribus/scribus.cpp
index b50b49a..7881447 100644
--- a/scribus/scribus.cpp
+++ b/scribus/scribus.cpp
@@ -5040,7 +5040,7 @@ void ScribusMainWindow::SelectAll(bool docWideSelect)
 		for (uint a = 0; a < docItemsCount; ++a)
 		{
 			currItem = doc->Items->at(a);
-			if ((currItem->LayerID == doc->activeLayer()) && (!doc->layerLocked(currItem->LayerID)))
+			if (((currItem->LayerID == doc->activeLayer()) || (doc->layerSelectable(currItem->LayerID))) && (!doc->layerLocked(currItem->LayerID)))
 			{
 				if (docWideSelect)
 					doc->m_Selection->addItem(currItem);
select-all.diff (602 bytes)   

Kunda

2016-02-12 18:43

updater   ~0038672

Tested patch. Looks like it works

Kunda

2016-02-15 12:53

updater   ~0038742

Devs, opinion?

Kunda

2016-02-21 12:52

updater   ~0038854

jghali?

Kunda

2016-02-27 13:16

updater   ~0038914

Thanks ale!
Committed in r21025

Issue History

Date Modified Username Field Change
2016-02-10 13:04 ale New Issue
2016-02-10 15:35 ale Tag Attached: #easyhack
2016-02-10 16:24 Kunda Relationship added child of 0003838
2016-02-12 16:45 ale File Added: select-all.diff
2016-02-12 16:45 ale Summary select all items on all layers => [PATCH] select all items on all layers
2016-02-12 18:43 Kunda Note Added: 0038672
2016-02-13 08:58 ale Tag Detached: #easyhack
2016-02-13 14:06 Kunda Patch No => Yes
2016-02-15 12:53 Kunda Note Added: 0038742
2016-02-15 12:53 Kunda Target Version => 1.5.3
2016-02-15 23:01 Kunda Category - => Usability
2016-02-21 12:52 Kunda Note Added: 0038854
2016-02-22 22:37 cbradney Status new => resolved
2016-02-22 22:37 cbradney Fixed in Version => 1.5.2.svn
2016-02-22 22:37 cbradney Resolution open => fixed
2016-02-22 22:37 cbradney Assigned To => cbradney
2016-02-27 13:16 Kunda Note Added: 0038914
2016-02-27 13:16 Kunda Status resolved => closed
2016-02-27 13:16 Kunda Target Version 1.5.3 => 1.5.2