View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0014139 | Scribus | Usability | public | 2016-06-08 09:07 | 2023-05-29 18:56 |
| Reporter | JLuc | Assigned To | cbradney | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Platform | Linux | OS | Ubuntu | OS Version | 14.04 |
| Product Version | 1.5.2 | ||||
| Fixed in Version | 1.6.0.svn | ||||
| Summary | 0014139: Default button for preferences should be "Ok" | ||||
| Description | Default button for document preferences is "Cancel" It should be "Ok" | ||||
| Tags | No tags attached. | ||||
| Attached Files | |||||
| Patch | Yes | ||||
|
|
I agree with JLuc. Sometimes it happened to me to edit preferences then press Enter and lose all changes. Furthermore other dialogs do select "OK" by default rather than "Cancel". 14139-Patch.diff (640 bytes)
diff --git a/scribus/ui/preferencesdialogbase.ui b/scribus/ui/preferencesdialogbase.ui
--- a/scribus/ui/preferencesdialogbase.ui
+++ b/scribus/ui/preferencesdialogbase.ui
@@ -110,6 +110,9 @@
<property name="autoDefault">
<bool>false</bool>
</property>
+ <property name="default">
+ <bool>true</bool>
+ </property>
</widget>
</item>
<item>
@@ -117,9 +120,6 @@
<property name="text">
<string>&Cancel</string>
</property>
- <property name="default">
- <bool>true</bool>
- </property>
</widget>
</item>
</layout>
|
|
|
Fixed with recent QDialogButtonBox implementation |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2016-06-08 09:07 | JLuc | New Issue | |
| 2016-11-13 00:06 | FirasH | File Added: 14139-Patch.diff | |
| 2016-11-13 00:06 | FirasH | Note Added: 0042408 | |
| 2016-11-13 00:06 | FirasH | Reproducibility | have not tried => always |
| 2016-11-13 00:06 | FirasH | Status | new => confirmed |
| 2016-11-13 00:06 | FirasH | Patch | No => Yes |
| 2022-03-11 22:52 | cbradney | Assigned To | => cbradney |
| 2022-03-11 22:52 | cbradney | Status | confirmed => resolved |
| 2022-03-11 22:52 | cbradney | Resolution | open => fixed |
| 2022-03-11 22:52 | cbradney | Fixed in Version | => 1.7.0.svn |
| 2022-03-11 22:52 | cbradney | Note Added: 0049599 | |
| 2022-03-11 22:53 | cbradney | Fixed in Version | 1.7.0.svn => 1.6.0.svn |
| 2023-05-29 18:56 | cbradney | Status | resolved => closed |