View Issue Details

IDProjectCategoryView StatusLast Update
0014139ScribusUsabilitypublic2022-03-11 22:53
ReporterJLuc Assigned Tocbradney  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
PlatformLinuxOSUbuntuOS Version14.04
Product Version1.5.2 
Fixed in Version1.5.9.svn 
Summary0014139: Default button for preferences should be "Ok"
DescriptionDefault button for document preferences is "Cancel"

It should be "Ok"
TagsNo tags attached.
PatchYes

Activities

FirasH

2016-11-13 00:06

developer   ~0042408

I agree with JLuc.
Sometimes it happened to me to edit preferences then press Enter and lose all changes. Furthermore other dialogs do select "OK" by default rather than "Cancel".
14139-Patch.diff (640 bytes)   

diff --git a/scribus/ui/preferencesdialogbase.ui b/scribus/ui/preferencesdialogbase.ui
--- a/scribus/ui/preferencesdialogbase.ui
+++ b/scribus/ui/preferencesdialogbase.ui
@@ -110,6 +110,9 @@
        <property name="autoDefault">
         <bool>false</bool>
        </property>
+       <property name="default">
+        <bool>true</bool>
+       </property>
       </widget>
      </item>
      <item>
@@ -117,9 +120,6 @@
        <property name="text">
         <string>&amp;Cancel</string>
        </property>
-       <property name="default">
-        <bool>true</bool>
-       </property>
       </widget>
      </item>
     </layout>
14139-Patch.diff (640 bytes)   

cbradney

2022-03-11 22:52

administrator   ~0049599

Fixed with recent QDialogButtonBox implementation

Issue History

Date Modified Username Field Change
2016-06-08 09:07 JLuc New Issue
2016-11-13 00:06 FirasH File Added: 14139-Patch.diff
2016-11-13 00:06 FirasH Note Added: 0042408
2016-11-13 00:06 FirasH Reproducibility have not tried => always
2016-11-13 00:06 FirasH Status new => confirmed
2016-11-13 00:06 FirasH Patch No => Yes
2022-03-11 22:52 cbradney Assigned To => cbradney
2022-03-11 22:52 cbradney Status confirmed => resolved
2022-03-11 22:52 cbradney Resolution open => fixed
2022-03-11 22:52 cbradney Fixed in Version => 1.7.0.svn
2022-03-11 22:52 cbradney Note Added: 0049599
2022-03-11 22:53 cbradney Fixed in Version 1.7.0.svn => 1.5.9.svn