View Issue Details

IDProjectCategoryView StatusLast Update
0014450ScribusUser Interfacepublic2016-12-11 17:10
ReporterFirasH Assigned ToFirasH  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version1.5.3.svn 
Target VersionFixed in Version1.5.3.svn 
Summary0014450: Add missing vertical spacers in File > Document Setup dialog
DescriptionAdd missing vertical spacers in File > Document Setup... dialog.

This patch adds 2 vertical spacers (size consistent with overall ui):
1) Document Setup > General: between "Language" label and "Page Size" section
2) Guides > Placement: between "Placement" and "Distances" sections
Additional Information1.5.3.svn (21636)
TagsNo tags attached.
PatchYes

Relationships

child of 0013906 acknowledged Metabug: UI enhancement proposals (1.5.x.svn) 

Activities

FirasH

2016-12-11 12:10

developer  

14450-Patch.diff (1,603 bytes)

diff --git a/scribus/ui/prefs_documentsetupbase.ui b/scribus/ui/prefs_documentsetupbase.ui
--- a/scribus/ui/prefs_documentsetupbase.ui
+++ b/scribus/ui/prefs_documentsetupbase.ui
@@ -73,6 +73,22 @@
         </layout>
        </item>
        <item>
+        <spacer name="verticalSpacer">
+         <property name="orientation">
+          <enum>Qt::Vertical</enum>
+         </property>
+         <property name="sizeType">
+          <enum>QSizePolicy::Fixed</enum>
+         </property>
+         <property name="sizeHint" stdset="0">
+          <size>
+           <width>20</width>
+           <height>20</height>
+          </size>
+         </property>
+        </spacer>
+       </item>
+       <item>
         <widget class="QLabel" name="pageSizeTitleLabel">
          <property name="font">
           <font>
diff --git a/scribus/ui/prefs_guidesbase.ui b/scribus/ui/prefs_guidesbase.ui
--- a/scribus/ui/prefs_guidesbase.ui
+++ b/scribus/ui/prefs_guidesbase.ui
@@ -225,6 +225,22 @@
         </layout>
        </item>
        <item>
+        <spacer name="verticalSpacer_4">
+         <property name="orientation">
+          <enum>Qt::Vertical</enum>
+         </property>
+         <property name="sizeType">
+          <enum>QSizePolicy::Fixed</enum>
+         </property>
+         <property name="sizeHint" stdset="0">
+          <size>
+           <width>20</width>
+           <height>20</height>
+          </size>
+         </property>
+        </spacer>
+       </item>
+       <item>
         <widget class="QLabel" name="label_7">
          <property name="font">
           <font>
14450-Patch.diff (1,603 bytes)

FirasH

2016-12-11 17:10

developer   ~0042870

Thanks jghali!
Fixed in 1.5.3.svn (r21637).

Issue History

Date Modified Username Field Change
2016-12-11 12:10 FirasH New Issue
2016-12-11 12:10 FirasH File Added: 14450-Patch.diff
2016-12-11 12:41 FirasH Relationship added child of 0013906
2016-12-11 16:30 jghali Assigned To => FirasH
2016-12-11 16:30 jghali Status new => resolved
2016-12-11 16:30 jghali Resolution open => fixed
2016-12-11 16:30 jghali Fixed in Version => 1.5.3.svn
2016-12-11 16:30 jghali Summary Add missing vertical spacers in File > Document Setup... dialog => Add missing vertical spacers in File > Document Setup dialog
2016-12-11 17:10 FirasH Status resolved => closed
2016-12-11 17:10 FirasH Note Added: 0042870